New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829597 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
(OOO slow)
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task

Blocking:
issue 825428



Sign in to add a comment

[TTS] Plan for QPS increase for Unity

Project Member Reported by donnd@google.com, Apr 5 2018

Issue description

We need to plan for the increase in QPS to Coca and other backend services due to Unity, which is due to rollout in M-68.

Discussion thread here: https://groups.google.com/a/google.com/forum/#!topic/contextual-search-eng/qd7SeqEJs_k

Rough QPS estimate is an increase of 60% over current levels.
 

Comment 1 by donnd@google.com, Apr 5 2018

Evgeny would like sample traffic, but not sure how to do this or if it would really be useful (need to reply on this thread - https://groups.google.com/a/google.com/forum/#!topic/contextual-search-eng/y5N-4dtn-O8)

Status: Fixed (was: Assigned)
We've added a throttling mechanism, documented at https://go/cs-unity-throttle.
Labels: -M-68 M-70
Status: Started (was: Fixed)
Actually I'd like to add a UMA Histogram for when we throttle.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04d4389adfd1a1343bc70b6c98c1c73b8f810ea9

commit 04d4389adfd1a1343bc70b6c98c1c73b8f810ea9
Author: Donn Denman <donnd@chromium.org>
Date: Tue Sep 11 22:18:52 2018

[TTS] Add Unified Consent integration histograms.

Aids with the integration of Contextual Search with Unified Consent by
recording whether the user was previously undecided when their
preference gets changed due to Unified Consent, and whether to throttle
for every request and when throttling is in effect.

BUG= 829597 

Change-Id: I28c10e10faee25dd6741243c4560d9ed74fa75ef
Reviewed-on: https://chromium-review.googlesource.com/1214402
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590504}
[modify] https://crrev.com/04d4389adfd1a1343bc70b6c98c1c73b8f810ea9/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPreferenceHelper.java
[modify] https://crrev.com/04d4389adfd1a1343bc70b6c98c1c73b8f810ea9/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
[modify] https://crrev.com/04d4389adfd1a1343bc70b6c98c1c73b8f810ea9/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-70
I'd like to add these histograms (in #4) to M-70, should be safe to merge.
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 13

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 13

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd0abf1c8bffd59900fcb17cd203b0269929f991

commit dd0abf1c8bffd59900fcb17cd203b0269929f991
Author: Donn Denman <donnd@chromium.org>
Date: Thu Sep 13 17:53:26 2018

[TTS] Add Unified Consent integration histograms.

Aids with the integration of Contextual Search with Unified Consent by
recording whether the user was previously undecided when their
preference gets changed due to Unified Consent, and whether to throttle
for every request and when throttling is in effect.

BUG= 829597 

Change-Id: I28c10e10faee25dd6741243c4560d9ed74fa75ef
Reviewed-on: https://chromium-review.googlesource.com/1214402
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590504}(cherry picked from commit 04d4389adfd1a1343bc70b6c98c1c73b8f810ea9)
Reviewed-on: https://chromium-review.googlesource.com/1225102
Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#373}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/dd0abf1c8bffd59900fcb17cd203b0269929f991/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPreferenceHelper.java
[modify] https://crrev.com/dd0abf1c8bffd59900fcb17cd203b0269929f991/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
[modify] https://crrev.com/dd0abf1c8bffd59900fcb17cd203b0269929f991/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment