Spacey: Make one file-level comment instead of many repeated identical comments |
||||||
Issue descriptionIdea: When the same finding is found in a file many times (like, more than 10?), then instead of repeating the result with different numbers, create one summary comment at the top of the file. This might apply to other analyzers besides spacey, and might be something that could be done in the Tricium service, or left up to individual analyzers. If it's left up to individual analyzers, different analyzers could make summary comments in different ways and in different circumstances.
,
Apr 5 2018
Excellent idea, I'd say this should probably trigger at a lower number, like 3 or 4. I'd say it should be done by tricium itself, which is part of the value-add.
,
May 17 2018
,
May 30 2018
I think that doing this in Spacey initially might be a good first change which involves an analyzer, and Go code, etc. Discussed this briefly with Diego earlier.
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/d5530edf2d5676c3eff63a15c0886c5dc22f4980 commit d5530edf2d5676c3eff63a15c0886c5dc22f4980 Author: Diego Martinez <diegomtzg@google.com> Date: Fri Jun 01 18:41:38 2018 Group similar comments together into a single comment for spacey Bug: 829583 Change-Id: I4902b0b58221722b3965168d66afb2ec0458a0c8 Reviewed-on: https://chromium-review.googlesource.com/1081439 Commit-Queue: Diego Martinez <diegomtzg@google.com> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> [modify] https://crrev.com/d5530edf2d5676c3eff63a15c0886c5dc22f4980/go/src/infra/tricium/functions/spacey/spacey.go [modify] https://crrev.com/d5530edf2d5676c3eff63a15c0886c5dc22f4980/go/src/infra/tricium/functions/spacey/spacey_test.go
,
Jun 15 2018
,
Jun 15 2018
,
Jul 2
This is done and verified! :-) |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by qyears...@chromium.org
, Apr 5 2018Summary: Spacey: Make one file-level comment instead of many repeated identical comments (was: Spacey: Make one file-level comment)