Issue metadata
Sign in to add a comment
|
Pinned notifications should not show close buttons |
||||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3390.0 OS: Chrome OS What steps will reproduce the problem? (1) Create a pinned notification e.g. press caps lock while chrome://flags/#enable-system-tray-unified enabled (2) Close notification popup on the right bottom. (3) Open notification center from the right bottom. (4) Hover on notification. What is the expected result? Nothing should happen. What happens instead? Closed button is shown on the top right of the notification. When it's clicked, it's no-op. I remember previously it was working and the fix should be straightforward.
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12686f987b2b63a2903df059ebef273c0effdc90 commit 12686f987b2b63a2903df059ebef273c0effdc90 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Mon Apr 09 17:41:49 2018 Not show close for pinned notification on hover When the notification is * in notification center (not popup) * pinned then, we should not show close button on mouse hover. TEST=manual BUG= 829582 Change-Id: Idcd6cbe70fe880ddabc6d90bdd0a9f764a01295d Reviewed-on: https://chromium-review.googlesource.com/1000653 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#549215} [modify] https://crrev.com/12686f987b2b63a2903df059ebef273c0effdc90/ui/message_center/views/notification_view_md.cc
,
Apr 9 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tetsui@chromium.org
, Apr 6 2018