New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829576 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

PageInfoBubbleViewTest comments contradict expectations on whether a default permission should be displayed

Project Member Reported by reillyg@chromium.org, Apr 5 2018

Issue description

In PageInfoBubbleViewTest.SetPermissionInfo the test first expects that no permissions will be displayed when they are all set to their defaults,

  // Initially, no permissions are shown because they are all set to default.
  int num_expected_children = 0;
  EXPECT_EQ(num_expected_children, api_->permissions_view()->child_count());

At the end of the test the permission being tested has been returned to its default value and the comment here implies that this means that permission will not be displayed in the list. The EXPECT_EQ statement however tests the opposite, as |num_expected_children| has not been reset to 0. This test passes, indicating that the expectation expressed in the comment does not hold.

  // However, since the setting is now default, recreating the dialog with those
  // settings should omit the permission from the UI.
  api_->SetPermissionInfo(list);
  EXPECT_EQ(num_expected_children, api_->permissions_view()->child_count());

A comment is being added to this test pointing back at this issue in order to track work to reconcile these two conflicting statements.
 

Sign in to add a comment