New issue
Advanced search Search tips

Issue 829575 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Need a top-level Coordination Unit for browser scoped message / properties

Project Member Reported by chrisha@chromium.org, Apr 5 2018

Issue description

In order to support CPU and memory aggregation we need a signal to indicate that all ProcessCUs have been decorated with memory and CPU stats. This will then allow an observer to calculate and assign Page CPU + memory via a heuristic.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fee530e7439912af81b22e3cc50e7470bb60c32

commit 9fee530e7439912af81b22e3cc50e7470bb60c32
Author: Chris Hamilton <chrisha@chromium.org>
Date: Wed Apr 18 16:05:56 2018

Create SystemCoordinationUnit.

This acts as a "global" context for resource coordination signals that aren't appropriately aimed at any individual coordination unit. This will be required as part of the CPU and memory usage plumbing and aggregation.

BUG= 829575 

Change-Id: I5424351924a77c378c49c2d7aca892464a2d5064
Reviewed-on: https://chromium-review.googlesource.com/999017
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551703}
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/BUILD.gn
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/coordination_unit/coordination_unit_base.cc
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/coordination_unit/coordination_unit_manager.cc
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/coordination_unit/coordination_unit_manager.h
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.h
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.cc
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.h
[add] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/coordination_unit/system_coordination_unit_impl.cc
[add] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/coordination_unit/system_coordination_unit_impl.h
[add] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/coordination_unit/system_coordination_unit_impl_unittest.cc
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/observers/coordination_unit_graph_observer.h
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/public/cpp/BUILD.gn
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/public/cpp/coordination_unit_mojom_traits.cc
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/public/cpp/coordination_unit_types.h
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/public/cpp/resource_coordinator_interface.h
[add] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/public/cpp/system_resource_coordinator.cc
[add] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/public/cpp/system_resource_coordinator.h
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/public/mojom/coordination_unit.mojom
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/public/mojom/coordination_unit_provider.mojom
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/public/mojom/signals.mojom
[modify] https://crrev.com/9fee530e7439912af81b22e3cc50e7470bb60c32/services/resource_coordinator/resource_coordinator_service_unittest.cc

Labels: M-68 Hotlist-TooManyTabs
Status: Verified (was: Started)

Sign in to add a comment