v8_context_snapshot is not generated for headless static builds
Reported by
geo...@amazon.com,
Apr 5 2018
|
|||
Issue descriptionWhat steps will reproduce the problem? (1) Set up your gn args for a headless target. (1) Set the v8_use_external_startup_data and use_v8_context_snapshot flag to true. (2) Set the is_component_build to false (3) Build your target and run. What is the expected result? There should be no crash. What happens instead? The headless browser crashes resulting from the lack of v8_context_snapshot.bin. Please provide any additional information below. Attach a screenshot if possible. There was a previous change that fixed this here: https://chromium-review.googlesource.com/c/chromium/src/+/906750 but only included component builds.
,
Apr 19 2018
,
Apr 19 2018
I've put up a review for this task here https://chromium-review.googlesource.com/c/chromium/src/+/999013
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c73d90f0e77fa49a09d77f24db8f5f4dc86614ca commit c73d90f0e77fa49a09d77f24db8f5f4dc86614ca Author: George Adams <geoada@amazon.com> Date: Fri May 25 12:23:50 2018 Generate v8_context_snapshot.bin in Static Builds This file is necessary for builds in which the gn args v8_use_external_startup_data and use_v8_context_snapshot are both set to true. There was aprevious change to include this in the headless component, but it was only generated for component builds. The commit sha for the previous change is 8e676c0334e05728a7468d7395dba5faa9afd0b7. R=alexclarke@chromium.org, skyostil@chromium.org Bug: 829561 Change-Id: I34a6c8778d6cd7a8b9e635ab48d299163ddea936 Reviewed-on: https://chromium-review.googlesource.com/999013 Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#561839} [modify] https://crrev.com/c73d90f0e77fa49a09d77f24db8f5f4dc86614ca/AUTHORS [modify] https://crrev.com/c73d90f0e77fa49a09d77f24db8f5f4dc86614ca/headless/BUILD.gn
,
May 25 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by chrishtr@chromium.org
, Apr 10 2018