New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829553 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

ASSERT: variable->staticUse

Project Member Reported by ClusterFuzz, Apr 5 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6281536949977088

Fuzzer: libFuzzer_angle_translator_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  variable->staticUse
  sh::MarkActive
  sh::CollectVariablesTraverser::visitSymbol
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=547872:547880

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6281536949977088

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 5 2018

Labels: Test-Predator-Auto-Owner
Owner: oetu...@nvidia.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/angle/angle/+/94bbed1e2387130e58b3d59d489343b291129e57 (Collect static use information during parsing).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 2 by oetu...@nvidia.com, Apr 6 2018

Status: Started (was: Assigned)
There's a fairly simple bug - CollectVariables marks variables active just based on an invariant declaration, even if it shouldn't. Fix under way.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/bb52c523556e953ffe356ddb3935fec8e584166d

commit bb52c523556e953ffe356ddb3935fec8e584166d
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Mon Apr 09 17:35:14 2018

Invariant declaration doesn't make a variable active

Invariant declarations didn't affect static use before, but now they
are also skipped in CollectVariables so an invariant declaration is
not enough in itself to mark a variable as active. This fixes an
assert in CollectVariables.

BUG= chromium:829553 
TEST=angle_unittests

Change-Id: I3e51d2916f091bcc283af136a4abc846ff71447d
Reviewed-on: https://chromium-review.googlesource.com/999532
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

[modify] https://crrev.com/bb52c523556e953ffe356ddb3935fec8e584166d/src/tests/compiler_tests/CollectVariables_test.cpp
[modify] https://crrev.com/bb52c523556e953ffe356ddb3935fec8e584166d/src/compiler/translator/CollectVariables.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/153305614c4a101970146c195155d4a22d4a72e2

commit 153305614c4a101970146c195155d4a22d4a72e2
Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Apr 09 21:01:42 2018

Roll src/third_party/angle/ 6c59e4a15..bb52c5235 (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/6c59e4a156c3..bb52c523556e

$ git log 6c59e4a15..bb52c5235 --date=short --no-merges --format='%ad %ae %s'
2018-04-06 oetuaho Invariant declaration doesn't make a variable active

Created with:
  roll-dep src/third_party/angle
BUG= chromium:829553 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Ie3721859163572a63d911bc96afc473d9c44fdeb
Reviewed-on: https://chromium-review.googlesource.com/1003036
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#549272}
[modify] https://crrev.com/153305614c4a101970146c195155d4a22d4a72e2/DEPS

Comment 5 by oetu...@nvidia.com, Apr 10 2018

Status: Fixed (was: Started)
Project Member

Comment 6 by ClusterFuzz, Apr 10 2018

ClusterFuzz has detected this issue as fixed in range 549262:549273.

Detailed report: https://clusterfuzz.com/testcase?key=6281536949977088

Fuzzer: libFuzzer_angle_translator_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  variable->staticUse
  sh::MarkActive
  sh::CollectVariablesTraverser::visitSymbol
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=547872:547880
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=549262:549273

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6281536949977088

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Apr 10 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6281536949977088 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment