New issue
Advanced search Search tips

Issue 829542 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Determine why SETUP_AUTOMATIC has gone missing

Project Member Reported by skau@chromium.org, Apr 5 2018

Issue description

We no longer receive the SETUP_AUTOMATIC event in our printer metrics.  This is supposed to be emitted when printers are successfully configured using autoconf.  Results in the field should be >0.
 

Comment 1 by skau@chromium.org, Apr 5 2018

Owner: xlou@chromium.org
Status: Assigned (was: Available)
Owner: ----
Status: Available (was: Assigned)
Owner: pawliczek@chromium.org
Status: Assigned (was: Available)
Good starter bug.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1620c77457f9cfbf6230540bc564630c88a9e92

commit c1620c77457f9cfbf6230540bc564630c88a9e92
Author: Piotr Pawliczek <pawliczek@chromium.org>
Date: Fri Aug 03 18:37:48 2018

Adds a parameter is_automatic to the method CupsPrintersManager::PrinterInstalled

Inside the method mentioned above we were not able to distinguish
between manual and automatic printer installation. As a result in both
cases the event metrics::PrinterEventProto::SETUP_MANUAL was reported
and the event metrics::PrinterEventProto::SETUP_AUTOMATIC has never
appeared in logs. To solve this problem I have added bool parameter
is_automatic to the method that carries information about a type of
printer installation. It allows to distinguish between these two cases
and report a correct event.

BUG= chromium:829542 

TEST=tested manually on nautilus chrombook

Change-Id: I8d1f3bf70b9b218a734726f2fb1b8ab2af537184
Reviewed-on: https://chromium-review.googlesource.com/1161099
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580610}
[modify] https://crrev.com/c1620c77457f9cfbf6230540bc564630c88a9e92/chrome/browser/chromeos/arc/print/arc_print_service.cc
[modify] https://crrev.com/c1620c77457f9cfbf6230540bc564630c88a9e92/chrome/browser/chromeos/printing/cups_printers_manager.cc
[modify] https://crrev.com/c1620c77457f9cfbf6230540bc564630c88a9e92/chrome/browser/chromeos/printing/cups_printers_manager.h
[modify] https://crrev.com/c1620c77457f9cfbf6230540bc564630c88a9e92/chrome/browser/ui/webui/print_preview/local_printer_handler_chromeos.cc
[modify] https://crrev.com/c1620c77457f9cfbf6230540bc564630c88a9e92/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/c1620c77457f9cfbf6230540bc564630c88a9e92/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

Status: Fixed (was: Assigned)

Sign in to add a comment