conformance2/attribs/gl-bindAttribLocation-aliasing-inactive.html failing on no_angle |
|||||||||||||||
Issue descriptionThis test: conformance2/attribs/gl-bindAttribLocation-aliasing-inactive.html was newly added in: https://github.com/KhronosGroup/WebGL/pull/2616 It was seen failing in a WebGL roll: https://chromium-review.googlesource.com/c/chromium/src/+/996896 and suppressed in that roll.
,
Apr 10 2018
I'm fixing this.
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/ebd6e2df290afca3e3b1ceafb271c2f11e16a90f commit ebd6e2df290afca3e3b1ceafb271c2f11e16a90f Author: Olli Etuaho <oetuaho@nvidia.com> Date: Wed Apr 11 07:06:39 2018 Take all attributes into account when checking for aliasing This makes ANGLE to follow GLSL ES 3.00.6 spec section 12.46. The spec requires that all attributes are taken into account when checking for aliasing, regardless of if they are active or not. WebGL 2.0 spec was also recently changed to reflect GLSL ES 3.00.6 correctly. Aliasing checks for GLSL ES 1.00 shaders are left as-is. BUG= chromium:829541 TEST=angle_end2end_tests, WebGL conformance tests Change-Id: I71c36ac123f18dadf075e81f93af29321c15136b Reviewed-on: https://chromium-review.googlesource.com/1005077 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> [modify] https://crrev.com/ebd6e2df290afca3e3b1ceafb271c2f11e16a90f/src/tests/gl_tests/VertexAttributeTest.cpp [modify] https://crrev.com/ebd6e2df290afca3e3b1ceafb271c2f11e16a90f/src/libANGLE/Shader.h [modify] https://crrev.com/ebd6e2df290afca3e3b1ceafb271c2f11e16a90f/src/libANGLE/Shader.cpp [modify] https://crrev.com/ebd6e2df290afca3e3b1ceafb271c2f11e16a90f/src/libANGLE/Program.cpp
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5eb48d7ec46ca86e8f274428eb9d0b42bb2bbd28 commit 5eb48d7ec46ca86e8f274428eb9d0b42bb2bbd28 Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Apr 11 09:35:04 2018 Roll src/third_party/angle/ 568fc39ba..ebd6e2df2 (1 commit) https://chromium.googlesource.com/angle/angle.git/+log/568fc39ba45a..ebd6e2df290a $ git log 568fc39ba..ebd6e2df2 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 oetuaho Take all attributes into account when checking for aliasing Created with: roll-dep src/third_party/angle BUG= chromium:829541 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I91f528e2012e1f198b8affe4a3f855d57a46bccd Reviewed-on: https://chromium-review.googlesource.com/1006531 Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549840} [modify] https://crrev.com/5eb48d7ec46ca86e8f274428eb9d0b42bb2bbd28/DEPS
,
Apr 23 2018
The test is passing on latest Chromium - kainino, can you take care of lifting the suppression?
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c002763faf7041f2021be79b86e5e8e85022cb2 commit 4c002763faf7041f2021be79b86e5e8e85022cb2 Author: Kai Ninomiya <kainino@chromium.org> Date: Mon Apr 23 16:58:35 2018 remove webgl suppression for gl-bindAttribLocation-aliasing-inactive.html TBR=kbr@chromium.org Bug: 829541 Change-Id: I6b6e481ec11abf895debe2cf3cfe44e812b2b436 Reviewed-on: https://chromium-review.googlesource.com/1023715 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#552732} [modify] https://crrev.com/4c002763faf7041f2021be79b86e5e8e85022cb2/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Apr 23 2018
Done, thanks!
,
Apr 23 2018
Found that this test is still failing on mac/intel and linux/intel. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Release%20(Intel)/2169 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Release%20(Intel%20HD%20630)/1946 (I'm suppressing them.) Olli, please take a look (we can open a new bug if needed)
,
Apr 23 2018
We have try bot failures after r552732. See bug 835967 .
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19f1a9f45a403f03ce0b66b5bc21862297868024 commit 19f1a9f45a403f03ce0b66b5bc21862297868024 Author: Lei Zhang <thestig@chromium.org> Date: Mon Apr 23 20:59:02 2018 Revert "remove webgl suppression for gl-bindAttribLocation-aliasing-inactive.html" This reverts commit 4c002763faf7041f2021be79b86e5e8e85022cb2. Reason for revert: Causing CQ failures. Original change's description: > remove webgl suppression for gl-bindAttribLocation-aliasing-inactive.html > > TBR=kbr@chromium.org > > Bug: 829541 > Change-Id: I6b6e481ec11abf895debe2cf3cfe44e812b2b436 > Reviewed-on: https://chromium-review.googlesource.com/1023715 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552732} TBR=kainino@chromium.org Change-Id: Id155fd5d4d80143a8880ce6a53b7d993da4bab4c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829541 , 835967 Reviewed-on: https://chromium-review.googlesource.com/1024718 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#552825} [modify] https://crrev.com/19f1a9f45a403f03ce0b66b5bc21862297868024/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Apr 24 2018
Sorry - I messed up when committing the first un-suppression (omitted the Cq-Include-Trybots line). Relanding (with proper CQ this time).
,
Apr 24 2018
Tried landing that patch: https://chromium-review.googlesource.com/c/chromium/src/+/1024400 But I'm still seeing failures on Linux/NVIDIA and Mac/AMD as well. So there seem to still be quite a few failures in this area. I think I'm going to not land the unsuppression yet until we investigate this a little further.
,
Apr 24 2018
Huh, that's odd. I was fairly certain that with the added validation in ANGLE's front end the test should pass across platforms. I can try to see if I can still reproduce issues on Linux/NVIDIA, so far I just tested this on Windows.
,
Apr 27 2018
,
Apr 30 2018
Now I realized I had made a simple mistake - ANGLE's validation is not used across all platforms. So the issue is really fixed only on Windows. The issue will be fixed for good once the passthrough command buffer lands on all platforms. If there's a bug for enabling the passthrough cmd buffer, that could be added to "blocked on". I'm not looking to port ANGLE's validation to the validating command buffer at the moment, so leaving this as available.
,
Apr 30 2018
Aha, of course, thanks Olli. Sorry I didn't catch that - I just made the same mistake a week earlier. I'll update the expectations accordingly.
,
Apr 30 2018
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ee541187c9c28ae8e394702bb7e0b6d0066bcf0 commit 0ee541187c9c28ae8e394702bb7e0b6d0066bcf0 Author: Kai Ninomiya <kainino@chromium.org> Date: Mon Apr 30 21:41:26 2018 Reduce webgl2 suppression for gl-bindAttribLocation-aliasing-inactive.html Now applies only to no_angle configurations. TBR=kbr@chromium.org Bug: 829541 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie12f38d0f6c181a9652c71b54139533986ff1f16 Reviewed-on: https://chromium-review.googlesource.com/1024400 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#554889} [modify] https://crrev.com/0ee541187c9c28ae8e394702bb7e0b6d0066bcf0/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
,
Oct 9
,
Nov 27
,
Nov 27
,
Dec 1
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7c66cacbca6f9085e5b89b24948ae8a70ddb3ca commit d7c66cacbca6f9085e5b89b24948ae8a70ddb3ca Author: James Darpinian <jdarpinian@chromium.org> Date: Tue Dec 04 00:54:53 2018 gpu: Forbid aliasing inactive attributes in GLSL 3+ The GLSL 3.00.6 spec forbids aliasing of attributes even if they are inactive. Earlier versions of GLSL still allow it. This mirrors an ANGLE change: http://crrev.com/c/1005077 Fixes WebGL conformance test conformance2/attribs/gl-bindAttribLocation-aliasing-inactive.html Bug: 829541 Change-Id: I8163c3fac3ca7b5b0c6efd9f9a88b9f92c2d19f6 Reviewed-on: https://chromium-review.googlesource.com/c/1359413 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#613362} [modify] https://crrev.com/d7c66cacbca6f9085e5b89b24948ae8a70ddb3ca/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/d7c66cacbca6f9085e5b89b24948ae8a70ddb3ca/gpu/command_buffer/service/program_manager.cc
,
Dec 4
Fixed in the validating command buffer too. |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Apr 9 2018