New issue
Advanced search Search tips

Issue 829537 link

Starred by 1 user
Status: Fixed
Owner:
bajones@chromium.org
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 3
Type: Bug
Proj-XR



Sign in to add a comment

Enable more accurate framebuffer scaling for WebXR

Project Member Reported by bajones@chromium.org, Apr 5 2018 
WebXR has a feature that allows users to request a framebuffer scalar to indicate the quality they want for the allocated buffer. (1.0 == 1:1 native resolution, 0.5 == half that, 0.0 == use the system recommendation.)

At the moment that feature is not functioning as well as it could because the VR service only communicates the recommended framebuffer size, which on mobile is significantly lower than the native size. The implementation should be updated to report both the native size and the recommended scalar so that WebXR implementations can perform more accurately.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9084e42d6ea2597aed3372fa5bf4cb05b7619146

commit 9084e42d6ea2597aed3372fa5bf4cb05b7619146
Author: Brandon Jones <bajones@chromium.org>
Date: Fri Apr 06 22:12:03 2018

Report the maximum and recommended VR framebuffer resolution separately

This enables WebXR to report 1:1 resolutions when requested by the
developer.

Bug:  829537 
Change-Id: Iad0cf4e4f9dda94e8587813102bc0a049105925f
Reviewed-on: https://chromium-review.googlesource.com/998690
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548946}
[modify] https://crrev.com/9084e42d6ea2597aed3372fa5bf4cb05b7619146/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/9084e42d6ea2597aed3372fa5bf4cb05b7619146/device/vr/oculus/oculus_device.cc
[modify] https://crrev.com/9084e42d6ea2597aed3372fa5bf4cb05b7619146/device/vr/openvr/openvr_device.cc
[modify] https://crrev.com/9084e42d6ea2597aed3372fa5bf4cb05b7619146/device/vr/public/mojom/vr_service.mojom
[modify] https://crrev.com/9084e42d6ea2597aed3372fa5bf4cb05b7619146/third_party/WebKit/LayoutTests/vr/getEyeParameters_match.html
[modify] https://crrev.com/9084e42d6ea2597aed3372fa5bf4cb05b7619146/third_party/WebKit/LayoutTests/vr/resources/fake-vr-displays.js
[modify] https://crrev.com/9084e42d6ea2597aed3372fa5bf4cb05b7619146/third_party/WebKit/LayoutTests/xr/resources/xr-device-mocking.js
[modify] https://crrev.com/9084e42d6ea2597aed3372fa5bf4cb05b7619146/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/9084e42d6ea2597aed3372fa5bf4cb05b7619146/third_party/WebKit/Source/modules/vr/VREyeParameters.cpp
[modify] https://crrev.com/9084e42d6ea2597aed3372fa5bf4cb05b7619146/third_party/WebKit/Source/modules/vr/VREyeParameters.h
[modify] https://crrev.com/9084e42d6ea2597aed3372fa5bf4cb05b7619146/third_party/WebKit/Source/modules/xr/XRSession.cpp
[modify] https://crrev.com/9084e42d6ea2597aed3372fa5bf4cb05b7619146/third_party/WebKit/Source/modules/xr/XRSession.h
[modify] https://crrev.com/9084e42d6ea2597aed3372fa5bf4cb05b7619146/third_party/WebKit/Source/modules/xr/XRWebGLLayer.cpp

Comment 2 by bajones@chromium.org, Apr 6 2018

Status: Fixed (was: Started)

Comment 3 by dougman@chromium.org, May 8 2018

Labels: Test-Complete

Comment 4 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR
►

Sign in to add a comment