Collect EDID colorimetry failures via UMA |
||
Issue descriptiondrm_util.cc has a couple of calls to parse the EDID blob [1] and/or to check its sanity [2]. These situations need to be tracked via UMAs [1] https://cs.chromium.org/chromium/src/ui/ozone/platform/drm/common/drm_util.cc?q=drm_util.&sq=package:chromium&dr=C&l=415 [2] https://cs.chromium.org/chromium/src/ui/ozone/platform/drm/common/drm_util.cc?q=drm_util.&sq=package:chromium&dr=C&l=663
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c474af563adbcba225b58f7d674a271aa8cbc2e2 commit c474af563adbcba225b58f7d674a271aa8cbc2e2 Author: Andres Calderon Jaramillo <andrescj@chromium.org> Date: Wed Apr 25 21:51:43 2018 Add UMAs to collect EDID colorimetry failures. This CL adds two metrics in drm_util.cc: - DrmUtil.CreateDisplaySnapshot.HasEdidBlob (boolean): to detect whether an EDID blob is detected in the CreateDisplaySnapshot function. There are no existing unit tests for this function, so no tests are added for this metric. - DrmUtil.GetColorSpaceFromEdid.ChecksOutcome (histogram): to detect whether the sanity checks pass in the GetColorSpaceFromEdid function (or which one fails). Existing unit tests are modified to test this metric. Also, some unused includes are removed from drm_util_unittest.cc. Bug: 829506 Change-Id: Ib1cfc14577630e6649640da9b0a0b663a36296d5 Reviewed-on: https://chromium-review.googlesource.com/1014522 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#553773} [modify] https://crrev.com/c474af563adbcba225b58f7d674a271aa8cbc2e2/tools/metrics/histograms/enums.xml [modify] https://crrev.com/c474af563adbcba225b58f7d674a271aa8cbc2e2/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/c474af563adbcba225b58f7d674a271aa8cbc2e2/ui/ozone/platform/drm/common/drm_util.cc [modify] https://crrev.com/c474af563adbcba225b58f7d674a271aa8cbc2e2/ui/ozone/platform/drm/common/drm_util.h [modify] https://crrev.com/c474af563adbcba225b58f7d674a271aa8cbc2e2/ui/ozone/platform/drm/common/drm_util_unittest.cc
,
Apr 25 2018
andrescj@, does #2 fix this issue? (Mark it if so)
,
Apr 26 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by mcasas@chromium.org
, Apr 5 2018