Making CupsPrintersManager a BrowserContextKeyedService |
|||
Issue descriptionShould bring CupsPrintersManager in line with SyncedPrintersManager and CupsPrintJobManager as a BrowserContextKeyedService. Gives it an established lifetime and becomes sole source of truth on current view of configured printers on system for current profile.
,
Apr 18 2018
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0c32460d2f5930e5cdd2c44749c18ca7e63c3cf commit e0c32460d2f5930e5cdd2c44749c18ca7e63c3cf Author: Luum Habtemariam <luum@chromium.org> Date: Wed Apr 25 18:16:54 2018 Modifying CupsPrinters users APIs CupsPrinters is becoming a BCKS. This change modifies services using it to create and store handles to it correctly. BUG= chromium:829492 TEST=manually ensured behavior unchanged Change-Id: Ibca680fd3b29314b38a72288ed28f6b0f2dca42e Reviewed-on: https://chromium-review.googlesource.com/998612 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#553663} [modify] https://crrev.com/e0c32460d2f5930e5cdd2c44749c18ca7e63c3cf/chrome/browser/chromeos/arc/print/arc_print_service.cc [modify] https://crrev.com/e0c32460d2f5930e5cdd2c44749c18ca7e63c3cf/chrome/browser/ui/webui/print_preview/local_printer_handler_chromeos.cc [modify] https://crrev.com/e0c32460d2f5930e5cdd2c44749c18ca7e63c3cf/chrome/browser/ui/webui/print_preview/local_printer_handler_chromeos.h [modify] https://crrev.com/e0c32460d2f5930e5cdd2c44749c18ca7e63c3cf/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc [modify] https://crrev.com/e0c32460d2f5930e5cdd2c44749c18ca7e63c3cf/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h
,
May 1 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Apr 18 2018