New issue
Advanced search Search tips

Issue 829492 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Making CupsPrintersManager a BrowserContextKeyedService

Project Member Reported by luum@chromium.org, Apr 5 2018

Issue description

Should bring CupsPrintersManager in line with SyncedPrintersManager and CupsPrintJobManager as a BrowserContextKeyedService. 

Gives it an established lifetime and becomes sole source of truth on current view of configured printers on system for current profile.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6efc016bb3d12a61e673b27179a804898b84caae

commit 6efc016bb3d12a61e673b27179a804898b84caae
Author: Luum Habtemariam <luum@chromium.org>
Date: Wed Apr 18 17:32:36 2018

Making CupsPrintersManager a BCKS

This change will keep this manager's lifetime in line with its partners,
SyncedPrintersManager & CupsPrintJobManager. Also keeps only one intance
around per profile, becoming the source of truth for users' current view
of available configured printers

Dependent CL with API changes

BUG= chromium:829492 
TEST=manually confirmed correct shutdown behavior

Change-Id: Ief45ebbf6610fef0d5b4c294a8c6cc923899ddb3
Reviewed-on: https://chromium-review.googlesource.com/998531
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551729}
[modify] https://crrev.com/6efc016bb3d12a61e673b27179a804898b84caae/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/6efc016bb3d12a61e673b27179a804898b84caae/chrome/browser/chromeos/printing/cups_print_job_manager_factory.cc
[modify] https://crrev.com/6efc016bb3d12a61e673b27179a804898b84caae/chrome/browser/chromeos/printing/cups_printers_manager.h
[add] https://crrev.com/6efc016bb3d12a61e673b27179a804898b84caae/chrome/browser/chromeos/printing/cups_printers_manager_factory.cc
[add] https://crrev.com/6efc016bb3d12a61e673b27179a804898b84caae/chrome/browser/chromeos/printing/cups_printers_manager_factory.h
[modify] https://crrev.com/6efc016bb3d12a61e673b27179a804898b84caae/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc

Comment 2 Deleted

Comment 3 by luum@chromium.org, Apr 18 2018

Status: Started (was: Fixed)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0c32460d2f5930e5cdd2c44749c18ca7e63c3cf

commit e0c32460d2f5930e5cdd2c44749c18ca7e63c3cf
Author: Luum Habtemariam <luum@chromium.org>
Date: Wed Apr 25 18:16:54 2018

Modifying CupsPrinters users APIs

CupsPrinters is becoming a BCKS. This change modifies services using it
to create and store handles to it correctly.

BUG= chromium:829492 
TEST=manually ensured behavior unchanged

Change-Id: Ibca680fd3b29314b38a72288ed28f6b0f2dca42e
Reviewed-on: https://chromium-review.googlesource.com/998612
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553663}
[modify] https://crrev.com/e0c32460d2f5930e5cdd2c44749c18ca7e63c3cf/chrome/browser/chromeos/arc/print/arc_print_service.cc
[modify] https://crrev.com/e0c32460d2f5930e5cdd2c44749c18ca7e63c3cf/chrome/browser/ui/webui/print_preview/local_printer_handler_chromeos.cc
[modify] https://crrev.com/e0c32460d2f5930e5cdd2c44749c18ca7e63c3cf/chrome/browser/ui/webui/print_preview/local_printer_handler_chromeos.h
[modify] https://crrev.com/e0c32460d2f5930e5cdd2c44749c18ca7e63c3cf/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/e0c32460d2f5930e5cdd2c44749c18ca7e63c3cf/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

Comment 5 by skau@chromium.org, May 1 2018

Status: Fixed (was: Started)

Sign in to add a comment