The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/521940b79ab1be18d33bff40a5a74f5afc53024d

commit 521940b79ab1be18d33bff40a5a74f5afc53024d
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu Apr 05 19:07:11 2018

Don't warn about loaded shell extensions and IMEs

This is because shell extensions don't specifically target Chrome, they
just get automatically loaded by the OS. These will get blocked in phase
2 of third-party software blocking.

For IMEs, they are allowed because there is no viable alternative for
their implementation.

Bug:  829490 
Change-Id: I501aad6e77734336161448f0e8e91ac78ec6d40d
Reviewed-on: https://chromium-review.googlesource.com/996586
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548517}
[modify] https://crrev.com/521940b79ab1be18d33bff40a5a74f5afc53024d/chrome/browser/conflicts/problematic_programs_updater_win.cc
[modify] https://crrev.com/521940b79ab1be18d33bff40a5a74f5afc53024d/chrome/browser/conflicts/problematic_programs_updater_win_unittest.cc

Requesting merge to m66 for this small bug fix. This is a low risk change (7 lines change + new test) that is required for a launch planned in m66.

This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

How does the change look in Canary? Has it been verified?

Can you please confirm? How safe is this merge overall?

In my opinion, r548517 is safe to merge. I don't have visibility into metrics that demonstrate that it is having the desired effect, but I can't see how the CL could make Chrome less stable.

Approving merge to M66. Branch:3359

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9df006bd74d5015d47bce16bb012b029906160eb

commit 9df006bd74d5015d47bce16bb012b029906160eb
Author: Patrick Monette <pmonette@chromium.org>
Date: Tue Apr 10 20:43:31 2018

Don't warn about loaded shell extensions and IMEs

This is because shell extensions don't specifically target Chrome, they
just get automatically loaded by the OS. These will get blocked in phase
2 of third-party software blocking.

For IMEs, they are allowed because there is no viable alternative for
their implementation.

Bug:  829490 
Change-Id: I501aad6e77734336161448f0e8e91ac78ec6d40d
Reviewed-on: https://chromium-review.googlesource.com/996586
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#548517}(cherry picked from commit 521940b79ab1be18d33bff40a5a74f5afc53024d)
Reviewed-on: https://chromium-review.googlesource.com/1005518
Cr-Commit-Position: refs/branch-heads/3359@{#663}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/9df006bd74d5015d47bce16bb012b029906160eb/chrome/browser/conflicts/problematic_programs_updater_win.cc
[modify] https://crrev.com/9df006bd74d5015d47bce16bb012b029906160eb/chrome/browser/conflicts/problematic_programs_updater_win_unittest.cc

I was just about to respond when I saw that you merged it. Thanks Greg!

I've checked on Canary and it indeed seems to work. The Incompatible Applications warning is not shown for Shell extensions.

Killer. Rock on!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf11ecbf91e542cfe65dc64194efd37e86502671

commit cf11ecbf91e542cfe65dc64194efd37e86502671
Author: Patrick Monette <pmonette@chromium.org>
Date: Mon May 14 23:18:49 2018

Don't warn about loaded shell extensions and IMEs

This is because shell extensions don't specifically target Chrome, they
just get automatically loaded by the OS. These will get blocked in phase
2 of third-party software blocking.

For IMEs, they are allowed because there is no viable alternative for
their implementation.

This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/996586
that got lost when I renamed the class here:
https://chromium-review.googlesource.com/c/chromium/src/+/993699

Tbr: grt@chromium.org
Bug:  829490 
Change-Id: I96a9382e0dd745023ea71ddcdbb2f31fac7abfa5
Reviewed-on: https://chromium-review.googlesource.com/1058552
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558519}
[modify] https://crrev.com/cf11ecbf91e542cfe65dc64194efd37e86502671/chrome/browser/conflicts/incompatible_applications_updater_win.cc
[modify] https://crrev.com/cf11ecbf91e542cfe65dc64194efd37e86502671/chrome/browser/conflicts/incompatible_applications_updater_win_unittest.cc

Requesting merge to m67. Fixes an important bug for a feature we want to launch for that milestone.

I'm refering to the CL at comment #12

This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Is the CL listed at #12 looking good in canary?

Yes. No crash and it is working correctly.

Approving merge to M67 branch 3396 for CL listed at #12 per comment #17. Additional details - https://bugs.chromium.org/p/chromium/issues/detail?id=717696#c72.

During the merge, I noticed that this CL is not applicable to m67. The bug it is fixing was introduced in m68.