Deep Linked presentation ends up in VR browsing if Chrome's FRE wasn't completed |
|||||||||||||
Issue description
Chrome: 67.0.3387.0
VRCore: 1.13.185188193
Android N
Device: S8+
What steps will reproduce the problem?
(1) Go to Apps > { Chrome | Chrome Beta | Chrome Canary | Chrome Dev | Chromium } > Storage > MANAGE SPACE > CLEAR ALL DATA
(2) Enter VR in Daydream Home
(3) Click on Deep Linked WebVR tile e.g. https://webvr.info/samples/03-vr-presentation.html
(4) When prompted, remove device from headset
(5) Chrome is opened showing the First Run Experience. Follow prompts.
What is the expected result? Not sure, maybe the browser should remain in 2D mode? Or Chrome should be closed and the Deep Link should be started?
What happens instead? Once the FRE is completed, https://webvr.info/samples/03-vr-presentation.html is loaded in VR browsing is triggered. The WebVR presentation is not triggered.
,
Apr 6 2018
Yash, maybe we should just always auto-present the deep-linked app when in VR, even after FRE, or when resuming from recent apps, etc. so that it feels more like a standalone app. We've already vetted these apps and know they were launched through DD home, so it should be fine?
,
Apr 6 2018
Michael, I think that's reasonable. We have to make sure we handle state correctly and don't accidentally autopresent for non-trusted intents. Regarding this bug, this behavior is expected. We strip out the trusted intent extra that tells us to auto-present for an intent. Previously, we'd just not enter VR, but now that we support entering VR from intents, we enter VR instead. This is an edge case with an acceptable current behavior, so lowering priority.
,
Apr 6 2018
,
Apr 12 2018
,
Apr 13 2018
,
Apr 18 2018
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9943fa5d9c30965f1c71a95bf92d624ae55cd98 commit c9943fa5d9c30965f1c71a95bf92d624ae55cd98 Author: Yash Malik <ymalik@google.com> Date: Thu Apr 19 14:47:23 2018 VR: Autopresent after FRE completion Bug: 829480 Change-Id: Ib0a502d27db0b0481fb640611a9491b019bcf7fc Reviewed-on: https://chromium-review.googlesource.com/1017342 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552013} [modify] https://crrev.com/c9943fa5d9c30965f1c71a95bf92d624ae55cd98/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java [modify] https://crrev.com/c9943fa5d9c30965f1c71a95bf92d624ae55cd98/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java [modify] https://crrev.com/c9943fa5d9c30965f1c71a95bf92d624ae55cd98/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrIntentUtils.java
,
Apr 19 2018
,
Apr 20 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65587abe49afb61daed5f40d0353fc65f5fff3eb commit 65587abe49afb61daed5f40d0353fc65f5fff3eb Author: Yash Malik <ymalik@google.com> Date: Mon Apr 23 14:21:33 2018 VR: Autopresent after FRE completion Bug: 829480 Change-Id: Ib0a502d27db0b0481fb640611a9491b019bcf7fc Reviewed-on: https://chromium-review.googlesource.com/1017342 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#552013}(cherry picked from commit c9943fa5d9c30965f1c71a95bf92d624ae55cd98) Reviewed-on: https://chromium-review.googlesource.com/1024090 Reviewed-by: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#205} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/65587abe49afb61daed5f40d0353fc65f5fff3eb/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java [modify] https://crrev.com/65587abe49afb61daed5f40d0353fc65f5fff3eb/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java [modify] https://crrev.com/65587abe49afb61daed5f40d0353fc65f5fff3eb/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrIntentUtils.java
,
Apr 23 2018
,
May 10 2018
,
Jul 4
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by billorr@chromium.org
, Apr 5 2018Status: Available (was: Untriaged)