New issue
Advanced search Search tips

Issue 829473 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Tapping a blank region of the launcher should close the launcher

Project Member Reported by newcomer@chromium.org, Apr 5 2018

Issue description

Feature request.

Tapping or clicking any blank region of the launcher should close the launcher.

Currently we just check if the tap or click is outside of the AppsGridView, if so we close the launcher.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6c0557b00447a5f2044cf03c384d29797578f0f

commit c6c0557b00447a5f2044cf03c384d29797578f0f
Author: Alex Newcomer <newcomer@chromium.org>
Date: Mon Apr 09 22:11:22 2018

cros: Dismiss AppList when a tap or click reaches an empty area

The old AppList behavior dismissed the Applist when a tap or click was
not within the AppsGridView bounds. Instead we would like to dismiss the
AppList if a tap or click lands on an empty region.

Bug:  829473 
Change-Id: Iafa4753f917aef6839b151e83b314a6b036dc906
Reviewed-on: https://chromium-review.googlesource.com/998521
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549296}
[modify] https://crrev.com/c6c0557b00447a5f2044cf03c384d29797578f0f/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/c6c0557b00447a5f2044cf03c384d29797578f0f/ui/app_list/views/app_list_view_unittest.cc
[modify] https://crrev.com/c6c0557b00447a5f2044cf03c384d29797578f0f/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/c6c0557b00447a5f2044cf03c384d29797578f0f/ui/app_list/views/apps_grid_view.h

Status: fix (was: Started)
Status: Fixed (was: Fix)

Sign in to add a comment