New issue
Advanced search Search tips

Issue 829466 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

isolate: More gracefully handle broken symlinks when isolating a dir

Project Member Reported by bpastene@chromium.org, Apr 5 2018

Issue description

When trying to isolate a directory that contains broken symlinks, isolate.py will either:
- fail early if --ignore_broken_items is not set
- skip the entire directory if --ignore_broken_items is set

In the 2nd option, would it not make more sense to isolate what isn't broken? As it is, it skips the entire directory even if it contains valid files. I think a best effort approach to isolating the directory would be more appropriate.
 
Status: WontFix (was: Untriaged)
Turns out the python and go versions differ in implementation. The py version will skip the entire dir if it contains broken links, while the go version packages everything up, broken links included.

Since we've switched all the bots over to the go version, I think this is pretty much a wontfix.

Sign in to add a comment