New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 829464 link

Starred by 1 user
Status: Fixed
Owner:
█ wnwen@chromium.org
OOO until Feb 4th
Closed: Apr 2018
Cc:
█ vollick@chromium.org
agrieve@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Supersize: Add other .so files to .other

Project Member Reported by wnwen@chromium.org, Apr 5 2018 
Currently we skip all .so files, only skip the one that we analyzed.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bed59e4cf69c49f2f923ec2518d32e1d0e895d7

commit 0bed59e4cf69c49f2f923ec2518d32e1d0e895d7
Author: Peter Wen <wnwen@chromium.org>
Date: Thu Apr 05 19:56:02 2018

Supersize: Include other .so files

Other .so files were being skipped since we assumed only a single .so
file would be in each apk. Now they are added as .other symbols.

Bug:  829464 
Change-Id: If23e124caac6e2097891015a183b19bfc8687ed8
Reviewed-on: https://chromium-review.googlesource.com/998527
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548533}
[modify] https://crrev.com/0bed59e4cf69c49f2f923ec2518d32e1d0e895d7/tools/binary_size/libsupersize/archive.py
[modify] https://crrev.com/0bed59e4cf69c49f2f923ec2518d32e1d0e895d7/tools/binary_size/libsupersize/integration_test.py
[modify] https://crrev.com/0bed59e4cf69c49f2f923ec2518d32e1d0e895d7/tools/binary_size/libsupersize/testdata/Archive_Apk.golden

Comment 2 by wnwen@chromium.org, Apr 5 2018

Status: Fixed (was: Assigned)
@Ian - now you can try supersize again. :)
►

Sign in to add a comment