New issue
Advanced search Search tips

Issue 829429 link

Starred by 2 users
Status: Fixed
Owner:
b...@chromium.org
Closed: Apr 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Remove HttpStreamFactory interface

Project Member Reported by b...@chromium.org, Apr 5 2018 
Remove HttpStreamFactory abstract class, rename HttpStreamFactoryImpl to HttpStreamFactory.  Also remove HttpStreamRequest abstract class, rename HttpStreamFactoryImpl::Request to HttpStreamRequest.

These extra layers result in longer class names, more vtables, more source code, larger binaries.  The interfaces are only there so that they can have a fake implementation in only one test file, used in only four tests, that provide relatively little value.

Comment 1 by b...@chromium.org, Apr 5 2018

Labels: OS-Android OS-Chrome OS-Fuchsia OS-iOS OS-Mac OS-Windows
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fcf4fa42b6bad1258beb475aefb12a97986f073

commit 2fcf4fa42b6bad1258beb475aefb12a97986f073
Author: Bence Béky <bnc@chromium.org>
Date: Fri Apr 06 20:06:01 2018

Remove FakeStream, FakeStreamRequest, FakeStreamFactory.

Remove HttpNetworkTransactionTest.SetStreamRequestPriorityOnStart,
SetStreamRequestPriority, SetStreamPriority tests.  Add
SpdyNetworkTransactionTest.SetPriority instead, which arguably does not
quite provide an equal amount of coverage or an equal level of
abstraction, but at least covers basic SetPriority functionalily.

Rewrite HttpNetworkTransactionTest.CreateWebSocketHandshakeStream to use
actual streams and mock data.  In order to do that,
HttpStreamFactoryImpl::Request::websocket_handshake_stream_create_helper()
has to be moved to the base class, but since this derived class will be
merged into the base class anyway, this will have no long term effects.

Bug:  829429 
Change-Id: I3691c331bbb89fc30eb5f62853706ab01b24e120
Reviewed-on: https://chromium-review.googlesource.com/998760
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548912}
[modify] https://crrev.com/2fcf4fa42b6bad1258beb475aefb12a97986f073/net/http/http_network_transaction.h
[modify] https://crrev.com/2fcf4fa42b6bad1258beb475aefb12a97986f073/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/2fcf4fa42b6bad1258beb475aefb12a97986f073/net/http/http_stream_factory.h
[modify] https://crrev.com/2fcf4fa42b6bad1258beb475aefb12a97986f073/net/http/http_stream_factory_impl_request.cc
[modify] https://crrev.com/2fcf4fa42b6bad1258beb475aefb12a97986f073/net/http/http_stream_factory_impl_request.h
[modify] https://crrev.com/2fcf4fa42b6bad1258beb475aefb12a97986f073/net/spdy/chromium/spdy_network_transaction_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b44abf85be940e6acf5cf3e900a4d36f0d05e96

commit 6b44abf85be940e6acf5cf3e900a4d36f0d05e96
Author: Bence Béky <bnc@chromium.org>
Date: Wed Apr 11 10:32:51 2018

Remove HttpStreamRequest interface.

Remove HttpStreamRequest interface, and rename
HttpStreamFactoryImpl::Request to HttpStreamRequest.

Bug:  829429 
Change-Id: Iaff3b5e5ee73d85185914b6713d68243acb98a54
Reviewed-on: https://chromium-review.googlesource.com/998541
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549848}
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/chrome/browser/safe_browsing/download_protection/check_client_download_request.cc
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/chrome/browser/safe_browsing/download_protection/ppapi_download_request.cc
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/headless/public/util/generic_url_request_job.cc
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/BUILD.gn
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/dns/dns_transaction.cc
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/http/bidirectional_stream.h
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/http/http_network_transaction.h
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/http/http_stream_factory.h
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/http/http_stream_factory_impl.cc
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/http/http_stream_factory_impl.h
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/http/http_stream_factory_impl_job.h
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/http/http_stream_factory_impl_job_controller.cc
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/http/http_stream_factory_impl_job_controller.h
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/http/http_stream_factory_impl_job_controller_unittest.cc
[delete] https://crrev.com/1bb6ae561585af7dc20bba7e7ec43a54245dde20/net/http/http_stream_factory_impl_request.h
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/http/http_stream_factory_test_util.h
[rename] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/http/http_stream_request.cc
[add] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/http/http_stream_request.h
[rename] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/http/http_stream_request_unittest.cc
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/spdy/chromium/spdy_session_pool.cc
[modify] https://crrev.com/6b44abf85be940e6acf5cf3e900a4d36f0d05e96/net/spdy/chromium/spdy_session_pool.h
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a55e432d5c0c01bdf471fa6db70bf6d5ea6ce894

commit a55e432d5c0c01bdf471fa6db70bf6d5ea6ce894
Author: Bence Béky <bnc@chromium.org>
Date: Wed Apr 11 15:17:53 2018

Do not call QuitCurrentWhenIdleDeprecated in http_stream_factory_impl_unittest.cc

Do not call deprecated QuitCurrentWhenIdleDeprecated() in
net/http/http_stream_factory_impl_unittest.cc.  The relation to
 https://crbug.com/829429  is that because of presubmit rules, this is
blocking the rename of net/http/http_stream_factory_impl_unittest.cc at
https://crrev.com/c/1000487.

Bug:  829429 
Change-Id: Id05bca35788d013794c177e606334bad3e37290f
Reviewed-on: https://chromium-review.googlesource.com/1005110
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549889}
[modify] https://crrev.com/a55e432d5c0c01bdf471fa6db70bf6d5ea6ce894/net/http/http_stream_factory_impl_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b71838bd71e97e880b5554086ccfd5b84f07fbcf

commit b71838bd71e97e880b5554086ccfd5b84f07fbcf
Author: Bence Béky <bnc@chromium.org>
Date: Thu Apr 19 18:23:38 2018

Do not use ScopedMockTimeMessageLoopTaskRunner in //net.

Remove all uses of deprecated ScopedMockTimeMessageLoopTaskRunner in
//net in favor of ScopedTaskEnvironment.  Also add
GetMockTimeTaskRunner() method to ScopedTaskEnvironment so that
HasPendingTask(), GetPendingTaskCount(), and NextPendingTaskDelay()
methods can be called just like before.

The relation to  https://crbug.com/829429  is that because of presubmit
rules, this is blocking the rename of
net/http/http_stream_factory_job_controller_unittest.cc at
https://crrev.com/c/1000487.

Bug:  829429 ,  791831 
Change-Id: I445dca6ef8d91e1088c14b0f52d2358950b7e50f
Reviewed-on: https://chromium-review.googlesource.com/1005109
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552088}
[modify] https://crrev.com/b71838bd71e97e880b5554086ccfd5b84f07fbcf/base/test/scoped_task_environment.cc
[modify] https://crrev.com/b71838bd71e97e880b5554086ccfd5b84f07fbcf/base/test/scoped_task_environment.h
[modify] https://crrev.com/b71838bd71e97e880b5554086ccfd5b84f07fbcf/net/http/http_server_properties_manager_unittest.cc
[modify] https://crrev.com/b71838bd71e97e880b5554086ccfd5b84f07fbcf/net/http/http_stream_factory_impl_job_controller_unittest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5

commit b2f81897274e4c7f9bc5d2c8c13d14201504d6c5
Author: Bence Béky <bnc@chromium.org>
Date: Fri Apr 20 14:43:59 2018

Remove HttpStreamFactory interface.

Remove HttpStreamFactory interface, also rename HttpStreamFactoryImpl to
HttpStreamFactory.

Bug:  829429 
Change-Id: Ib21ea44e687f48cd5e0648d74916a9b4ad01f0cb
Reviewed-on: https://chromium-review.googlesource.com/1000487
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552332}
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/BUILD.gn
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/bidirectional_stream_impl.h
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/http_basic_stream.cc
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/http_network_layer.cc
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/http_network_session.cc
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/http_server_properties.h
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/http_stream_factory.cc
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/http_stream_factory.h
[delete] https://crrev.com/0104f8b9ff36f8c255729a4271d077cae1500c43/net/http/http_stream_factory_impl.cc
[delete] https://crrev.com/0104f8b9ff36f8c255729a4271d077cae1500c43/net/http/http_stream_factory_impl.h
[rename] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/http_stream_factory_job.cc
[rename] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/http_stream_factory_job.h
[rename] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/http_stream_factory_job_controller.cc
[rename] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/http_stream_factory_job_controller.h
[rename] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/http_stream_factory_job_controller_unittest.cc
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/http_stream_factory_test_util.cc
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/http_stream_factory_test_util.h
[rename] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/http_stream_factory_unittest.cc
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/http/http_stream_request_unittest.cc
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/log/net_log_event_type_list.h
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/spdy/chromium/http2_push_promise_index.h
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/net/spdy/chromium/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/b2f81897274e4c7f9bc5d2c8c13d14201504d6c5/tools/metrics/histograms/enums.xml

Comment 7 by b...@chromium.org, Apr 20 2018

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6981a65e58c0978688cd41dcd48a9602b50c98a0

commit 6981a65e58c0978688cd41dcd48a9602b50c98a0
Author: Tommy Steimel <steimel@chromium.org>
Date: Fri Apr 20 18:19:57 2018

Revert "Remove HttpStreamFactory interface."

This reverts commit b2f81897274e4c7f9bc5d2c8c13d14201504d6c5.

Reason for revert: 

Looks to be breaking net_unittests on Mac 10.10

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/31466

Original change's description:
> Remove HttpStreamFactory interface.
> 
> Remove HttpStreamFactory interface, also rename HttpStreamFactoryImpl to
> HttpStreamFactory.
> 
> Bug:  829429 
> Change-Id: Ib21ea44e687f48cd5e0648d74916a9b4ad01f0cb
> Reviewed-on: https://chromium-review.googlesource.com/1000487
> Commit-Queue: Bence Béky <bnc@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552332}

TBR=rch@chromium.org,bnc@chromium.org

Change-Id: Idd29ef444606174ed50897f91176aa003c6d9687
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  829429 
Reviewed-on: https://chromium-review.googlesource.com/1022251
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552393}
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/BUILD.gn
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/bidirectional_stream_impl.h
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_basic_stream.cc
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_network_layer.cc
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_network_session.cc
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_server_properties.h
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_stream_factory.cc
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_stream_factory.h
[add] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_stream_factory_impl.cc
[add] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_stream_factory_impl.h
[rename] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_stream_factory_impl_job.cc
[rename] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_stream_factory_impl_job.h
[rename] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_stream_factory_impl_job_controller.cc
[rename] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_stream_factory_impl_job_controller.h
[rename] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_stream_factory_impl_job_controller_unittest.cc
[rename] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_stream_factory_test_util.cc
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_stream_factory_test_util.h
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/http/http_stream_request_unittest.cc
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/log/net_log_event_type_list.h
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/spdy/chromium/http2_push_promise_index.h
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/net/spdy/chromium/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/6981a65e58c0978688cd41dcd48a9602b50c98a0/tools/metrics/histograms/enums.xml

Comment 9 by b...@chromium.org, Apr 20 2018

Status: Started (was: Fixed)
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea3e3f22b07a492c2211a035af9081fe6ec170c9

commit ea3e3f22b07a492c2211a035af9081fe6ec170c9
Author: Bence Béky <bnc@chromium.org>
Date: Tue Apr 24 17:13:59 2018

Reland "Remove HttpStreamFactory interface."

Reland https://crrev.com/c/1000487.

Remove HttpStreamFactory interface, also rename HttpStreamFactoryImpl to
HttpStreamFactory.

Bug:  829429 
Change-Id: I298879817785174d1d7290520f889f0252074e14
Reviewed-on: https://chromium-review.googlesource.com/1023321
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553180}
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/BUILD.gn
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/bidirectional_stream_impl.h
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/http_basic_stream.cc
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/http_network_layer.cc
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/http_network_session.cc
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/http_server_properties.h
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/http_stream_factory.cc
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/http_stream_factory.h
[delete] https://crrev.com/4406d075cdda1f5230eefe84119742dee52e6bfd/net/http/http_stream_factory_impl.cc
[delete] https://crrev.com/4406d075cdda1f5230eefe84119742dee52e6bfd/net/http/http_stream_factory_impl.h
[rename] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/http_stream_factory_job.cc
[rename] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/http_stream_factory_job.h
[rename] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/http_stream_factory_job_controller.cc
[rename] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/http_stream_factory_job_controller.h
[rename] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/http_stream_factory_job_controller_unittest.cc
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/http_stream_factory_test_util.cc
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/http_stream_factory_test_util.h
[rename] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/http_stream_factory_unittest.cc
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/http/http_stream_request_unittest.cc
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/log/net_log_event_type_list.h
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/spdy/chromium/http2_push_promise_index.h
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/net/spdy/chromium/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/ea3e3f22b07a492c2211a035af9081fe6ec170c9/tools/metrics/histograms/enums.xml
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a

commit 7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a
Author: Bence Béky <bnc@chromium.org>
Date: Tue Apr 24 19:39:59 2018

Revert "Reland "Remove HttpStreamFactory interface.""

This reverts commit ea3e3f22b07a492c2211a035af9081fe6ec170c9.

Reason for revert: Failure at
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/31554

Original change's description:
> Reland "Remove HttpStreamFactory interface."
>
> Reland https://crrev.com/c/1000487.
>
> Remove HttpStreamFactory interface, also rename HttpStreamFactoryImpl
> to
> HttpStreamFactory.
>
> Bug:  829429 
> Change-Id: I298879817785174d1d7290520f889f0252074e14
> Reviewed-on: https://chromium-review.googlesource.com/1023321
> Commit-Queue: Bence Béky <bnc@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553180}

TBR=rch@chromium.org,bnc@chromium.org

Change-Id: I9fab232c4219d9e11d5df54f57c13dfd50540b2f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  829429 
Reviewed-on: https://chromium-review.googlesource.com/1026491
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553233}
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/BUILD.gn
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/bidirectional_stream_impl.h
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_basic_stream.cc
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_network_layer.cc
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_network_session.cc
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_server_properties.h
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_stream_factory.cc
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_stream_factory.h
[add] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_stream_factory_impl.cc
[add] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_stream_factory_impl.h
[rename] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_stream_factory_impl_job.cc
[rename] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_stream_factory_impl_job.h
[rename] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_stream_factory_impl_job_controller.cc
[rename] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_stream_factory_impl_job_controller.h
[rename] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_stream_factory_impl_job_controller_unittest.cc
[rename] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_stream_factory_test_util.cc
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_stream_factory_test_util.h
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/http/http_stream_request_unittest.cc
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/log/net_log_event_type_list.h
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/spdy/chromium/http2_push_promise_index.h
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/net/spdy/chromium/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a/tools/metrics/histograms/enums.xml
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aa787aa1ffda627f99d4339b9556c1f3099d3f6

commit 4aa787aa1ffda627f99d4339b9556c1f3099d3f6
Author: Xida Chen <xidachen@chromium.org>
Date: Tue Apr 24 19:49:33 2018

Reland "Reland "Remove HttpStreamFactory interface.""

This reverts commit 7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a.

Reason for revert: <INSERT REASONING HERE>
Causing compile error here:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20ARM64%20Cast%20Audio/10534

Original change's description:
> Revert "Reland "Remove HttpStreamFactory interface.""
> 
> This reverts commit ea3e3f22b07a492c2211a035af9081fe6ec170c9.
> 
> Reason for revert: Failure at
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/31554
> 
> Original change's description:
> > Reland "Remove HttpStreamFactory interface."
> >
> > Reland https://crrev.com/c/1000487.
> >
> > Remove HttpStreamFactory interface, also rename HttpStreamFactoryImpl
> > to
> > HttpStreamFactory.
> >
> > Bug:  829429 
> > Change-Id: I298879817785174d1d7290520f889f0252074e14
> > Reviewed-on: https://chromium-review.googlesource.com/1023321
> > Commit-Queue: Bence Béky <bnc@chromium.org>
> > Reviewed-by: Ryan Hamilton <rch@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553180}
> 
> TBR=rch@chromium.org,bnc@chromium.org
> 
> Change-Id: I9fab232c4219d9e11d5df54f57c13dfd50540b2f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  829429 
> Reviewed-on: https://chromium-review.googlesource.com/1026491
> Commit-Queue: Bence Béky <bnc@chromium.org>
> Reviewed-by: Bence Béky <bnc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553233}

TBR=rch@chromium.org,bnc@chromium.org

Change-Id: I55ada6185c0a923d0c87b5986c15d1fc5f06d461
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  829429 
Reviewed-on: https://chromium-review.googlesource.com/1026530
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553238}
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/BUILD.gn
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/bidirectional_stream_impl.h
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/http_basic_stream.cc
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/http_network_layer.cc
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/http_network_session.cc
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/http_server_properties.h
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/http_stream_factory.cc
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/http_stream_factory.h
[delete] https://crrev.com/334710bd0e04be40239c9ec83aa4d877484021e8/net/http/http_stream_factory_impl.cc
[delete] https://crrev.com/334710bd0e04be40239c9ec83aa4d877484021e8/net/http/http_stream_factory_impl.h
[rename] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/http_stream_factory_job.cc
[rename] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/http_stream_factory_job.h
[rename] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/http_stream_factory_job_controller.cc
[rename] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/http_stream_factory_job_controller.h
[rename] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/http_stream_factory_job_controller_unittest.cc
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/http_stream_factory_test_util.cc
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/http_stream_factory_test_util.h
[rename] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/http_stream_factory_unittest.cc
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/http/http_stream_request_unittest.cc
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/log/net_log_event_type_list.h
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/spdy/chromium/http2_push_promise_index.h
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/net/spdy/chromium/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/4aa787aa1ffda627f99d4339b9556c1f3099d3f6/tools/metrics/histograms/enums.xml
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05

commit f860bdc8323f4701ca0930bf94cd9bfbb8d09b05
Author: Xida Chen <xidachen@chromium.org>
Date: Tue Apr 24 19:50:21 2018

Revert "Reland "Reland "Remove HttpStreamFactory interface."""

This reverts commit 4aa787aa1ffda627f99d4339b9556c1f3099d3f6.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "Reland "Remove HttpStreamFactory interface.""
> 
> This reverts commit 7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a.
> 
> Reason for revert: <INSERT REASONING HERE>
> Causing compile error here:
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20ARM64%20Cast%20Audio/10534
> 
> Original change's description:
> > Revert "Reland "Remove HttpStreamFactory interface.""
> > 
> > This reverts commit ea3e3f22b07a492c2211a035af9081fe6ec170c9.
> > 
> > Reason for revert: Failure at
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/31554
> > 
> > Original change's description:
> > > Reland "Remove HttpStreamFactory interface."
> > >
> > > Reland https://crrev.com/c/1000487.
> > >
> > > Remove HttpStreamFactory interface, also rename HttpStreamFactoryImpl
> > > to
> > > HttpStreamFactory.
> > >
> > > Bug:  829429 
> > > Change-Id: I298879817785174d1d7290520f889f0252074e14
> > > Reviewed-on: https://chromium-review.googlesource.com/1023321
> > > Commit-Queue: Bence Béky <bnc@chromium.org>
> > > Reviewed-by: Ryan Hamilton <rch@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#553180}
> > 
> > TBR=rch@chromium.org,bnc@chromium.org
> > 
> > Change-Id: I9fab232c4219d9e11d5df54f57c13dfd50540b2f
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  829429 
> > Reviewed-on: https://chromium-review.googlesource.com/1026491
> > Commit-Queue: Bence Béky <bnc@chromium.org>
> > Reviewed-by: Bence Béky <bnc@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553233}
> 
> TBR=rch@chromium.org,bnc@chromium.org
> 
> Change-Id: I55ada6185c0a923d0c87b5986c15d1fc5f06d461
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  829429 
> Reviewed-on: https://chromium-review.googlesource.com/1026530
> Reviewed-by: Xida Chen <xidachen@chromium.org>
> Commit-Queue: Xida Chen <xidachen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553238}

TBR=rch@chromium.org,bnc@chromium.org,xidachen@chromium.org

Change-Id: Ic8ecc1e9d34d964d4b825863ef1b725f4e48ad90
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  829429 
Reviewed-on: https://chromium-review.googlesource.com/1026531
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553239}
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/BUILD.gn
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/bidirectional_stream_impl.h
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_basic_stream.cc
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_network_layer.cc
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_network_session.cc
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_server_properties.h
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_stream_factory.cc
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_stream_factory.h
[add] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_stream_factory_impl.cc
[add] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_stream_factory_impl.h
[rename] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_stream_factory_impl_job.cc
[rename] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_stream_factory_impl_job.h
[rename] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_stream_factory_impl_job_controller.cc
[rename] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_stream_factory_impl_job_controller.h
[rename] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_stream_factory_impl_job_controller_unittest.cc
[rename] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_stream_factory_test_util.cc
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_stream_factory_test_util.h
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_stream_request_unittest.cc
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/log/net_log_event_type_list.h
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/spdy/chromium/http2_push_promise_index.h
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/spdy/chromium/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/tools/metrics/histograms/enums.xml
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9

commit 9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9
Author: Xida Chen <xidachen@chromium.org>
Date: Tue Apr 24 19:52:21 2018

Reland "Reland "Remove HttpStreamFactory interface.""

This reverts commit 7f7c86d81c9f49bcd09a5428f0ea387d03c6d33a.

Reason for revert: <INSERT REASONING HERE>
Causing compile error:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20ARM64%20Cast%20Audio/10534

Original change's description:
> Revert "Reland "Remove HttpStreamFactory interface.""
> 
> This reverts commit ea3e3f22b07a492c2211a035af9081fe6ec170c9.
> 
> Reason for revert: Failure at
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/31554
> 
> Original change's description:
> > Reland "Remove HttpStreamFactory interface."
> >
> > Reland https://crrev.com/c/1000487.
> >
> > Remove HttpStreamFactory interface, also rename HttpStreamFactoryImpl
> > to
> > HttpStreamFactory.
> >
> > Bug:  829429 
> > Change-Id: I298879817785174d1d7290520f889f0252074e14
> > Reviewed-on: https://chromium-review.googlesource.com/1023321
> > Commit-Queue: Bence Béky <bnc@chromium.org>
> > Reviewed-by: Ryan Hamilton <rch@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553180}
> 
> TBR=rch@chromium.org,bnc@chromium.org
> 
> Change-Id: I9fab232c4219d9e11d5df54f57c13dfd50540b2f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  829429 
> Reviewed-on: https://chromium-review.googlesource.com/1026491
> Commit-Queue: Bence Béky <bnc@chromium.org>
> Reviewed-by: Bence Béky <bnc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553233}

TBR=rch@chromium.org,bnc@chromium.org

Change-Id: I1a33380942c2fc0d3aed903a4a505f0615e24f8c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  829429 
Reviewed-on: https://chromium-review.googlesource.com/1026492
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553240}
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/BUILD.gn
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/bidirectional_stream_impl.h
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/http_basic_stream.cc
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/http_network_layer.cc
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/http_network_session.cc
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/http_server_properties.h
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/http_stream_factory.cc
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/http_stream_factory.h
[delete] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_stream_factory_impl.cc
[delete] https://crrev.com/f860bdc8323f4701ca0930bf94cd9bfbb8d09b05/net/http/http_stream_factory_impl.h
[rename] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/http_stream_factory_job.cc
[rename] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/http_stream_factory_job.h
[rename] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/http_stream_factory_job_controller.cc
[rename] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/http_stream_factory_job_controller.h
[rename] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/http_stream_factory_job_controller_unittest.cc
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/http_stream_factory_test_util.cc
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/http_stream_factory_test_util.h
[rename] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/http_stream_factory_unittest.cc
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/http/http_stream_request_unittest.cc
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/log/net_log_event_type_list.h
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/spdy/chromium/http2_push_promise_index.h
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/net/spdy/chromium/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/9bfe0b6bb37d2218b56a0c7e9773ff9e70e053a9/tools/metrics/histograms/enums.xml
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2eb7d93ed08831863200e2bbc11ab52442139d86

commit 2eb7d93ed08831863200e2bbc11ab52442139d86
Author: Misha Efimov <mef@google.com>
Date: Thu Apr 26 00:01:20 2018

Fix broken BidirectionalStreamTest in Cronet on iOS.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Bug:  836823 ,  829429 
Change-Id: Id69a596b5d260ceec0794c6c6478ad01ce61a0da
Reviewed-on: https://chromium-review.googlesource.com/1028630
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553832}
[modify] https://crrev.com/2eb7d93ed08831863200e2bbc11ab52442139d86/net/http/http_stream_factory.h

Comment 17 by b...@chromium.org, Apr 27 2018

Status: Fixed (was: Started)

Comment 18 by davidben@chromium.org, Aug 23 

WHOAH! I came across this searching for the old class name and it was gone. The shorter naming is awesome!
►

Sign in to add a comment