New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829426 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

chrome://gpu incorrect for surface sync and viz when gpu+swiftshader is not available

Project Member Reported by moh...@chromium.org, Apr 5 2018

Issue description

When GPU hardware acceleration and swiftshader are both disabled, chrome://gpu page sometimes shows incorrect values for "Surface Synchronization" and "Viz Service Display Compositor" items. It seems to be showing the default value of "Disabled". This happens whether Viz display compositor is enabled or not.
 

Comment 1 by moh...@chromium.org, Apr 17 2018

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a26cfed32a00ed464f669d713780a535c057ba27

commit a26cfed32a00ed464f669d713780a535c057ba27
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Wed Apr 18 20:27:32 2018

Fix chrome://gpu feature status when gpu access is blocked

When GPU access is blocked (i.e., hardware acceleration and SwiftShader
are both disabled), chrome://gpu reports incorrect values for Surface
Synchronization and Viz Service Display Compositor features.

BUG= 829426 
TEST=manual

Change-Id: I977a3902d71d53d77be2473ecd4b755b895f6a79
Reviewed-on: https://chromium-review.googlesource.com/1017227
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551806}
[modify] https://crrev.com/a26cfed32a00ed464f669d713780a535c057ba27/content/browser/gpu/compositor_util.cc

Comment 3 by moh...@chromium.org, Apr 18 2018

Status: Fixed (was: Started)
Labels: Needs-Feedback
Tested this issue on build without fix 68.00.3398.0 and the build with Fix 68.0.3400 by following the below steps.

1. Launched Chrome with flags --disable-gpu and --disable-swiftshader.
2. Could observed the values of Surface Synchronization as 'Enabled' and Viz Service Display Compositor as Disabled in chrome://gpu.
3. Turned off the Hardware acceleration in chrome://settings and the values of Surface Synchronization is Enabled and Viz Service Display Compositor is Disabled.
4. By enabling and disabling the 'flag 'Viz Display Compositor (OOP-D)' in chrome://flags, can see the respective value for Viz Service Display Compositor and Surface Synchronization is Enabled.
Attached is the screen cast of the steps followed.

The same behaviour is observed on build with fix and without fix.

Request you to check and confirm if anything is missed in verifying the fix and help us in the same.

Thanks...
829426.webm
6.8 MB View Download
// addressing to mohsen@ in comment #4.

mohsen@ Request you to check and confirm if anything is missed in verifying the fix and help us in the same.

Thanks..

Comment 6 by moh...@chromium.org, Apr 19 2018

Thanks susan.boorgula@. For disabling SwiftShader you should use --disable-software-rasterizer flag (there is no --disable-swiftshader). Everything else you did is correct.

Sign in to add a comment