New issue
Advanced search Search tips

Issue 829411 link

Starred by 1 user
Status: Fixed
Owner:
torne@chromium.org
Closed: Apr 2018
Cc:
tobiasjs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Java findAddress should remain as strict as the older version?

Project Member Reported by torne@chromium.org, Apr 5 2018 
It looks like we've actually made findAddress's false positive rate worse with the change to match state-without-zip not at the end of a string: see b/75409267 for an example, and https://chromium-review.googlesource.com/c/chromium/src/+/778161 for the Java reimplementation.

We should change it back to be equivalently strict to the old version and add some test cases for this, and also change the version copied to Android. (not vital to cherrypick this to M66 as P will use the framework version).
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f446efcd3b2e51c1e1b8418d4f8cfe6d9b542d68

commit f446efcd3b2e51c1e1b8418d4f8cfe6d9b542d68
Author: Torne (Richard Coles) <torne@google.com>
Date: Fri Apr 06 18:44:06 2018

Only match addresses without zip codes if at the end.

The old native implementation of findAddress only accepted addresses
without zip codes if they appeared at the end of the string. This was
probably a bug as the documentation implies this should work in all
cases, but fixing this bug has caused a lot of false positives while not
fixing very many false negatives and this functionality is being
deprecated anyway, so change it back.

Bug:  829411 
Change-Id: Id280f524eaaade1851ae23e7ed17d0755ddb2ba9
Reviewed-on: https://chromium-review.googlesource.com/998754
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548873}
[modify] https://crrev.com/f446efcd3b2e51c1e1b8418d4f8cfe6d9b542d68/android_webview/java/src/org/chromium/android_webview/FindAddress.java
[modify] https://crrev.com/f446efcd3b2e51c1e1b8418d4f8cfe6d9b542d68/android_webview/javatests/src/org/chromium/android_webview/test/FindAddressTest.java

Comment 2 by torne@chromium.org, Apr 6 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment