Issue metadata
Sign in to add a comment
|
10.7%-14.1% regression in blink_perf.css at 547665:547687 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 5 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14d4a748c40000
,
Apr 6 2018
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/14d4a748c40000
,
Apr 6 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14f83764c40000
,
Apr 9 2018
📍 Found significant differences after each of 5 commits. https://pinpoint-dot-chromeperf.appspot.com/job/14f83764c40000 Cache code for inline scripts by leszeks@chromium.org https://chromium.googlesource.com/chromium/src/+/fc4e797b1522d0dd5163de7c291524e0519d160c Move ExecutionContext and SecurityContext to core/execution_context by kochi@chromium.org https://chromium.googlesource.com/chromium/src/+/ac85ca2a9cb8c76a37f9d7a6c611c24114f1f05d Roll src/third_party/skia/ c0528e241..fd88fe4d5 (1 commit) by skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com https://chromium.googlesource.com/chromium/src/+/7dbfeb630c33a014da36c2e4c8b3c397f102b078 Remove custom bindings for CSSStyleDeclaration. by raphael.kubo.da.costa@intel.com https://chromium.googlesource.com/chromium/src/+/5b84e88a070e40a1a74576a6cf41109d29a8035a Web Animations: give ComputedEffectTiming::endTime a lower bound of 0 by smcgruer@chromium.org https://chromium.googlesource.com/chromium/src/+/55aa8afeb7c99f5aabbe1e44fffcf70f9babd094 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Apr 9 2018
I'm pretty sure this is caused by my CL; there were similar reports when a we tried to get rid of custom bindings for CSSStyleDeclaration back in 2015.
,
Apr 9 2018
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a21878dbbdb4f3ebe979d63b690f5a499bbd02fd commit a21878dbbdb4f3ebe979d63b690f5a499bbd02fd Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Wed Apr 11 22:34:10 2018 CSSStyleDeclaration: Remove [RaisesException] from setter Previously, the custom bindings code for CSSStyleDeclaration only create an ExceptionState locally to pass to SetPropertyInternal(). Go back to this behavior and drop [RaisesException] from the setter due to performance issues: [RaisesException] causes an ExceptionState to be generated automatically in namedPropertySetter(), and an expensive CString needs to be created to set the ExceptionState's |property_name| argument. By creating an ExceptionState ourselves in AnonymousNamedSetter(), we can avoid creating a CString altogether and use a custom value for |property_name|. This brings some performance tests back to the values they used to report when we had custom bindings for CSSStyleDeclaration, namely: - blink_perf.css' CSSPropertySetterGetter and CSSPropertyUpdateValue - blink_perf.layout's SimpleTextPathLineLayout Bug: 764633, 829408 Change-Id: I99db6021d4483c5743daa452f9cb532eacda79a7 Reviewed-on: https://chromium-review.googlesource.com/1002881 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#549955} [modify] https://crrev.com/a21878dbbdb4f3ebe979d63b690f5a499bbd02fd/third_party/blink/renderer/core/css/css_style_declaration.cc [modify] https://crrev.com/a21878dbbdb4f3ebe979d63b690f5a499bbd02fd/third_party/blink/renderer/core/css/css_style_declaration.h [modify] https://crrev.com/a21878dbbdb4f3ebe979d63b690f5a499bbd02fd/third_party/blink/renderer/core/css/css_style_declaration.idl
,
Apr 12 2018
,
Apr 13 2018
Issue 832080 has been merged into this issue.
,
Apr 16 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Apr 5 2018