Crash when updating web notification with custom badge on Marshmallow Samsung devices |
|||||
Issue descriptionOn a Samsung Marshmallow device, e.g. an S5 on 6.0.1, this can be repro'd with the following steps: 1. Navigate to https://tests.peter.sh/notification-generator/ and grant notification permission 2. Set Badge property to 'Cat icon' 3. Set Tag property to 'tag-1' 4. Tap Display Notification *twice* It crashes on the second notification with the following fatal exception: 04-03 13:06:04.811 E/AndroidRuntime(25288): FATAL EXCEPTION: main 04-03 13:06:04.811 E/AndroidRuntime(25288): Process: com.android.chrome, PID: 25288 04-03 13:06:04.811 E/AndroidRuntime(25288): android.app.RemoteServiceException: Bad notification posted from package com.android.chrome: Couldn't update icon: StatusBarIcon(icon=Icon(typ=RESOURCE pkg=com.android.chrome id=0x00000000) visible user=0 ) 04-03 13:06:04.811 E/AndroidRuntime(25288): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2019) 04-03 13:06:04.811 E/AndroidRuntime(25288): at android.os.Handler.dispatchMessage(Handler.java:102) 04-03 13:06:04.811 E/AndroidRuntime(25288): at android.os.Looper.loop(Looper.java:158) 04-03 13:06:04.811 E/AndroidRuntime(25288): at android.app.ActivityThread.main(ActivityThread.java:7224) 04-03 13:06:04.811 E/AndroidRuntime(25288): at java.lang.reflect.Method.invoke(Native Method) 04-03 13:06:04.811 E/AndroidRuntime(25288): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230) 04-03 13:06:04.811 E/AndroidRuntime(25288): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120) Crash link: https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_Android%27%20AND%20%20expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BAndroid%20Java%20Exception%5D%20android.app.RemoteServiceException%20at%20android.app.ActivityThread%24H.handleMessage(ActivityThread.java)%27%20AND%20EXISTS%20(SELECT%201%20FROM%20UNNEST(thread)%20WHERE%20StackTrace.error_message%3D%27Bad%20notification%20posted%20from%20package%20com.android.chrome%3A%20Couldn%5C%27t%20update%20icon%3A%20StatusBarIcon(icon%3DIcon(typ%3DRESOURCE%20pkg%3Dcom.android.chrome%20id%3D0x00000000)%20visible%20user%3D0%20)%27)%20AND%20expanded_custom_data.ChromeCrashProto.channel%3D%27stable%27 This is one of 3 crashes conflated in the crash bug at Issue 820586
,
Apr 5 2018
,
Apr 5 2018
,
Apr 9 2018
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c05a8dfa3b5ba71f4110352c25ee52b08f1186be commit c05a8dfa3b5ba71f4110352c25ee52b08f1186be Author: Anita Woodruff <awdf@chromium.org> Date: Mon Apr 09 23:14:48 2018 [Android] Disable custom status bar notification icons on M Samsungs - Samsung M devices crash when a notification with the same tag is posted with a small icon set from an Icon, rather than a resource id. - This fix avoids the crash by always using the default icon from the resources on Samsung Marshmallow devices, regardless of whether a custom badge was provided. - This means that affected users will no longer see custom status bar icons for their web notifications - they will instead always see the Chrome logo - but at least it won't crash if the notification is updated. Bug: 829367 Change-Id: I80391b5c5e28d2c7b1f87c23c4994c080e02bda0 Reviewed-on: https://chromium-review.googlesource.com/998093 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#549318} [modify] https://crrev.com/c05a8dfa3b5ba71f4110352c25ee52b08f1186be/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java [modify] https://crrev.com/c05a8dfa3b5ba71f4110352c25ee52b08f1186be/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java
,
Apr 10 2018
Marking this one fixed in M67, have split out Issue 831220 for the remaining Coolpad crashes. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by awdf@chromium.org
, Apr 5 2018