New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829353 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Reporting: Add stats and status info to net-internals page

Project Member Reported by dcreager@google.com, Apr 5 2018

Issue description

In local builds I've just used LOG(INFO) lines to check whether the Reporting and NEL stacks are working as expected.  As this rolls out more widely, we need something more polished in net-internals for this.
 
Cc: juliatut...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f0b502e43c4503f824698cedb0eaa2b4c30dd1d

commit 1f0b502e43c4503f824698cedb0eaa2b4c30dd1d
Author: Douglas Creager <dcreager@google.com>
Date: Tue Apr 10 18:19:13 2018

Reporting: Keep track of per-client upload statistics

We now keep track of the number of attempted and successful uploads for
each client, as well as the total number of reports in those (attempted
and successful) uploads.  We'll use this to construct a nice table view
of the Reporting cache for the net-internals page.

Bug:  829353 
Change-Id: I3d7f34a9ca459666a9cbed3738ac1b578a4397a2
Reviewed-on: https://chromium-review.googlesource.com/995640
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Commit-Queue: Douglas Creager <dcreager@google.com>
Cr-Commit-Position: refs/heads/master@{#549593}
[modify] https://crrev.com/1f0b502e43c4503f824698cedb0eaa2b4c30dd1d/net/reporting/reporting_cache.cc
[modify] https://crrev.com/1f0b502e43c4503f824698cedb0eaa2b4c30dd1d/net/reporting/reporting_cache.h
[modify] https://crrev.com/1f0b502e43c4503f824698cedb0eaa2b4c30dd1d/net/reporting/reporting_delivery_agent.cc
[modify] https://crrev.com/1f0b502e43c4503f824698cedb0eaa2b4c30dd1d/net/reporting/reporting_delivery_agent_unittest.cc

Comment 3 by eroman@chromium.org, Apr 11 2018

Components: -Internals>Network Internals>Network>Logging
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b937ecc9f340f3ed4a4ffb45c88d1e93142fe6c

commit 0b937ecc9f340f3ed4a4ffb45c88d1e93142fe6c
Author: Douglas Creager <dcreager@google.com>
Date: Fri Apr 13 13:53:09 2018

Reporting: Return base::Value view of cache contents

This JSON copy of the data will let us show the current contents of the
Reporting cache in the net-internals page.

Bug:  829353 
Change-Id: I005f642e506d9c70e58c1b5799263931327c4a1f
Reviewed-on: https://chromium-review.googlesource.com/996883
Commit-Queue: Douglas Creager <dcreager@google.com>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550612}
[modify] https://crrev.com/0b937ecc9f340f3ed4a4ffb45c88d1e93142fe6c/net/reporting/reporting_cache.cc
[modify] https://crrev.com/0b937ecc9f340f3ed4a4ffb45c88d1e93142fe6c/net/reporting/reporting_cache.h
[modify] https://crrev.com/0b937ecc9f340f3ed4a4ffb45c88d1e93142fe6c/net/reporting/reporting_cache_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/853b209f2a0bdc2030055807c956395ac14b247b

commit 853b209f2a0bdc2030055807c956395ac14b247b
Author: Douglas Creager <dcreager@google.com>
Date: Fri Apr 13 23:03:27 2018

Reporting: Show reporting cache in net-internals

This patch adds a new tab to the net-internals page, which shows the
current contents of the Reporting cache.  This includes a section on any
queued reports, and a section showing any origins that we've received
Reporting headers from.

Bug:  829353 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I496d360fb1cf0f5e6c626e72415d8a624a25151b
Reviewed-on: https://chromium-review.googlesource.com/998752
Commit-Queue: Douglas Creager <dcreager@google.com>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550771}
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/browser/resources/net_internals/browser_bridge.js
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/browser/resources/net_internals/index.html
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/browser/resources/net_internals/index.js
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/browser/resources/net_internals/main.js
[add] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/browser/resources/net_internals/reporting_view.html
[add] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/browser/resources/net_internals/reporting_view.js
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/browser/resources/net_internals/util.js
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/test/data/webui/net_internals/log_util.js
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/test/data/webui/net_internals/main.js
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/test/data/webui/net_internals/net_internals_test.js
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/net/base/net_info_source_list.h
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/net/log/net_log_util.cc
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/net/reporting/reporting_service.cc
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/net/reporting/reporting_service.h

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b937ecc9f340f3ed4a4ffb45c88d1e93142fe6c

commit 0b937ecc9f340f3ed4a4ffb45c88d1e93142fe6c
Author: Douglas Creager <dcreager@google.com>
Date: Fri Apr 13 13:53:09 2018

Reporting: Return base::Value view of cache contents

This JSON copy of the data will let us show the current contents of the
Reporting cache in the net-internals page.

Bug:  829353 
Change-Id: I005f642e506d9c70e58c1b5799263931327c4a1f
Reviewed-on: https://chromium-review.googlesource.com/996883
Commit-Queue: Douglas Creager <dcreager@google.com>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550612}
[modify] https://crrev.com/0b937ecc9f340f3ed4a4ffb45c88d1e93142fe6c/net/reporting/reporting_cache.cc
[modify] https://crrev.com/0b937ecc9f340f3ed4a4ffb45c88d1e93142fe6c/net/reporting/reporting_cache.h
[modify] https://crrev.com/0b937ecc9f340f3ed4a4ffb45c88d1e93142fe6c/net/reporting/reporting_cache_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/853b209f2a0bdc2030055807c956395ac14b247b

commit 853b209f2a0bdc2030055807c956395ac14b247b
Author: Douglas Creager <dcreager@google.com>
Date: Fri Apr 13 23:03:27 2018

Reporting: Show reporting cache in net-internals

This patch adds a new tab to the net-internals page, which shows the
current contents of the Reporting cache.  This includes a section on any
queued reports, and a section showing any origins that we've received
Reporting headers from.

Bug:  829353 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I496d360fb1cf0f5e6c626e72415d8a624a25151b
Reviewed-on: https://chromium-review.googlesource.com/998752
Commit-Queue: Douglas Creager <dcreager@google.com>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550771}
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/browser/resources/net_internals/browser_bridge.js
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/browser/resources/net_internals/index.html
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/browser/resources/net_internals/index.js
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/browser/resources/net_internals/main.js
[add] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/browser/resources/net_internals/reporting_view.html
[add] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/browser/resources/net_internals/reporting_view.js
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/browser/resources/net_internals/util.js
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/test/data/webui/net_internals/log_util.js
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/test/data/webui/net_internals/main.js
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/chrome/test/data/webui/net_internals/net_internals_test.js
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/net/base/net_info_source_list.h
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/net/log/net_log_util.cc
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/net/reporting/reporting_service.cc
[modify] https://crrev.com/853b209f2a0bdc2030055807c956395ac14b247b/net/reporting/reporting_service.h

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2680a42363371afb2572b3c253f5d3206d574bc0

commit 2680a42363371afb2572b3c253f5d3206d574bc0
Author: Douglas Creager <dcreager@google.com>
Date: Wed Apr 18 15:08:49 2018

Reporting: Gracefully handle missing data in reportingInfo

We can't make any assumptions about the contents of |reportingInfo|
in our net-internals page.  For one, the JSON content might be fully
arbitrary if the user decides to edit a net-log file.  And even if
the content actually comes from the //net stack, if the Reporting
stack is disabled at compile time, the |reportingInfo| delivered to
the net-internals page will not contain |reports| or |clients|
elements.

NOTRY=true

Bug:  829353 ,833628
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I69f4ab43416924b71569bfe80a121521eada716e
Reviewed-on: https://chromium-review.googlesource.com/1015549
Commit-Queue: Douglas Creager <dcreager@google.com>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551678}
[modify] https://crrev.com/2680a42363371afb2572b3c253f5d3206d574bc0/chrome/browser/resources/net_internals/reporting_view.js

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/500862072348ce54928cd74456a85e7f7e9ff375

commit 500862072348ce54928cd74456a85e7f7e9ff375
Author: Douglas Creager <dcreager@google.com>
Date: Thu Apr 19 14:25:09 2018

Network Error Logging: Include policy snapshot in net-internals

This net-internals Reporting tab already shows information about origins
that have configured Reporting endpoints, and about any queued reports.
This patch adds another section that shows information about any NEL
policies that the origins have provided, as well.

Bug:  829353 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I23b61663907d7f3515cd5124054b963b8001068f
Reviewed-on: https://chromium-review.googlesource.com/1015513
Commit-Queue: Douglas Creager <dcreager@google.com>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552007}
[modify] https://crrev.com/500862072348ce54928cd74456a85e7f7e9ff375/chrome/browser/resources/net_internals/reporting_view.html
[modify] https://crrev.com/500862072348ce54928cd74456a85e7f7e9ff375/chrome/browser/resources/net_internals/reporting_view.js
[modify] https://crrev.com/500862072348ce54928cd74456a85e7f7e9ff375/net/log/net_log_util.cc
[modify] https://crrev.com/500862072348ce54928cd74456a85e7f7e9ff375/net/network_error_logging/network_error_logging_service.cc
[modify] https://crrev.com/500862072348ce54928cd74456a85e7f7e9ff375/net/network_error_logging/network_error_logging_service.h
[modify] https://crrev.com/500862072348ce54928cd74456a85e7f7e9ff375/net/network_error_logging/network_error_logging_service_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/210545ead75e144ff69728f0affeffb83a7ade5f

commit 210545ead75e144ff69728f0affeffb83a7ade5f
Author: Douglas Creager <dcreager@google.com>
Date: Thu May 03 16:10:25 2018

Reporting: Include include-subdomains in net log

We weren't including the `include-subdomains` field of each endpoint
group in the data we were handing over to the net-internals page.  (The
net-internals code that reads this field is already there; we just
weren't filling in a value.)

Bug:  829353 
Change-Id: Ifdff1d6e0baf802eb7f094571060b93c761936af
Reviewed-on: https://chromium-review.googlesource.com/1019661
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Commit-Queue: Douglas Creager <dcreager@google.com>
Cr-Commit-Position: refs/heads/master@{#555755}
[modify] https://crrev.com/210545ead75e144ff69728f0affeffb83a7ade5f/net/reporting/reporting_cache.cc
[modify] https://crrev.com/210545ead75e144ff69728f0affeffb83a7ade5f/net/reporting/reporting_cache_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49c90a4a4de3b411ad60595d4354db546908fd75

commit 49c90a4a4de3b411ad60595d4354db546908fd75
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Thu May 03 20:47:50 2018

Revert "Reporting: Include include-subdomains in net log"

This reverts commit 210545ead75e144ff69728f0affeffb83a7ade5f.

Reason for revert: Causes ModuleEventSinkImplTest.CallsForwardedAsExpected to fail. 

Original change's description:
> Reporting: Include include-subdomains in net log
> 
> We weren't including the `include-subdomains` field of each endpoint
> group in the data we were handing over to the net-internals page.  (The
> net-internals code that reads this field is already there; we just
> weren't filling in a value.)
> 
> Bug:  829353 
> Change-Id: Ifdff1d6e0baf802eb7f094571060b93c761936af
> Reviewed-on: https://chromium-review.googlesource.com/1019661
> Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
> Commit-Queue: Douglas Creager <dcreager@google.com>
> Cr-Commit-Position: refs/heads/master@{#555755}

TBR=juliatuttle@chromium.org,dcreager@google.com

Change-Id: I720f83c34a1df94a9f3193c6dc453ab80bb98c8c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  829353 
Reviewed-on: https://chromium-review.googlesource.com/1042623
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555862}
[modify] https://crrev.com/49c90a4a4de3b411ad60595d4354db546908fd75/net/reporting/reporting_cache.cc
[modify] https://crrev.com/49c90a4a4de3b411ad60595d4354db546908fd75/net/reporting/reporting_cache_unittest.cc

Owner: dcreager@chromium.org
Project Member

Comment 13 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5734b5b9a051731c269654722774cccee03387cc

commit 5734b5b9a051731c269654722774cccee03387cc
Author: Douglas Creager <dcreager@chromium.org>
Date: Thu May 10 14:37:51 2018

Reporting: Include include-subdomains in net log

We weren't including the `include-subdomains` field of each endpoint
group in the data we were handing over to the net-internals page.  (The
net-internals code that reads this field is already there; we just
weren't filling in a value.)

Bug:  829353 
Change-Id: Ic1f81241c40de063e68c56ee2f2e10ba0b8da7a6
Reviewed-on: https://chromium-review.googlesource.com/1052851
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Commit-Queue: Douglas Creager <dcreager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557512}
[modify] https://crrev.com/5734b5b9a051731c269654722774cccee03387cc/net/reporting/reporting_cache.cc
[modify] https://crrev.com/5734b5b9a051731c269654722774cccee03387cc/net/reporting/reporting_cache_unittest.cc

Status: Verified (was: Started)

Sign in to add a comment