New issue
Advanced search Search tips

Issue 829348 link

Starred by 1 user
Status: WontFix
Owner:
alexilin@chromium.org
Closed: Jun 2018
Cc:
csharrison@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

PredictorBrowserTest.DontPredictBasedOnSubresources Flaky

Project Member Reported by jonr...@chromium.org, Apr 5 2018 
OS: Windows
Test Suite: viz_browser_tests
           (browser_tests -enable-features=VizDisplayCompositor)
Test Case: PredictorBrowserTest.DontPredictBasedOnSubresources

Example failing build: https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/138166

The test is currently timing out. An error message:

[1392:864:0405/012919.087:INFO:CONSOLE(0)] "Failed to load http://redirector.com/predictor/empty.js: Redirect from 'http://redirector.com/predictor/empty.js' to 'http://127.0.0.1:55390/predictor/empty.js' has been blocked by CORS policy: Invalid response. Origin 'http://127.0.0.1:55389' is therefore not allowed access.", source: http://127.0.0.1:55389/predictor/predictor_cross_site.html?subresourceHost=http://redirector.com/&numCORSResources=1 (0)

[1392:864:0405/012919.088:INFO:CONSOLE(0)] "Uncaught (in promise) TypeError: Failed to fetch", source: http://127.0.0.1:55389/predictor/predictor_cross_site.html?subresourceHost=http://redirector.com/&numCORSResources=1 (0)

Hey csharrison@, since you added this test could you help triage?

Marking this as P1 as the flakes have been affecting a significant number of jobs on the CQ

Comment 1 by csharrison@chromium.org, Apr 9 2018

Cc: csharrison@chromium.org
Owner: alexilin@chromium.org
Alex, would you take a look?
BTW: Do you have browsertests for the new predictor? These browser tests are very complex and don't all support the network service, so if you have modern replacements we could try to swap these tests with your fixture.

Comment 2 by alexilin@chromium.org, Jun 1 2018

Status: WontFix (was: Untriaged)
Looking at the flakiness dashboard, this test no longer causes failures. 
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=DontPredictBasedOnSubresources

Re c#1: No, the new predictor doesn't have browsertests, but I agree it should. Let's use issue 602396 for tracking this work.
►

Sign in to add a comment