New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829346 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

LoadMediaActionTest.testAwaitedEventIsConfigurable failing on Mac-10.10, Mac-10.11, Mac-10.12, Mac-10.13

Project Member Reported by mastiz@chromium.org, Apr 5 2018

Issue description

One test is failing consistently.

First known bad:
https://ci.chromium.org/buildbot/chromium.mac/Mac10.10%20Tests/30901

Unexpected Failures:
telemetry.internal.actions.load_media_unittest.LoadMediaActionTest.testAwaitedEventIsConfigurable

Error log snippet:
*************** BROWSER STANDARD OUTPUT ***************
  DevTools listening on ws://127.0.0.1:50736/devtools/browser/1b964969-9d69-4f5d-a658-4a6b523d8cb7
  [18:40:58.760] vtDecompressionDuctCreate signalled err=-8973 (err) (Could not select and open decoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTDecompressionSession.c line 1181
  <<<< VTVideoEncoderSelection >>>> VTSelectAndCreateVideoEncoderInstanceInternal: no video encoder found for 'avc1'
  
  [18:40:58.849] VTSelectAndCreateVideoEncoderInstanceInternal signalled err=-12908 (err) (Video encoder not available) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTVideoEncoderSelection.c line 1245
  [18:40:58.849] VTCompressionSessionCreate signalled err=-12908 (err) (Could not select and open encoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTCompressionSession.c line 946
*********** END OF BROWSER STANDARD OUTPUT ************

Suspect range:
f759152ba032bff4a77b6664182e91cea873871b..6bdfed7585104a47ff5aefe81bbc49d4ef5bb8b4


It's a long shot, but mlamouri@, is it possible that https://chromium-review.googlesource.com/986053 has caused this problem?

Another suspect is https://chromium-review.googlesource.com/974106, CC-ing spqchan@ as well.
 
Cc: smcgruer@chromium.org
Components: Speed>Telemetry Tests>Telemetry
Labels: -Pri-2 Pri-1
Summary: LoadMediaActionTest.testAwaitedEventIsConfigurable failing on Mac-10.10, Mac-10.11, Mac-10.12, Mac-10.13 (was: telemetry_unittests failing on Mac-10.10 )
This is currently failing across all Mac bots. I am unable to reproduce locally on a Mac 10.13 device (the test passes fine, when run alone or with the whole LoadMediaActionTest suite).

I have speculative reverts for the two CLs mentioned in #1, but I'm unsure if they will show anything useful (in particular I'm not sure if tryjobs for a revert of https://chromium-review.googlesource.com/986053 would actually utilize the change?)

Guessing at a component too, since I don't know which this is.
Forgot to list my speculative fix commits earlier:

https://chromium-review.googlesource.com/c/chromium/src/+/997771 - was never able to get a mac tryjob to work for this, so no data
https://chromium-review.googlesource.com/c/chromium/src/+/997770 - I did successfully run mac_chromium_10.10 and mac_chromium_10.12_rel_ng on this one twice, which passed the telemtry_unittests, so maybe we should try reverting it?



Finally, I also prepared a disable for the test; https://chromium-review.googlesource.com/c/catapult/+/997765

Comment 4 by shend@chromium.org, Apr 6 2018

Hmm https://chromium-review.googlesource.com/c/chromium/src/+/997770 doesn't seem directly related to the test failure IMO, but I guess if the try bots pass it might be worth reverting it?

If the revert doesn't work, we can disable the test. WDYT?
I agree it looks totally unrelated, but I think it's all we have to go on here? Given the time-zone difference we should hopefully be able to re-revert before MTV work time on Friday and so not interrupt spqchan@'s day too much.

It may also be worth putting up a completely unrelated change (just a do-nothing, change a text file or something) and see if it passes a manual tryjob of mac_chromium_10.10 and mac_chromium_10.12_rel_ng? If it does, then my speculative CLs are useless :D

If you do decide to go ahead with the revert, please use the propert revert button from the original CL (https://chromium-review.googlesource.com/c/chromium/src/+/974106); it fills in a bunch of tracking info.
Cc: shend@chromium.org

Comment 7 by shend@chromium.org, Apr 6 2018

Tried running an empty change here: https://chromium-review.googlesource.com/c/chromium/src/+/999214 but the bots are purple :/

Also, spqchan@ is currently in APAC timezone where it's Friday morning.
I doubt the CL is related to this. The Views autofill popup should be disabled by default and it doesn't have anything to do with Media
Note: if you don't have anything else, feel free to revert it and let's see what happens
Yes, I was also seeing bots suffering due to full drive; do we know if there's a trooper on that issue?

Without a positive signal from an empty CL, I would not suggest reverting spqchan@'s CL. To me it isn't worth the churn on their part; we should just disable the test and find an appropriate owner to dig into it.
Yeah empty CL seems to pass this test: https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_chromium_10.10/393

Note the failure is coming from another issue ( crbug.com/829161 ).

I'm just going to disable the test then. Thanks!
Ah, looks like I don't have the correct permissions to disable the test because it's in catapult.

I've also filed a bug about the bots at crbug.com/829678.
Cc: crouleau@chromium.org
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/aaeb23e97cd16d8795cf73dd5d9ed8cd2cd1e00f

commit aaeb23e97cd16d8795cf73dd5d9ed8cd2cd1e00f
Author: Darren Shen <shend@chromium.org>
Date: Fri Apr 06 04:29:59 2018

Disable testAwaitedEventIsConfigurable on Mac due to consistent failure

This test has been failing consistently and is blocking the Mac bots:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=telemetry_unittests&tests=telemetry.internal.actions.load_media_unittest.LoadMediaActionTest.testAwaitedEventIsConfigurable

TBR=nednguyen@chromium.org

Bug: chromium:829346
Change-Id: I85a57a653827476c269683414e9d0d7f55a2afa8
Reviewed-on: https://chromium-review.googlesource.com/999235
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/aaeb23e97cd16d8795cf73dd5d9ed8cd2cd1e00f/telemetry/telemetry/internal/actions/load_media_unittest.py

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a34d11a6c0401523de2199582a6461f4df06af8c

commit a34d11a6c0401523de2199582a6461f4df06af8c
Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Apr 06 05:45:06 2018

Roll src/third_party/catapult/ 7b821dff5..aaeb23e97 (1 commit)

https://chromium.googlesource.com/catapult.git/+log/7b821dff5984..aaeb23e97cd1

$ git log 7b821dff5..aaeb23e97 --date=short --no-merges --format='%ad %ae %s'
2018-04-06 shend Disable testAwaitedEventIsConfigurable on Mac due to consistent failure

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:829346


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Icd104ba687f402acf89f74e17ff83db43c0a1e4c
Reviewed-on: https://chromium-review.googlesource.com/999180
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548688}
[modify] https://crrev.com/a34d11a6c0401523de2199582a6461f4df06af8c/DEPS

Cc: mlamouri@chromium.org
Owner: ----
Status: Available (was: Assigned)
Labels: -Sheriff-Chromium
The test has been disabled, so I'm removing the sheriff label.

Comment 18 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 19 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Tests>Telemetry

Comment 20 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment