When the in product help is triggered for the "click here to open a new incognito tab", the first time the user is opening the tools menu, the "New Incognito Tab" entry should be pulsing.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20a94e7f7494f90da6be4593ef85ae482c58e89f commit 20a94e7f7494f90da6be4593ef85ae482c58e89f Author: Gauthier Ambard <gambard@chromium.org> Date: Thu May 17 10:34:44 2018 Add blink effect to the PopupMenu This CL adds an effect to make the "New Incognito Tab" row of the tools menu blink a selected state when the in product help requires it. Bug: 829344 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib2345a98f8ec284369b342d111cadf7f6a55adef Reviewed-on: https://chromium-review.googlesource.com/1057708 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559481} [modify] https://crrev.com/20a94e7f7494f90da6be4593ef85ae482c58e89f/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/20a94e7f7494f90da6be4593ef85ae482c58e89f/ios/chrome/browser/ui/popup_menu/BUILD.gn [modify] https://crrev.com/20a94e7f7494f90da6be4593ef85ae482c58e89f/ios/chrome/browser/ui/popup_menu/popup_menu_constants.h [modify] https://crrev.com/20a94e7f7494f90da6be4593ef85ae482c58e89f/ios/chrome/browser/ui/popup_menu/popup_menu_constants.mm [modify] https://crrev.com/20a94e7f7494f90da6be4593ef85ae482c58e89f/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.h [modify] https://crrev.com/20a94e7f7494f90da6be4593ef85ae482c58e89f/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm [modify] https://crrev.com/20a94e7f7494f90da6be4593ef85ae482c58e89f/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h [modify] https://crrev.com/20a94e7f7494f90da6be4593ef85ae482c58e89f/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm [modify] https://crrev.com/20a94e7f7494f90da6be4593ef85ae482c58e89f/ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm [modify] https://crrev.com/20a94e7f7494f90da6be4593ef85ae482c58e89f/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.h [modify] https://crrev.com/20a94e7f7494f90da6be4593ef85ae482c58e89f/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33c637fd83f41e7050e7fb33f92f745aae02e7fa commit 33c637fd83f41e7050e7fb33f92f745aae02e7fa Author: Eugene But <eugenebut@chromium.org> Date: Fri May 18 23:51:33 2018 Revert "Add blink effect to the PopupMenu" This reverts commit 20a94e7f7494f90da6be4593ef85ae482c58e89f. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=844753 Bug: 844753 Original change's description: > Add blink effect to the PopupMenu > > This CL adds an effect to make the "New Incognito Tab" row of the tools > menu blink a selected state when the in product help requires it. > > Bug: 829344 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Ib2345a98f8ec284369b342d111cadf7f6a55adef > Reviewed-on: https://chromium-review.googlesource.com/1057708 > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559481} TBR=edchin@chromium.org,gambard@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 829344 Change-Id: I7135501ca78396a46d23ec53a538352d77e5c29d Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1066334 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#560106} [modify] https://crrev.com/33c637fd83f41e7050e7fb33f92f745aae02e7fa/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/33c637fd83f41e7050e7fb33f92f745aae02e7fa/ios/chrome/browser/ui/popup_menu/BUILD.gn [modify] https://crrev.com/33c637fd83f41e7050e7fb33f92f745aae02e7fa/ios/chrome/browser/ui/popup_menu/popup_menu_constants.h [modify] https://crrev.com/33c637fd83f41e7050e7fb33f92f745aae02e7fa/ios/chrome/browser/ui/popup_menu/popup_menu_constants.mm [modify] https://crrev.com/33c637fd83f41e7050e7fb33f92f745aae02e7fa/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.h [modify] https://crrev.com/33c637fd83f41e7050e7fb33f92f745aae02e7fa/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm [modify] https://crrev.com/33c637fd83f41e7050e7fb33f92f745aae02e7fa/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h [modify] https://crrev.com/33c637fd83f41e7050e7fb33f92f745aae02e7fa/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm [modify] https://crrev.com/33c637fd83f41e7050e7fb33f92f745aae02e7fa/ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm [modify] https://crrev.com/33c637fd83f41e7050e7fb33f92f745aae02e7fa/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.h [modify] https://crrev.com/33c637fd83f41e7050e7fb33f92f745aae02e7fa/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4753267be8640779700dc46c4289cc1cc7e4eda5 commit 4753267be8640779700dc46c4289cc1cc7e4eda5 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue May 22 16:14:22 2018 Reland "Add blink effect to the PopupMenu" This reverts commit 33c637fd83f41e7050e7fb33f92f745aae02e7fa. Original change's description: > Revert "Add blink effect to the PopupMenu" > > This reverts commit 20a94e7f7494f90da6be4593ef85ae482c58e89f. > > Reason for revert: > https://bugs.chromium.org/p/chromium/issues/detail?id=844753 > > Bug: 844753 > > Original change's description: > > Add blink effect to the PopupMenu > > > > This CL adds an effect to make the "New Incognito Tab" row of the tools > > menu blink a selected state when the in product help requires it. > > > > Bug: 829344 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > > Change-Id: Ib2345a98f8ec284369b342d111cadf7f6a55adef > > Reviewed-on: https://chromium-review.googlesource.com/1057708 > > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > > Reviewed-by: edchin <edchin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#559481} > > TBR=edchin@chromium.org,gambard@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 829344 > Change-Id: I7135501ca78396a46d23ec53a538352d77e5c29d > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Reviewed-on: https://chromium-review.googlesource.com/1066334 > Commit-Queue: Eugene But <eugenebut@chromium.org> > Reviewed-by: edchin <edchin@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560106} Bug: 844753, 829344 Change-Id: Ibaf0e5cb3938a58021105d14b8d9d60e08372e06 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1068727 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#560632} [modify] https://crrev.com/4753267be8640779700dc46c4289cc1cc7e4eda5/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/4753267be8640779700dc46c4289cc1cc7e4eda5/ios/chrome/browser/ui/popup_menu/BUILD.gn [modify] https://crrev.com/4753267be8640779700dc46c4289cc1cc7e4eda5/ios/chrome/browser/ui/popup_menu/popup_menu_constants.h [modify] https://crrev.com/4753267be8640779700dc46c4289cc1cc7e4eda5/ios/chrome/browser/ui/popup_menu/popup_menu_constants.mm [modify] https://crrev.com/4753267be8640779700dc46c4289cc1cc7e4eda5/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.h [modify] https://crrev.com/4753267be8640779700dc46c4289cc1cc7e4eda5/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm [modify] https://crrev.com/4753267be8640779700dc46c4289cc1cc7e4eda5/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h [modify] https://crrev.com/4753267be8640779700dc46c4289cc1cc7e4eda5/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm [modify] https://crrev.com/4753267be8640779700dc46c4289cc1cc7e4eda5/ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm [modify] https://crrev.com/4753267be8640779700dc46c4289cc1cc7e4eda5/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.h [modify] https://crrev.com/4753267be8640779700dc46c4289cc1cc7e4eda5/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef774cc468ac82cba04d7f4d6b322b1891101c90 commit ef774cc468ac82cba04d7f4d6b322b1891101c90 Author: Justin Cohen <justincohen@chromium.org> Date: Tue May 22 18:09:16 2018 Revert "Reland "Add blink effect to the PopupMenu"" This reverts commit 4753267be8640779700dc46c4289cc1cc7e4eda5. Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator/33343 started to fail at PopupMenuMediatorTest.TestElementsTabGrid* Original change's description: > Reland "Add blink effect to the PopupMenu" > > This reverts commit 33c637fd83f41e7050e7fb33f92f745aae02e7fa. > > Original change's description: > > Revert "Add blink effect to the PopupMenu" > > > > This reverts commit 20a94e7f7494f90da6be4593ef85ae482c58e89f. > > > > Reason for revert: > > https://bugs.chromium.org/p/chromium/issues/detail?id=844753 > > > > Bug: 844753 > > > > Original change's description: > > > Add blink effect to the PopupMenu > > > > > > This CL adds an effect to make the "New Incognito Tab" row of the tools > > > menu blink a selected state when the in product help requires it. > > > > > > Bug: 829344 > > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > > > Change-Id: Ib2345a98f8ec284369b342d111cadf7f6a55adef > > > Reviewed-on: https://chromium-review.googlesource.com/1057708 > > > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > > > Reviewed-by: edchin <edchin@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#559481} > > > > TBR=edchin@chromium.org,gambard@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 829344 > > Change-Id: I7135501ca78396a46d23ec53a538352d77e5c29d > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > > Reviewed-on: https://chromium-review.googlesource.com/1066334 > > Commit-Queue: Eugene But <eugenebut@chromium.org> > > Reviewed-by: edchin <edchin@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#560106} > > Bug: 844753, 829344 > Change-Id: Ibaf0e5cb3938a58021105d14b8d9d60e08372e06 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Reviewed-on: https://chromium-review.googlesource.com/1068727 > Reviewed-by: edchin <edchin@chromium.org> > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560632} TBR=edchin@chromium.org,gambard@chromium.org Change-Id: If2d2bea1069e682ec4e747d6790f68a9e289d7cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844753, 829344 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1067644 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#560706} [modify] https://crrev.com/ef774cc468ac82cba04d7f4d6b322b1891101c90/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/ef774cc468ac82cba04d7f4d6b322b1891101c90/ios/chrome/browser/ui/popup_menu/BUILD.gn [modify] https://crrev.com/ef774cc468ac82cba04d7f4d6b322b1891101c90/ios/chrome/browser/ui/popup_menu/popup_menu_constants.h [modify] https://crrev.com/ef774cc468ac82cba04d7f4d6b322b1891101c90/ios/chrome/browser/ui/popup_menu/popup_menu_constants.mm [modify] https://crrev.com/ef774cc468ac82cba04d7f4d6b322b1891101c90/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.h [modify] https://crrev.com/ef774cc468ac82cba04d7f4d6b322b1891101c90/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm [modify] https://crrev.com/ef774cc468ac82cba04d7f4d6b322b1891101c90/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h [modify] https://crrev.com/ef774cc468ac82cba04d7f4d6b322b1891101c90/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm [modify] https://crrev.com/ef774cc468ac82cba04d7f4d6b322b1891101c90/ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm [modify] https://crrev.com/ef774cc468ac82cba04d7f4d6b322b1891101c90/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.h [modify] https://crrev.com/ef774cc468ac82cba04d7f4d6b322b1891101c90/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1d5c4b51456e1515b1d23bce81ad402de4338cc commit f1d5c4b51456e1515b1d23bce81ad402de4338cc Author: Gauthier Ambard <gambard@chromium.org> Date: Wed May 23 08:42:19 2018 Re-reland "Add blink effect to the PopupMenu" This CL adds an effect to make the "New Incognito Tab" row of the tools menu blink a selected state when the in product help requires it. TBR=edchin@chromium.org Bug: 829344 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic2e6fe63f5e2233f70ffaa0747c332778370132c Reviewed-on: https://chromium-review.googlesource.com/1068044 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#561006} [modify] https://crrev.com/f1d5c4b51456e1515b1d23bce81ad402de4338cc/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/f1d5c4b51456e1515b1d23bce81ad402de4338cc/ios/chrome/browser/ui/popup_menu/BUILD.gn [modify] https://crrev.com/f1d5c4b51456e1515b1d23bce81ad402de4338cc/ios/chrome/browser/ui/popup_menu/popup_menu_constants.h [modify] https://crrev.com/f1d5c4b51456e1515b1d23bce81ad402de4338cc/ios/chrome/browser/ui/popup_menu/popup_menu_constants.mm [modify] https://crrev.com/f1d5c4b51456e1515b1d23bce81ad402de4338cc/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.h [modify] https://crrev.com/f1d5c4b51456e1515b1d23bce81ad402de4338cc/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm [modify] https://crrev.com/f1d5c4b51456e1515b1d23bce81ad402de4338cc/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h [modify] https://crrev.com/f1d5c4b51456e1515b1d23bce81ad402de4338cc/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm [modify] https://crrev.com/f1d5c4b51456e1515b1d23bce81ad402de4338cc/ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm [modify] https://crrev.com/f1d5c4b51456e1515b1d23bce81ad402de4338cc/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.h [modify] https://crrev.com/f1d5c4b51456e1515b1d23bce81ad402de4338cc/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd9d6fa34e49353c59a5e335d44b9b3ebb5680dc commit dd9d6fa34e49353c59a5e335d44b9b3ebb5680dc Author: Gauthier Ambard <gambard@chromium.org> Date: Wed May 23 09:37:53 2018 Revert "Re-reland "Add blink effect to the PopupMenu"" This reverts commit f1d5c4b51456e1515b1d23bce81ad402de4338cc. Reason for revert: Still breaking the unittest, not sure to know why it passed the CQ... Original change's description: > Re-reland "Add blink effect to the PopupMenu" > > This CL adds an effect to make the "New Incognito Tab" row of the tools > menu blink a selected state when the in product help requires it. > > TBR=edchin@chromium.org > > Bug: 829344 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: Ic2e6fe63f5e2233f70ffaa0747c332778370132c > Reviewed-on: https://chromium-review.googlesource.com/1068044 > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561006} TBR=edchin@chromium.org,gambard@chromium.org Change-Id: Ie70a8341a896ad0270e1f5249cf0154eb0ba607f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829344 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1070030 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#561017} [modify] https://crrev.com/dd9d6fa34e49353c59a5e335d44b9b3ebb5680dc/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/dd9d6fa34e49353c59a5e335d44b9b3ebb5680dc/ios/chrome/browser/ui/popup_menu/BUILD.gn [modify] https://crrev.com/dd9d6fa34e49353c59a5e335d44b9b3ebb5680dc/ios/chrome/browser/ui/popup_menu/popup_menu_constants.h [modify] https://crrev.com/dd9d6fa34e49353c59a5e335d44b9b3ebb5680dc/ios/chrome/browser/ui/popup_menu/popup_menu_constants.mm [modify] https://crrev.com/dd9d6fa34e49353c59a5e335d44b9b3ebb5680dc/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.h [modify] https://crrev.com/dd9d6fa34e49353c59a5e335d44b9b3ebb5680dc/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm [modify] https://crrev.com/dd9d6fa34e49353c59a5e335d44b9b3ebb5680dc/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h [modify] https://crrev.com/dd9d6fa34e49353c59a5e335d44b9b3ebb5680dc/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm [modify] https://crrev.com/dd9d6fa34e49353c59a5e335d44b9b3ebb5680dc/ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm [modify] https://crrev.com/dd9d6fa34e49353c59a5e335d44b9b3ebb5680dc/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.h [modify] https://crrev.com/dd9d6fa34e49353c59a5e335d44b9b3ebb5680dc/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/820e864f5330b16acc9589274873a74976337eb4 commit 820e864f5330b16acc9589274873a74976337eb4 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed May 23 10:35:48 2018 Re-re-reland "Add blink effect to the PopupMenu" This CL adds an effect to make the "New Incognito Tab" row of the tools menu blink a selected state when the in product help requires it. TBR=edchin@chromium.org Bug: 829344 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia677ddb92ab3ae3a3ea9fc0622cc140b1dce4367 Reviewed-on: https://chromium-review.googlesource.com/1068182 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#561027} [modify] https://crrev.com/820e864f5330b16acc9589274873a74976337eb4/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/820e864f5330b16acc9589274873a74976337eb4/ios/chrome/browser/ui/popup_menu/BUILD.gn [modify] https://crrev.com/820e864f5330b16acc9589274873a74976337eb4/ios/chrome/browser/ui/popup_menu/popup_menu_constants.h [modify] https://crrev.com/820e864f5330b16acc9589274873a74976337eb4/ios/chrome/browser/ui/popup_menu/popup_menu_constants.mm [modify] https://crrev.com/820e864f5330b16acc9589274873a74976337eb4/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.h [modify] https://crrev.com/820e864f5330b16acc9589274873a74976337eb4/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm [modify] https://crrev.com/820e864f5330b16acc9589274873a74976337eb4/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h [modify] https://crrev.com/820e864f5330b16acc9589274873a74976337eb4/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm [modify] https://crrev.com/820e864f5330b16acc9589274873a74976337eb4/ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm [modify] https://crrev.com/820e864f5330b16acc9589274873a74976337eb4/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.h [modify] https://crrev.com/820e864f5330b16acc9589274873a74976337eb4/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
The NextAction date has arrived: 2018-05-23
Comment 1 by cmasso@google.com
, Apr 5 2018