'More tools...' tool tip of Styles tab is seen misplaced in DevTools
Reported by
khushal....@etouch.net,
Apr 5 2018
|
|||||
Issue descriptionChrome Version: 67.0.3389.0 (Official Build) Revision 58f84d059486796cc3652797eab5eab997720cad-refs/heads/master@{#548273} (32/64 bit) OS: Win (7, 8, 8.1, 10), Mac (10.12.6, 10.13.1, 10.13.4), Linux (14.04 LTS) What steps will reproduce the problem? (1) Launch chrome and open Developer tools. (2) Now in Elements section, hover mouse on 'More tools...' (3 dot menu) in 'Styles' tab and observe. Actual Result: 'More tools...' tool tip is is seen misplaced. Expected Result: 'More tools...' tool tip should not be seen misplaced. This is a Non-regression issue seen from M60 series build #60.0.3072.0. Note: Issue is seen on M-65 Stable (build #65.0.3325.181), M-66 Beta (build #66.0.3359.81) and M-67 Dev (build #67.0.3386.1). Thank You!
,
Apr 5 2018
Thanks for the report. Although some 3-dot icons have a tooltip, it is intended that the one in Styles sidepane does not, since it disappears on hover.
,
Apr 6 2018
With respect to comment #2, Correction in actual and expected result: Actual: Unnecessary "More tools..." tooltip appears at the top of the DevTools window (refer attached screenshot). Expected: Tooltip should not appear for 3 dot icon as it disappears on hovering. Note: Please observe tooltip appearing over 'Toggle device toolbar' icon. @luoe: Please have a look in to this issue. THANK YOU..!!
,
Apr 6 2018
Whoops, sorry I see what is meant by misplaced! Reopening.
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67c89d4caa1ffd0b7d30d490e68ae9bd2dc1c544 commit 67c89d4caa1ffd0b7d30d490e68ae9bd2dc1c544 Author: Erik Luo <luoe@chromium.org> Date: Tue May 22 19:54:20 2018 DevTools: do not show tooltip for hidden elements In StylesSidebarPane, the 3-dot 'More tools' icon reveals a toolbar on hover. On 'mouseenter', we set 'display: none' on it, so the following 'mousemove' determines its bounding rect as {x: 0, y: 0, w: 0, h: 0}, and shows a tooltip in the top-left of DevTools. This CL removes the unnecessary tooltip and checks that an element is visible before showing the tooltip. Bug: 829342 Change-Id: Ib0268f70dccbb1190916796e1ca6aadaec763e5f Reviewed-on: https://chromium-review.googlesource.com/1067784 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#560738} [modify] https://crrev.com/67c89d4caa1ffd0b7d30d490e68ae9bd2dc1c544/third_party/blink/renderer/devtools/front_end/elements/StylesSidebarPane.js [modify] https://crrev.com/67c89d4caa1ffd0b7d30d490e68ae9bd2dc1c544/third_party/blink/renderer/devtools/front_end/ui/Tooltip.js
,
May 22 2018
,
May 23 2018
Rechecked the above issue on latest Canary build #68.0.3438.0 for Win (7, 8, 8.1, 10), Mac (10.12.6, 10.13.1, 10.13.4), Linux (14.04 LTS) and the issue is fixed. Please refer the attached screen-cast. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nyerramilli@chromium.org
, Apr 5 2018