ADMX: Add examples |
||||
Issue descriptionThe ADMX templates don't contain examples. This makes especially JSON policies hard to figure out for Active Directory admins (see e.g. 'Configure ARC' in GPO editor). Put the 'example_value' of policy_templates.json into the explaintext of examples from the corresponding policy, see adml_writer.py: self._AddString(policy_name + '_Explain', policy_description)
,
Apr 6 2018
,
Apr 9 2018
As discussed offline - will also add examples to ADM - but since ADM has a size limit, will be careful not to exceed it: will link to external examples instead of including them inline.
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e97099a2d8028c6fbfb52be36d489e8ad4b877d7 commit e97099a2d8028c6fbfb52be36d489e8ad4b877d7 Author: A Olsen <olsen@chromium.org> Date: Wed Apr 11 08:10:20 2018 Changed adml_writer.py to include example values when the values are strings or lists. Bug: 829329 Change-Id: Ib76b6c80c1a2e1966d916d0a684d1ebecf0b0656 Reviewed-on: https://chromium-review.googlesource.com/1000857 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#549819} [modify] https://crrev.com/e97099a2d8028c6fbfb52be36d489e8ad4b877d7/components/policy/resources/policy_templates.json [modify] https://crrev.com/e97099a2d8028c6fbfb52be36d489e8ad4b877d7/components/policy/tools/template_writers/writers/adm_writer.py [modify] https://crrev.com/e97099a2d8028c6fbfb52be36d489e8ad4b877d7/components/policy/tools/template_writers/writers/adm_writer_unittest.py [modify] https://crrev.com/e97099a2d8028c6fbfb52be36d489e8ad4b877d7/components/policy/tools/template_writers/writers/adml_writer.py
,
Apr 11 2018
,
Apr 19 2018
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c19503140285fb826ff4cb9104bbe2d8a971d6c commit 0c19503140285fb826ff4cb9104bbe2d8a971d6c Author: A Olsen <olsen@chromium.org> Date: Fri Jun 08 12:28:23 2018 Fix policy example values in ADML writer The example value formatting code in ADML writer only depends on the example value itself right now. However, depending on the UI the user is shown, example values should be shown in different ways. In particular, it depends if the user is shown a listbox, or a textbox. This CL shows different example values in different ways, depending on the UI that the user is shown. Details follow: If the user needs to input the following list of dicts: [ {"key1": "value1" }, {"key2": "value2" }, {"key3": "value3" } ] Then that is exactly what they should type if they are shown a textbox. But if they are shown a listbox, they should instead type: {"key1": "value1" } {"key2": "value2" } {"key3": "value3" } And each entry should be in its own listbox field. In other words, when a user uses a listbox, they don't need to describe the outermost list because the listbox takes care of it. So, we don't need to show it in the example value either. Similarly if the user needs to input the following list of strings: [ "value1", "value2", "value3" ] They would also type that into a textbox, but would only need to type the following into a listbox: value1 value2 value3 So the string quotes are also made unnecessary by the listbox, and so also should not be shown in the example value. Bug: 829329 Change-Id: Iea994c219f1399d83a64af86f3679f991e46f5a6 Reviewed-on: https://chromium-review.googlesource.com/1090918 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#565614} [modify] https://crrev.com/0c19503140285fb826ff4cb9104bbe2d8a971d6c/components/policy/tools/template_writers/writers/adml_writer.py |
||||
►
Sign in to add a comment |
||||
Comment 1 by ljusten@chromium.org
, Apr 5 2018