New issue
Advanced search Search tips

Issue 829321 link

Starred by 1 user

Issue metadata

Status: Available
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

SigninManagerAndroidTest tests don't go through BrowserProcessImpl

Project Member Reported by eladalon@chromium.org, Apr 5 2018

Issue description

Because the tests in SigninManagerAndroidTest are unit tests, not browser tests, they don't go through BrowserProcessImpl, meaning some classes (e.g. WebRtcEventLogManager) are not instantiated.
 
Labels: OS-Android
As these are unit tests, not integration ones, they should mocks dependencies instead of going through BrowserProcessImpl. For example, SigninManagerAndroidTest should just check that BrowsingDataRemover was invoked.
Components: Services>SignIn
Project Member

Comment 3 by sheriffbot@chromium.org, May 7 2018

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Assigned (was: Available)
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 3

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment