svg/custom/use-events-crash.svg layout test seen to flake on Mac |
|||
Issue descriptionSeen here: https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_chromium_rel_ng/687574 Layout test results: https://test-results.appspot.com/data/layout_results/mac_chromium_rel_ng/687574/layout-test-results/results.html Inline diff: --- /b/s/w/ioAjuPlo/layout-test-results/svg/custom/use-events-crash-expected.txt +++ /b/s/w/ioAjuPlo/layout-test-results/svg/custom/use-events-crash-actual.txt @@ -18,4 +18,4 @@ LayoutSVGContainer {g} at (0,0) size 40x40 [transform={m=((1.00,0.00)(0.00,1.00)) t=(350.00,25.00)}] LayoutSVGContainer {use} at (0,0) size 40x40 LayoutSVGRect {rect} at (0,0) size 40x40 [fill={[type=SOLID] [color=#00FF00]}] [x=0.00] [y=0.00] [width=40.00] [height=40.00] -caret: position 47 of child 0 {#text} of child 1 {text} of child 1 {g} of child 3 {g} of child 3 {g} of child 1 {svg} of document +caret: position 47 of child 0 {#text} of child 1 {text} of child 3 {g} of child 3 {g} of child 3 {g} of child 1 {svg} of document Not sure how often this is happening. There are a lot of flaky Blink layout tests right now. The flakiness dashboard doesn't support searching for "svg/custom/use-events-crash.svg". CC'ing folks who work on the flakiness dashboard and related tools and marking P2 because the inability to see how flaky layout tests are is a significant problem.
,
Apr 5 2018
My search seems to work fine(?): https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=svg/custom/use-events-crash.svg As for why it seems to be failing more consistently now, it seems that 7a8765a7a7e0158e7f82681d06ce798bf8901328 managed to pickup a "bad" baseline, so now it is flaking in the "opposite" direction, which is obviously wrong. (Large baseline updates...) I believe understand the "what" here, but I'm not sure on the "why" though, and I lack the means (target hardware) to dig deeper. I can probably tweak the test to avoid triggering it though.
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a7073f3a8a4ff885a1aa9a5e6cee2b625ebec76 commit 0a7073f3a8a4ff885a1aa9a5e6cee2b625ebec76 Author: Fredrik Söderquist <fs@opera.com> Date: Thu Apr 05 15:34:29 2018 Nudge click point in svg/custom/use-events-crash.svg Issue the click in the test further down the rect in the hope that the selection code won't end up picking one or the other of the <text>s, but only the one further down. Bug: 829316 Change-Id: Iae3419bf902a864ea8ec46e69764480c0f240b8a Reviewed-on: https://chromium-review.googlesource.com/997843 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#548430} [modify] https://crrev.com/0a7073f3a8a4ff885a1aa9a5e6cee2b625ebec76/third_party/WebKit/LayoutTests/platform/mac-mac10.12/svg/custom/use-events-crash-expected.txt [modify] https://crrev.com/0a7073f3a8a4ff885a1aa9a5e6cee2b625ebec76/third_party/WebKit/LayoutTests/svg/custom/use-events-crash.svg
,
Apr 6 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by kbr@chromium.org
, Apr 5 2018Labels: -Pri-2 Pri-1