New issue
Advanced search Search tips

Issue 829305 link

Starred by 2 users
Status: Fixed
Owner:
l...@chromium.org
Closed: May 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: 'screen rotate' icon is seen disabled after running audit in DevTools.

Reported by pranjali...@etouch.net, Apr 5 2018 
Chrome Version: 67.0.3389.0 (Official Build) 58f84d059486796cc3652797eab5eab997720cad-refs/heads/master@{#548273}(32/64 bit)
 
OS: Win(7,8,8.1,10),Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.4).

Steps to reproduce:
1.Launch chrome ,open devtools on NTP.
2.Go to Audit section and run audit .
3.After audit completion,click on 'toggle device toolbar',click on rotate icon and observe.

Actual result:  'screen rotate' icon is seen disabled after running audit  in DevTools.
Expected result: 'screen rotate' icon should not disabled after running audit  in DevTools.

This is Regression issue broken in 'M-65’ and Using the per-revision bisect providing the bisect results,

Good Build:65.0.3295.0   (Revision: 524285 )
Bad Build: 65.0.3296.0  (Revision: 524554 ) 

You are probably looking for a change made after 524288 (known good), but no later than 524290 (first known bad).
CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/c03976e35fab4151673031e792a20c40813876b2..4cbe8ee5fd2f658f07c3a7d2f959f3cc8e2facb2

Suspect : https://chromium.googlesource.com/chromium/src/+/9f8d4632b417d2f4fa8216f9be3a19a16554806c

@luoe- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: Issue is also seen on M-65 Stable(build #65.0.3325.181),Beta M-66 (build # 66.0.3359.81) , Dev  M-67 (build #67.0.3386.1) .
Kindly refer attached screen cast
Actual_result.mp4
1.2 MB View Download
Expected_result.mp4
946 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9caad94d3c187ad082a963cb41a1d1a3a1c2e241

commit 9caad94d3c187ad082a963cb41a1d1a3a1c2e241
Author: Erik Luo <luoe@chromium.org>
Date: Mon May 14 20:18:44 2018

DevTools: fix disabled rotate button after emulate None

After running an Audit, the cached device is set to `null`, so after opening
DeviceMode (DM), the current device does not change.  The Rotate toolbar
button’s enabled state is only updated on emulated Device changed, so it
doesn’t get properly updated.

This CL properly updates the Rotate icon on emulation Type changes
(e.g. None > Responsive), not Device changes.

Bug:  829305 
Change-Id: Ieac2a7d76e7f711409b5d1c0ca5a3da17a9672f5
Reviewed-on: https://chromium-review.googlesource.com/1058037
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558436}
[add] https://crrev.com/9caad94d3c187ad082a963cb41a1d1a3a1c2e241/third_party/WebKit/LayoutTests/http/tests/devtools/device-mode/device-mode-toolbar-expected.txt
[add] https://crrev.com/9caad94d3c187ad082a963cb41a1d1a3a1c2e241/third_party/WebKit/LayoutTests/http/tests/devtools/device-mode/device-mode-toolbar.js
[modify] https://crrev.com/9caad94d3c187ad082a963cb41a1d1a3a1c2e241/third_party/blink/renderer/devtools/front_end/emulation/DeviceModeToolbar.js

Comment 2 by l...@chromium.org, May 14 2018

Labels: -Pri-1 Pri-2
Status: Fixed (was: Assigned)
Considering that there is a clear workaround, switch to another device, marking as Pri-2.
►

Sign in to add a comment