New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829292 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Weird traces of headers are seen while click overview mode button continuously

Project Member Reported by rkalavakuntla@chromium.org, Apr 5 2018

Issue description

Chrome Version:67.0.3383.0/10547.0.0 dev channel Daisy,Kip,Reks
OS: Chrome OS

URL: https://testdrive-archive.azurewebsites.net/performance/fishbowl/

What steps will reproduce the problem?
(1)Sign into chrome >> Open Fish Bowl page keep the fish count to 2000
(2)Open NTP and drag it as separate window
(3)Now click overview mode button continuously and Observe(Please refer video)

Actual: Weird traces of headers are seen while click overview mode button continuously
Expected : No such Weird traces of headers with struck should be seen

This is a Regression issue as same is working fine in 65.0.3225.209/10323.67.0 stable

Note: Issue is not seen in Windows, Linux OS
 
Actual.jpg
3.0 MB View Download
Actual.mp4
11.4 MB View Download
Expected.mp4
8.2 MB View Download
Cc: x...@chromium.org wutao@chromium.org
Owner: sammiequon@chromium.org
Status: Assigned (was: Untriaged)
rkalavakuntla@ - does this still happen on ToT?
Able to reproduce the issue on latest 68.0.3422.0/10654.0.0 dev channel Daisy,Reks
Cc: omrilio@chromium.org
+omrilio

This is because the container with the text icon etc. is being animated by bounds, and the window is animated by transform, so it's not quite synced up.

We could modify to transform the text container but some stuff would break, (drag co-ordinates, scaling of child elements off the top of my head).

Though locally I tested and it happens on the old UI so I don't think this is a regression. The video above looks like it just doesn't animate at all, so you cannot see the mismatch.

Omri, what should the priority be on this?
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cce7708f4c3f375a5c3675585083a2d0a0952f2e

commit cce7708f4c3f375a5c3675585083a2d0a0952f2e
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Aug 08 17:23:22 2018

overview: Do not animate overview header on enter exit.

This was already happening on tablet mode. Ux said it is ok to match
the two now. Also change some values for the header fade in animation.

Test: manual
Bug:  829292 
Change-Id: I428081f0d19d1b8508e8576f5ea8a36e75843e6b
Reviewed-on: https://chromium-review.googlesource.com/1164534
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581613}
[modify] https://crrev.com/cce7708f4c3f375a5c3675585083a2d0a0952f2e/ash/wm/overview/overview_animation_type.h
[modify] https://crrev.com/cce7708f4c3f375a5c3675585083a2d0a0952f2e/ash/wm/overview/overview_utils.cc
[modify] https://crrev.com/cce7708f4c3f375a5c3675585083a2d0a0952f2e/ash/wm/overview/overview_utils.h
[modify] https://crrev.com/cce7708f4c3f375a5c3675585083a2d0a0952f2e/ash/wm/overview/scoped_overview_animation_settings.cc
[modify] https://crrev.com/cce7708f4c3f375a5c3675585083a2d0a0952f2e/ash/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/cce7708f4c3f375a5c3675585083a2d0a0952f2e/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/cce7708f4c3f375a5c3675585083a2d0a0952f2e/ash/wm/overview/window_selector_item.h

Status: Fixed (was: Assigned)

Sign in to add a comment