New issue
Advanced search Search tips

Issue 829282 link

Starred by 1 user
Status: Duplicate
Merged: issue 829228
Owner: ----
Closed: Apr 2018
Cc:
mastiz@google.com
thomasanderson@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

webkit_layout_tests failing on chromium.webkit/WebKit Mac10.10

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 5 2018 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of mastiz@google.com

...... too many results, data snipped.... and 40 other(s) in webkit_layout_tests failing on chromium.webkit/WebKit Mac10.10

Builders failed on: 
- WebKit Mac10.10: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10

Comment 1 by mastiz@chromium.org, Apr 5 2018

Summary: webkit_layout_tests failing on chromium.webkit/WebKit Mac10.10 (was: ...... too many results, data snipped.... and 40 other(s) in webkit_layout_tests failing on chromium.webkit/WebKit Mac10.10)
Besides the flakiness with webgl-oversized-printing.html, it seems like many tests started to fail first with https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.10/45372

That suggests the range:
6b17a19a6c95c70c333af563db1c17795e5146c1..254ce1becd1721b163a8014cc9a9e5b6893a57b6

In that range, the main suspect is:
https://chromium-review.googlesource.com/996755

Comment 2 by mastiz@chromium.org, Apr 5 2018

Cc: thomasanderson@chromium.org

Comment 3 by mastiz@chromium.org, Apr 5 2018 

From what I can see in  crbug.com/787020 , the author avoided a revert of the culprit patch and instead disabled a few tests, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/997182

I wonder why a revert wouldn't have been more appropriate.

It seems like a few more tests would need to be disabled:
external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https.html
external/wpt/shadow-dom/untriaged/events/retargeting-focus-events/test-003.html
virtual/incremental-shadow-dom/external/wpt/shadow-dom/untriaged/events/retargeting-focus-events/test-003.html
virtual/navigation-mojo-response/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https.html
virtual/outofblink-cors/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https.html
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b5f038c24ccd4c1ec7ee0c32ca9d495ecb4229f

commit 2b5f038c24ccd4c1ec7ee0c32ca9d495ecb4229f
Author: Mikel Astiz <mastiz@chromium.org>
Date: Thu Apr 05 10:59:27 2018

Disable more layout tests after r548309

The tests are failing consistently on chromium.webkit/WebKit Mac10.10.

TBR=thomasanderson@chromium.org

Bug:  787020 , 829282 
Change-Id: Ibad916df060e441b99cb13b8970ce85c1f34bec0
Reviewed-on: https://chromium-review.googlesource.com/997555
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548384}
[modify] https://crrev.com/2b5f038c24ccd4c1ec7ee0c32ca9d495ecb4229f/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by mastiz@chromium.org, Apr 5 2018

Mergedinto: 829228
Status: Duplicate (was: Available)
►

Sign in to add a comment