New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829272 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Default cursor is seen in Grey color instead of Blue at 'ENTER SIM PIN' Dialog box in Cellular Connection Page

Project Member Reported by mmanchala@chromium.org, Apr 5 2018

Issue description

Chrome Version: 67.0.3383.0/10547.0.0 dev channel Daisy,Kip,Reks
OS: Chrome

What steps will reproduce the problem?
1)Sign into User ->Insert Mobile Dongle and ensure it is connected
(2)Now go to chrome://settings page -> At Internet Connection click on Cellular connection -> Navigates to Cellular connected page
(3)Now Enable 'Enable SIM Card locking(require PIN to use Mobile data) option -> 'ENTER SIM PIN' Dialog box is seen -> Observe Default cursor is seen in Grey color instead of Blue
(Please refer Video and Screenshot)

Note: 
1.Issue is seen in 'Change SIM PIN' Dialog box and 'SIM card is locked' Dialog box also
2.Issue is seen on M-64, M-65 and also on M-66

Expected:  Default cursor should be seen in Blue at 'ENTER SIM PIN' Dialog box
Actual: Instead  Default cursor is seen in Grey color instead of Blue

This is Regression issue as same is working fine in M-63

@stevenjb : Please confirm the Issue
 
Actual_GreyDefaultFocus.webm
1.1 MB View Download
Actual_GreyDefaultFocus.jpg
183 KB View Download
Expected_BlueDefaultFocus.webm
565 KB View Download
Expected_BlueDefaultFocus.jpg
171 KB View Download

Comment 1 by ajha@chromium.org, Apr 5 2018

Labels: -Pri-1 Pri-2
Description: Show this description
Labels: -M-67 M-68
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb12d31bc08f755fce655514cd98bd63836489a3

commit eb12d31bc08f755fce655514cd98bd63836489a3
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jun 08 15:55:51 2018

Settings > network > update input and dialog style

This CL fixes a number of inconsistencies with input style and
overall dialog appearance.

Bug:  832177 , 829272 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icb5bdd4245073d3c8db5100ebc3bca1a8b4f1b17
Reviewed-on: https://chromium-review.googlesource.com/1091166
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565643}
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/chrome/browser/resources/settings/internet_page/network_proxy_section.js
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/BUILD.gn
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/compiled_resources2.gyp
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_config.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_config.js
[delete] https://crrev.com/87d70d4c17f9cfd0afbc8a5e3a54b1dd535b543b/ui/webui/resources/cr_components/chromeos/network/network_config_input.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_config_select.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_ip_config.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_nameservers.html
[add] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_password_input.html
[rename] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_password_input.js
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_property_list.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_property_list.js
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_proxy.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_proxy_input.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_proxy_input.js
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_shared_css.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/chromeos/network/network_siminfo.js
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_components/cr_components_resources.grdp
[modify] https://crrev.com/eb12d31bc08f755fce655514cd98bd63836489a3/ui/webui/resources/cr_elements/cr_input/cr_input.html

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/703d7360466174796eb69471dd1cb9b81f80beb6

commit 703d7360466174796eb69471dd1cb9b81f80beb6
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jun 13 22:51:26 2018

Settings > Network > Proxy: Use 'suffix' slot

Bug:  829272 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I79f0be1b2c5751cf62a5c4cfed1dad30fe1f6358
Reviewed-on: https://chromium-review.googlesource.com/1096285
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567031}
[modify] https://crrev.com/703d7360466174796eb69471dd1cb9b81f80beb6/ui/webui/resources/cr_components/chromeos/network/network_proxy.html
[modify] https://crrev.com/703d7360466174796eb69471dd1cb9b81f80beb6/ui/webui/resources/cr_elements/cr_input/cr_input.html

Owner: mmanchala@chromium.org
@mmanchala, can you please verify this bug?
Owner: steve...@chromium.org
Checked and Issue is working fine on latest M-70 70.0.3538.41/11021.37.0 beta-channel Candy

Thanks..!!

Sign in to add a comment