New issue
Advanced search Search tips

Issue 829239 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 5
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

expose termina versioning info to LXD containers

Project Member Reported by smbar...@chromium.org, Apr 5 2018

Issue description

Container guest packages might need to know the termina host version to change their behavior. For example, sommelier or garcon might change their command line arguments, and the guest package will need to support the old and new versions for a while.

We can probably expose this the same way we do everything else - a bind mount to some place like /dev/.cros_version.
 
Status: Assigned (was: Unconfirmed)
Labels: Hotlist-Crostini-Platform
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tremplin/+/c266fb63b94664686649231932b4c9951b4f01f7

commit c266fb63b94664686649231932b4c9951b4f01f7
Author: Stephen Barber <smbarber@chromium.org>
Date: Tue Aug 28 23:17:52 2018

tremplin: use CrOS milestone in the guest

If the guest is Debian, set the milestone version in cros.list for apt.

Add a bind mount to allow guests to determine which CrOS milestone
it is being run on.

BUG= chromium:829239 , chromium:870529 
TEST=cat /dev/.cros_milestone from container
TEST=cat /etc/apt/sources.list.d/cros.list

Change-Id: Ic43ea5118f2c63d8b2e1a343230a2511c48cddbd
Reviewed-on: https://chromium-review.googlesource.com/1171557
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/c266fb63b94664686649231932b4c9951b4f01f7/src/chromiumos/tremplin/main.go
[add] https://crrev.com/c266fb63b94664686649231932b4c9951b4f01f7/src/chromiumos/tremplin/version.go
[modify] https://crrev.com/c266fb63b94664686649231932b4c9951b4f01f7/src/chromiumos/tremplin/tremplin.go

Status: Fixed (was: Assigned)

Sign in to add a comment