New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 829232 link

Starred by 4 users
Status: Available
Owner: ----
Cc:
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Reduce inconsistencies in calls to InstallableManager::GetData

Project Member Reported by dominickn@chromium.org, Apr 5 2018 
We currently have a number of call paths of InstallableManager::GetData that could be consolidated:
 - AppBannerManager (calls 2x: one time for the manifest, and one time for installability)
 - BookmarkAppHelper (calls 1x for installability)
 - AddToHomescreenDataFetcher (calls 2x: one time for the manifest + icon, and one time for installability)
 - AppMenuModel (implicitly calls AppBannerManager)
 - WebApkUpdateDataFetcher (calls 2x for installability)

Once IsExperimentalAppBanners() is released on all platforms, we can investigate unifying some of these call paths to reduce inconsistencies between them (e.g.  Issue 829209 ).

Comment 1 by dominickn@chromium.org, Apr 5 2018

Summary: Reduce inconsistencies in calls to InstallableManager::GetData (was: Make InstallableManager the source of truth for PWA-ness)

Comment 2 by loyso@chromium.org, Nov 2 

What's the blocking bug (for IsExperimentalAppBanners?) ?

Comment 3 by loyso@chromium.org, Nov 2

Components: Platform>Apps>Foundation

Comment 4 by dominickn@chromium.org, Nov 2 

We need to launch on Mac (Issue 851848).
►

Sign in to add a comment