New issue
Advanced search Search tips

Issue 829228 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty (dbg) and Win7

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 5 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of shend@chromium.org

Builders failed on: 
- WebKit Linux Trusty (dbg):

Example: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/11278

virtual/modern-media-controls/media/controls/modern/doubletap-to-jump-forwards-too-short.html is consistently failing.
Looks like https://chromium.googlesource.com/chromium/src/+/7a8765a7a7e0158e7f82681d06ce798bf8901328 added a failing expectation to the test, but in reality it passes.


 

Comment 1 by shend@chromium.org, Apr 5 2018

Cc: beccahughes@chromium.org
Components: Blink>Media>Controls
Owner: thomasanderson@chromium.org
Status: Assigned (was: Available)
I'm reluctant to revert the patch as it looks like it was really difficult to land. Looks like it might be some rebasing issue going on, but I couldn't reproduce the issue locally on Linux. I'm going to disable this test instead.

cc'ing beccahughes who wrote the test.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e3e507a9998868cf17f4ad0d0d224a917db692e

commit 9e3e507a9998868cf17f4ad0d0d224a917db692e
Author: Darren Shen <shend@chromium.org>
Date: Thu Apr 05 09:07:26 2018

Disable test doubletap-to-jump-forwards-too-short on WebKit trusty debug

Likely failing due to incorrect rebaselining from:
https://chromium.googlesource.com/chromium/src/+/7a8765a7a7e0158e7f82681d06ce798bf8901328

TBR=beccahughes@chromium.org
TBR=thomasanderson@chromium.org

Bug:  829228 
Change-Id: Icf2894aae0a4c0ed3baa85d82f7dd47417410d23
Reviewed-on: https://chromium-review.googlesource.com/997197
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548371}
[modify] https://crrev.com/9e3e507a9998868cf17f4ad0d0d224a917db692e/third_party/WebKit/LayoutTests/TestExpectations

Cc: thomasanderson@chromium.org mastiz@google.com
 Issue 829282  has been merged into this issue.
 Issue 829357  has been merged into this issue.
Status: Started (was: Assigned)

Comment 6 by zmin@chromium.org, Apr 5 2018

Cc: zmin@chromium.org
 Issue 828562  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/341f9b7e7a76b4453db17e51128de0471280d0e8

commit 341f9b7e7a76b4453db17e51128de0471280d0e8
Author: Mikel Astiz <mastiz@chromium.org>
Date: Thu Apr 05 15:33:59 2018

Disable test doubletap-to-jump-forwards-too-short on Linux

Follow-up to https://chromium-review.googlesource.com/997197 where,
presumably, the wrong test was disabled.

TBR=beccahughes@chromium.org
TBR=thomasanderson@chromium.org

Bug:  829228 
Change-Id: Icd680733174a87d05172fe842b0dc0eed46aa80d
Reviewed-on: https://chromium-review.googlesource.com/997745
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548429}
[modify] https://crrev.com/341f9b7e7a76b4453db17e51128de0471280d0e8/third_party/WebKit/LayoutTests/TestExpectations

Cc: -zmin@chromium.org steimel@chromium.org
Cc: zmin@chromium.org
Summary: webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty (dbg) and Win7 (was: webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty (dbg))
Failing on Win7 as well.
Example: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win7/62491
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e405e24c682904c03fcf620c388fb004b60ec0b

commit 9e405e24c682904c03fcf620c388fb004b60ec0b
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Thu Apr 05 18:40:06 2018

Disable test doubletap-to-jump-forwards-too-short on Win7

The test is failing on Win7 Tests (dbg)(1) and WebKit Win7 as well.

TBR=beccahughes@chromium.org
TBR=thomasanderson@chromium.org

No-Try: true
No-Presubmit: true
No-Tree-Checks: true

Bug:  829228 
Change-Id: I676a6d19c2f35a3acd8fc701b409fc8c2fb4ba20
Reviewed-on: https://chromium-review.googlesource.com/998332
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548500}
[modify] https://crrev.com/9e405e24c682904c03fcf620c388fb004b60ec0b/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/817c8546dc71980944aead4a97e301d70869c71d

commit 817c8546dc71980944aead4a97e301d70869c71d
Author: Darren Shen <shend@chromium.org>
Date: Thu Apr 05 23:13:05 2018

Revert "Disable test doubletap-to-jump-forwards-too-short on WebKit trusty debug"

This reverts commit 9e3e507a9998868cf17f4ad0d0d224a917db692e.

Reason for revert: Disabled wrong test.

Original change's description:
> Disable test doubletap-to-jump-forwards-too-short on WebKit trusty debug
>
> Likely failing due to incorrect rebaselining from:
> https://chromium.googlesource.com/chromium/src/+/7a8765a7a7e0158e7f82681d06ce798bf8901328
>
> TBR=beccahughes@chromium.org
> TBR=thomasanderson@chromium.org
>
> Bug:  829228 
> Change-Id: Icf2894aae0a4c0ed3baa85d82f7dd47417410d23
> Reviewed-on: https://chromium-review.googlesource.com/997197
> Reviewed-by: Darren Shen <shend@chromium.org>
> Commit-Queue: Darren Shen <shend@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548371}

TBR=thomasanderson@chromium.org,shend@chromium.org,beccahughes@chromium.org

Change-Id: I4000d62b9e4802214eabd139d62027d9e5664c50
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  829228 
Reviewed-on: https://chromium-review.googlesource.com/999073
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548606}
[modify] https://crrev.com/817c8546dc71980944aead4a97e301d70869c71d/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
Bot appears to have recovered, removing from sheriff queue.
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8c418d76f58828b7c496b7cedc97d3279e6a387

commit a8c418d76f58828b7c496b7cedc97d3279e6a387
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Apr 06 17:11:51 2018

Reenable and rebaseline layout tests after r548309

BUG= 787020 , 829228 
TBR=eae

Change-Id: If6bffd3778b2bee8749fa3b1f77a0affd599d1ba
Reviewed-on: https://chromium-review.googlesource.com/998133
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548825}
[modify] https://crrev.com/a8c418d76f58828b7c496b7cedc97d3279e6a387/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/0dd7412668ce4dc71a063a6657e8cba460b1a377/third_party/WebKit/LayoutTests/platform/linux/virtual/modern-media-controls/media/controls/modern/doubletap-to-jump-forwards-too-short-expected.txt
[delete] https://crrev.com/0dd7412668ce4dc71a063a6657e8cba460b1a377/third_party/WebKit/LayoutTests/platform/mac-mac10.10/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https-expected.txt
[delete] https://crrev.com/0dd7412668ce4dc71a063a6657e8cba460b1a377/third_party/WebKit/LayoutTests/platform/mac-mac10.10/external/wpt/shadow-dom/untriaged/events/retargeting-focus-events/test-003-expected.txt
[rename] https://crrev.com/a8c418d76f58828b7c496b7cedc97d3279e6a387/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/layout_ng/fast/block/basic/014-expected.png
[rename] https://crrev.com/a8c418d76f58828b7c496b7cedc97d3279e6a387/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/threaded/printing/tfoot-repeats-at-bottom-of-each-page-multiple-tables-expected.png
[delete] https://crrev.com/0dd7412668ce4dc71a063a6657e8cba460b1a377/third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https-expected.txt
[rename] https://crrev.com/a8c418d76f58828b7c496b7cedc97d3279e6a387/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-zero-length-lineCap-expected.png
[delete] https://crrev.com/0dd7412668ce4dc71a063a6657e8cba460b1a377/third_party/WebKit/LayoutTests/platform/win/virtual/layout_ng/fast/block/basic/014-expected.png
[delete] https://crrev.com/0dd7412668ce4dc71a063a6657e8cba460b1a377/third_party/WebKit/LayoutTests/platform/win/virtual/threaded/printing/tfoot-repeats-at-bottom-of-each-page-multiple-tables-expected.png
[delete] https://crrev.com/0dd7412668ce4dc71a063a6657e8cba460b1a377/third_party/WebKit/LayoutTests/platform/win7/virtual/modern-media-controls/media/controls/modern/doubletap-to-jump-forwards-too-short-expected.txt
[delete] https://crrev.com/0dd7412668ce4dc71a063a6657e8cba460b1a377/third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/http/tests/devtools/tracing/timeline-js/compile-script-expected.txt

Status: Fixed (was: Started)

Sign in to add a comment