New issue
Advanced search Search tips

Issue 829203 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Make clear what test failed on "integration_test" timeout

Project Member Reported by lucmult@chromium.org, Apr 5 2018

Issue description

Currently when an test from our /integration_test/ directory fails it isn't clear:

1. What exactly test (JS file or line) has failed.
2. What's the exact is waiting for.

There is a "pending" function [1] which prints out when some of helper functions is waiting/pooling.

It'd would be good if this function printed out what's the caller of the helper function so it tells us what test is failing/pending/timing out.

[1] - https://cs.chromium.org/chromium/src/ui/file_manager/integration_tests/test_util.js

Example output that "pending" currently shows when a test fails:
...
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
[31960:31986:0329/003456.666358:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory
[31960:31986:0329/003456.666457:ERROR:audio_output_resampler.cc(396)] Unable to open audio device in high latency mode.  Falling back to fake audio output.
[31960:31960:0329/003500.134613:INFO:CONSOLE(112)] "Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (112)
[31960:31960:0329/003503.196705:INFO:CONSOLE(112)] "Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (112)
[31960:31960:0329/003506.117774:INFO:CONSOLE(112)] "Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (112)
[31960:31960:0329/003506.519243:INFO:CONSOLE(0)] "Error in event handler for runtime.onSuspend: TypeError: The first argument is the receiver and must be an object", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0)
[31960:31960:0329/003509.181438:INFO:CONSOLE(112)] "Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (112)
[31960:31960:0329/003512.247962:INFO:CONSOLE(112)] "Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (112)
[31960:31960:0329/003515.109432:INFO:CONSOLE(112)] "Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (112)
[31960:31960:0329/003518.177163:INFO:CONSOLE(112)] "Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (112)
[31960:31960:0329/003521.260456:INFO:CONSOLE(112)] "Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (112)
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x00000432b10c base::debug::StackTrace::StackTrace()
...


With my proposed patch: crrev.com/c/995242
------------------------------------------

...
[260320:260320:0405/133229.662128:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source:  (0)                                                          
Still waiting for the following processes to finish:
        out/cOS/browser_tests --gtest_also_run_disabled_tests --gtest_filter=DirectoryTreeContextMenu/FileManagerBrowserTest.Test/0 --single_process --test-launcher-output=/tmp/.org.chromium.Chromium.kvjdPQ/resultsgDvFq5/test_results.xml --user-data-dir=/tmp/.org.chromium
.Chromium.kvjdPQ/dAjIV7X
[260320:260320:0405/133233.683120:INFO:CONSOLE(136)] "at /file_manager/directory_tree_context_menu.js:125:23: Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbp
ejbbpdbkdjmoco/test_util.js (136)
[260320:260320:0405/133236.745054:INFO:CONSOLE(136)] "at /file_manager/directory_tree_context_menu.js:125:23: Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbp
ejbbpdbkdjmoco/test_util.js (136)
[260320:260320:0405/133239.558471:INFO:CONSOLE(0)] "Error in event handler for runtime.onSuspend: TypeError: The first argument is the receiver and must be an object", source: chrome-extension://dmboannefpncccogfdikhmhpmdnddgoe/_generated_background_page.html (0)
[260320:260320:0405/133239.804384:INFO:CONSOLE(136)] "at /file_manager/directory_tree_context_menu.js:125:23: Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbp
ejbbpdbkdjmoco/test_util.js (136)
[260320:260320:0405/133242.657637:INFO:CONSOLE(136)] "at /file_manager/directory_tree_context_menu.js:125:23: Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbp
ejbbpdbkdjmoco/test_util.js (136)
[260320:260320:0405/133245.713636:INFO:CONSOLE(136)] "at /file_manager/directory_tree_context_menu.js:125:23: Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbp
ejbbpdbkdjmoco/test_util.js (136)
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x7fdc19227a7c base::debug::StackTrace::StackTrace()
#1 0x000002885205 Still waiting for the following processes to finish:
        out/cOS/browser_tests --gtest_also_run_disabled_tests --gtest_filter=DirectoryTreeContextMenu/FileManagerBrowserTest.Test/0 --single_process --test-launcher-output=/tmp/.org.chromium.Chromium.kvjdPQ/resultsgDvFq5/test_results.xml --user-data-dir=/tmp/.org.chromium
.Chromium.kvjdPQ/dAjIV7X
content::(anonymous namespace)::DumpStackTraceSignalHandler()
...

 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba425cb8e719f016d43d863137c41a53f111bc55

commit ba425cb8e719f016d43d863137c41a53f111bc55
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Apr 10 13:56:05 2018

Report the caller of integration tests test_util.js |pending| function

This change helps when debugging failing tests by displaying the
caller's file name and line number/column when a test fails.

I have tested it on |waitForFiles| function and it showed the exact test
and file failing when waiting for files that haven't appeared.

[31960:31960:0329/003500.134613:INFO:CONSOLE(112)] "Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (112)

With this patch:

[260320:260320:0405/133233.683120:INFO:CONSOLE(136)] "at /file_manager/directory_tree_context_menu.js:125:23: Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbp
ejbbpdbkdjmoco/test_util.js (136)

Bug:  829203 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I97e07683b52f107b36ff8af2335e98193ff275b2
Reviewed-on: https://chromium-review.googlesource.com/995242
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549512}
[modify] https://crrev.com/ba425cb8e719f016d43d863137c41a53f111bc55/ui/file_manager/integration_tests/file_manager/background.js
[modify] https://crrev.com/ba425cb8e719f016d43d863137c41a53f111bc55/ui/file_manager/integration_tests/file_manager/create_new_folder.js
[modify] https://crrev.com/ba425cb8e719f016d43d863137c41a53f111bc55/ui/file_manager/integration_tests/file_manager/grid_view.js
[modify] https://crrev.com/ba425cb8e719f016d43d863137c41a53f111bc55/ui/file_manager/integration_tests/file_manager/keyboard_operations.js
[modify] https://crrev.com/ba425cb8e719f016d43d863137c41a53f111bc55/ui/file_manager/integration_tests/file_manager/open_audio_files.js
[modify] https://crrev.com/ba425cb8e719f016d43d863137c41a53f111bc55/ui/file_manager/integration_tests/file_manager/quick_view.js
[modify] https://crrev.com/ba425cb8e719f016d43d863137c41a53f111bc55/ui/file_manager/integration_tests/file_manager/restore_geometry.js
[modify] https://crrev.com/ba425cb8e719f016d43d863137c41a53f111bc55/ui/file_manager/integration_tests/file_manager/share_dialog.js
[modify] https://crrev.com/ba425cb8e719f016d43d863137c41a53f111bc55/ui/file_manager/integration_tests/file_manager/tasks.js
[modify] https://crrev.com/ba425cb8e719f016d43d863137c41a53f111bc55/ui/file_manager/integration_tests/file_manager_test_manifest.json
[modify] https://crrev.com/ba425cb8e719f016d43d863137c41a53f111bc55/ui/file_manager/integration_tests/remote_call.js
[modify] https://crrev.com/ba425cb8e719f016d43d863137c41a53f111bc55/ui/file_manager/integration_tests/test_util.js
[modify] https://crrev.com/ba425cb8e719f016d43d863137c41a53f111bc55/ui/file_manager/integration_tests/video_player/click_control_buttons.js

Status: Fixed (was: Started)
I got a test failure today and the error was clear! :-)

https://chromium-review.googlesource.com/c/chromium/src/+/985772/12

[32514:32514:0411/001750.383828:INFO:CONSOLE(139)] "at expectSelection (/file_manager/folder_shortcuts.js:227:21): waitForFiles: expected: [] actual [["C","--","Folder","Jan 1, 2000, 1:00 AM"]].", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (139)
[32514:32514:0411/001753.448032:INFO:CONSOLE(139)] "at expectSelection (/file_manager/folder_shortcuts.js:227:21): waitForFiles: expected: [] actual [["C","--","Folder","Jan 1, 2000, 1:00 AM"]].", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (139)

Comment 4 by noel@chromium.org, Apr 11 2018

:)

Sign in to add a comment