New issue
Advanced search Search tips

Issue 829192 link

Starred by 30 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 834585



Sign in to add a comment

maitred: add RPC for updating resolv.conf

Project Member Reported by smbar...@chromium.org, Apr 5 2018

Issue description

This should be done like shill - have a resolv.conf under /run which will be bind-mounted over our default one.
 
The current behavior effectively breaks networking with strict networks, such as mine, that firewall attempts to bypass the DHCP-supplied DNS server.
Labels: Hotlist-Crostini-Platform
Blocking: 834585
 Issue 863665  has been merged into this issue.
Owner: smbar...@chromium.org
Status: Started (was: Available)
 Issue 882683  has been merged into this issue.
 Issue 886933  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3ee05117632975cf254805740ad58d133e10054d

commit 3ee05117632975cf254805740ad58d133e10054d
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Oct 11 00:08:03 2018

vm_host_tools: add DEPEND on shill-client

BUG= chromium:829192 
TEST=check /etc/resolv.conf in VM

Change-Id: Ibc605d2bae42b74e2f34fa9ab8b0e5900aeb8a78
Reviewed-on: https://chromium-review.googlesource.com/1250542
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/3ee05117632975cf254805740ad58d133e10054d/chromeos-base/vm_host_tools/vm_host_tools-9999.ebuild

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/baec52f855f7d285071fe0faeb696a7d68d50f30

commit baec52f855f7d285071fe0faeb696a7d68d50f30
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Oct 11 04:33:36 2018

vm_guest_tools: install resolv.conf symlink

BUG= chromium:829192 
TEST=/etc/resolv.conf is a symlink to /run/resolv.conf
CQ-DEPEND=CL:1260309

Change-Id: Ib13c4d3c1fab594febe9b3b6b082243c8c3374d3
Reviewed-on: https://chromium-review.googlesource.com/1260582
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/baec52f855f7d285071fe0faeb696a7d68d50f30/chromeos-base/vm_guest_tools/vm_guest_tools-9999.ebuild

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8d93b00679ab9528226587218d9397c75d15bb85

commit 8d93b00679ab9528226587218d9397c75d15bb85
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Oct 11 20:25:55 2018

vm_tools: maitred: add SetResolvConf RPC

BUG= chromium:829192 
TEST=check /etc/resolv.conf in VM
CQ-DEPEND=CL:1260309,CL:1260582

Change-Id: I2beac02f5ed11ff567a8007b0f28b0130d525297
Reviewed-on: https://chromium-review.googlesource.com/1249677
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/8d93b00679ab9528226587218d9397c75d15bb85/vm_tools/maitred/main.cc
[modify] https://crrev.com/8d93b00679ab9528226587218d9397c75d15bb85/vm_tools/maitred/service_impl.h
[modify] https://crrev.com/8d93b00679ab9528226587218d9397c75d15bb85/vm_tools/proto/vm_guest.proto
[modify] https://crrev.com/8d93b00679ab9528226587218d9397c75d15bb85/vm_tools/maitred/service_impl.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tremplin/+/2aa495ec1af8398d7e6dfe876ded977881a8da73

commit 2aa495ec1af8398d7e6dfe876ded977881a8da73
Author: Stephen Barber <smbarber@chromium.org>
Date: Fri Oct 12 18:43:24 2018

tremplin: point dnsmasq to /run/resolv.conf

This must land after both the host and guest are updated to support
the new SetResolvConf RPC.

BUG= chromium:829192 
TEST=DNS in container still works
CQ-DEPEND=CL:1249678

Change-Id: Icdcab03002e64bd956a2f29cfe24c8e06e1145cd
Reviewed-on: https://chromium-review.googlesource.com/1250543
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/2aa495ec1af8398d7e6dfe876ded977881a8da73/src/chromiumos/tremplin/main.go

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1610ad1c64ab9e2bc86a8dccf620a874e37dae02

commit 1610ad1c64ab9e2bc86a8dccf620a874e37dae02
Author: Stephen Barber <smbarber@chromium.org>
Date: Fri Oct 12 18:43:24 2018

vm_tools: concierge: listen for DNS changes

BUG= chromium:829192 
TEST=check for /etc/resolv.conf in VM
CQ-DEPEND=CL:1250542

Change-Id: I53fd83488712a48b58dddb1057c247e68e43ae15
Reviewed-on: https://chromium-review.googlesource.com/1249678
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/1610ad1c64ab9e2bc86a8dccf620a874e37dae02/vm_tools/host.gypi
[modify] https://crrev.com/1610ad1c64ab9e2bc86a8dccf620a874e37dae02/vm_tools/concierge/virtual_machine_test.cc
[modify] https://crrev.com/1610ad1c64ab9e2bc86a8dccf620a874e37dae02/vm_tools/dbus/org.chromium.VmConcierge.conf
[modify] https://crrev.com/1610ad1c64ab9e2bc86a8dccf620a874e37dae02/vm_tools/concierge/service.cc
[add] https://crrev.com/1610ad1c64ab9e2bc86a8dccf620a874e37dae02/vm_tools/concierge/shill_client.h
[add] https://crrev.com/1610ad1c64ab9e2bc86a8dccf620a874e37dae02/vm_tools/concierge/shill_client.cc
[modify] https://crrev.com/1610ad1c64ab9e2bc86a8dccf620a874e37dae02/vm_tools/concierge/service.h
[modify] https://crrev.com/1610ad1c64ab9e2bc86a8dccf620a874e37dae02/vm_tools/concierge/virtual_machine.cc
[modify] https://crrev.com/1610ad1c64ab9e2bc86a8dccf620a874e37dae02/vm_tools/concierge/virtual_machine.h

Labels: M-71 Merge-Request-71
Requesting merge to 71 for #12 and #13 which didn't make it in before branch.

Verified on CrOS 11161.0.0 and termina 11152.0.0.
Project Member

Comment 15 by sheriffbot@chromium.org, Oct 16

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 16

Labels: merge-merged-release-R71-11151.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tremplin/+/f128fb0b083f6c2a9bdbdfaecee87f01ea4c7d13

commit f128fb0b083f6c2a9bdbdfaecee87f01ea4c7d13
Author: Stephen Barber <smbarber@chromium.org>
Date: Tue Oct 16 23:33:31 2018

tremplin: point dnsmasq to /run/resolv.conf

This must land after both the host and guest are updated to support
the new SetResolvConf RPC.

BUG= chromium:829192 
TEST=DNS in container still works
CQ-DEPEND=CL:1249678

Change-Id: Icdcab03002e64bd956a2f29cfe24c8e06e1145cd
Reviewed-on: https://chromium-review.googlesource.com/1250543
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
(cherry picked from commit 2aa495ec1af8398d7e6dfe876ded977881a8da73)
Reviewed-on: https://chromium-review.googlesource.com/c/1284991
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Commit-Queue: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/f128fb0b083f6c2a9bdbdfaecee87f01ea4c7d13/src/chromiumos/tremplin/main.go

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/25facaf87499ad1bbe4d121be004c3e34d77e2b9

commit 25facaf87499ad1bbe4d121be004c3e34d77e2b9
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Oct 18 20:39:22 2018

vm_tools: concierge: listen for DNS changes

BUG= chromium:829192 
TEST=check for /etc/resolv.conf in VM
CQ-DEPEND=CL:1250542

Change-Id: I53fd83488712a48b58dddb1057c247e68e43ae15
Reviewed-on: https://chromium-review.googlesource.com/1249678
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
(cherry picked from commit 1610ad1c64ab9e2bc86a8dccf620a874e37dae02)
Reviewed-on: https://chromium-review.googlesource.com/c/1284850
Commit-Queue: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/25facaf87499ad1bbe4d121be004c3e34d77e2b9/vm_tools/host.gypi
[modify] https://crrev.com/25facaf87499ad1bbe4d121be004c3e34d77e2b9/vm_tools/concierge/virtual_machine_test.cc
[modify] https://crrev.com/25facaf87499ad1bbe4d121be004c3e34d77e2b9/vm_tools/dbus/org.chromium.VmConcierge.conf
[modify] https://crrev.com/25facaf87499ad1bbe4d121be004c3e34d77e2b9/vm_tools/concierge/service.cc
[add] https://crrev.com/25facaf87499ad1bbe4d121be004c3e34d77e2b9/vm_tools/concierge/shill_client.h
[add] https://crrev.com/25facaf87499ad1bbe4d121be004c3e34d77e2b9/vm_tools/concierge/shill_client.cc
[modify] https://crrev.com/25facaf87499ad1bbe4d121be004c3e34d77e2b9/vm_tools/concierge/service.h
[modify] https://crrev.com/25facaf87499ad1bbe4d121be004c3e34d77e2b9/vm_tools/concierge/virtual_machine.cc
[modify] https://crrev.com/25facaf87499ad1bbe4d121be004c3e34d77e2b9/vm_tools/concierge/virtual_machine.h

Labels: -Merge-Approved-71 Merge-Merged
Status: Verified (was: Started)

Sign in to add a comment