New issue
Advanced search Search tips

Issue 829182 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 829174



Sign in to add a comment

Check easyUnlockPrivate extension function's GetCryptoDelegate's async behavior

Project Member Reported by lazyboy@chromium.org, Apr 5 2018

Issue description

(This is a proactive bug filing, the reference CL(s) has not landed or been reviewed yet, I'm filing this bug for reference. tbarzic@, look at the bug after relevant CL(s) lands)

I'm about to change easyUnlockPrivate api's rest of the ExtensionFunction implementations to extend from UIThreadExtensionFunction, as part of nuking AsyncExtensionFunction (https://chromium-review.googlesource.com/c/chromium/src/+/994711 only for reference, and   https://crbug.com/829174  for AsyncExtensionFunction)

However, I'm not entirely certain about calls like:

GetCryptoDelegate(browser_context())->CreateSecureMessage(
      *params,
      base::Bind(&EasyUnlockPrivateCreateSecureMessageFunction::OnData,
                 this));

Right after this call, it would be better if we can say with certainty that OnData was called or not. I'm planning to use the existing hack for this for now:

return did_respond() ? AlreadyResponded() : RespondLater();



 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4177bddffd6f1188254c499ca46ad3cc6a0f63d3

commit 4177bddffd6f1188254c499ca46ad3cc6a0f63d3
Author: Toni Barzic <tbarzic@chromium.org>
Date: Wed Apr 25 20:21:34 2018

User ReturnLater in EasyUnlockPrivateFindSetupConnectionFunction

The function implementation always returns asynchronously - either via
an delayed task, or  BluetoothLowEnergyConnectionFinder::Find callback,
which is run from InvokeCallbackAsync

BUG= 829182 

Change-Id: Id85b4b13fba166d10690eb258d034aab75a46b24
Reviewed-on: https://chromium-review.googlesource.com/1022372
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553716}
[modify] https://crrev.com/4177bddffd6f1188254c499ca46ad3cc6a0f63d3/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc

Status: Fixed (was: Assigned)

Sign in to add a comment