"//third_party/pywebsocket" adds Git internal dirs, extra cruft to net_unittests runtime deps |
|||
Issue description
"third_party/pywebsocket:pywebsocket" specifies a data dependency which includes all contents of pywebsocket, including ".git", READMEs, etc.:
group("pywebsocket") {
# For now, depend on the entire directory.
data = [
"//third_party/pywebsocket/",
]
}
This bloats net_unittests' runtime_deps, which we use when building deployment packages.
Please use a more explicit file listing for "data" instead.
,
May 14 2018
Sorry for being naive, but I don't understand what is caused by the "net_unittests' runtime_deps bloat". Can you explain it a bit?
,
May 14 2018
I chatted with Kevin offline and now understand the problem. Hiroshige's fix looks reasonable to me.
,
May 14 2018
I patched Hiroshige-san's fix and found that there is still Git metadata making its way into the runtime deps. The metadata looks like this: "third_party/pyftpdlib/src/.git/packed-refs" "third_party/pywebsocket/src/.git/objects/pack/pack-4bc77a0047de70cd15fa74fbb9942995c786e2c2.idx" "third_party/pyftpdlib/src/.git/hooks/applypatch-msg.sample" I think a likely culprit might be this entry: https://cs.chromium.org/chromium/src/net/BUILD.gn?rcl=7b6eac1b827694592986ebc608ea4e0dee2ae642&l=5444 This is mostly a code cleanup issue IMO - it just seems like there is some confusion in how the data dependencies are set up. The actual impact to test isolate sizes is small, around only several kilobytes. You can see the runtime deps by running $ gn desc out/fuch //net:net_unittests runtime_deps You can see that "../../third_party/pywebsocket/" is still in the list. I will downgrade the priority because this is mostly just a cleanup issue. Thanks! |
|||
►
Sign in to add a comment |
|||
Comment 1 by hirosh...@chromium.org
, May 14 2018