Filing as a separate and isolated bug, part of http://crbug.com/634140
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/716e18423192709f88bce7766532ef4963c66508 commit 716e18423192709f88bce7766532ef4963c66508 Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Thu Apr 05 18:47:39 2018 [Extensions] declarative API function -> UIThreadExtensionFunction AsynExtensionFunction is deprecated and will soon be removed. Bug: 829174 Change-Id: I1201a74737fff8846f0847e1a2ae1c3963d96af9 Reviewed-on: https://chromium-review.googlesource.com/997099 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548506} [modify] https://crrev.com/716e18423192709f88bce7766532ef4963c66508/extensions/browser/api/declarative/declarative_api.cc [modify] https://crrev.com/716e18423192709f88bce7766532ef4963c66508/extensions/browser/api/declarative/declarative_api.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e14b6278f94087cb5f05b1a94fff542e795534e commit 5e14b6278f94087cb5f05b1a94fff542e795534e Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Fri Apr 06 01:45:52 2018 [Extensions] Turn tab capture functions to UIThreadExtensionFunction. tabs api and webview have APIs for capturing tab contents, turn them to UIThreadExtensionFunction from AsyncExtensionFunction. AsyncExtensionFunction is deprecated and will be removed soon. Bug: 829174 Change-Id: I9cc390cc00903eab62b2e0b5ac42394333f243ec Reviewed-on: https://chromium-review.googlesource.com/997106 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548633} [modify] https://crrev.com/5e14b6278f94087cb5f05b1a94fff542e795534e/chrome/browser/extensions/api/tabs/tabs_api.cc [modify] https://crrev.com/5e14b6278f94087cb5f05b1a94fff542e795534e/chrome/browser/extensions/api/tabs/tabs_api.h [modify] https://crrev.com/5e14b6278f94087cb5f05b1a94fff542e795534e/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc [modify] https://crrev.com/5e14b6278f94087cb5f05b1a94fff542e795534e/extensions/browser/api/guest_view/web_view/web_view_internal_api.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0296cb1d0e16d6095e29dd161cd2e8ed368ffdad commit 0296cb1d0e16d6095e29dd161cd2e8ed368ffdad Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Tue Apr 10 00:41:33 2018 Remove some incorrect/obsolete reference to AsyncExtensionFunction. ChromeAsyncExtensionFunction does not derive from AsyncExtensionFunction, update such references, mostly in comments. Bug: 829174 Change-Id: Ic48ec85540f00660ecbb58899d501152c1117341 Reviewed-on: https://chromium-review.googlesource.com/1001772 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549351} [modify] https://crrev.com/0296cb1d0e16d6095e29dd161cd2e8ed368ffdad/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.h [modify] https://crrev.com/0296cb1d0e16d6095e29dd161cd2e8ed368ffdad/chrome/browser/chromeos/extensions/file_manager/private_api_base.h [modify] https://crrev.com/0296cb1d0e16d6095e29dd161cd2e8ed368ffdad/chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h [modify] https://crrev.com/0296cb1d0e16d6095e29dd161cd2e8ed368ffdad/chrome/browser/chromeos/extensions/file_manager/private_api_drive.h [modify] https://crrev.com/0296cb1d0e16d6095e29dd161cd2e8ed368ffdad/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.h [modify] https://crrev.com/0296cb1d0e16d6095e29dd161cd2e8ed368ffdad/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h [modify] https://crrev.com/0296cb1d0e16d6095e29dd161cd2e8ed368ffdad/chrome/browser/chromeos/extensions/file_manager/private_api_mount.h [modify] https://crrev.com/0296cb1d0e16d6095e29dd161cd2e8ed368ffdad/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.h [modify] https://crrev.com/0296cb1d0e16d6095e29dd161cd2e8ed368ffdad/chrome/browser/chromeos/extensions/users_private/users_private_api.h [modify] https://crrev.com/0296cb1d0e16d6095e29dd161cd2e8ed368ffdad/chrome/browser/extensions/api/bookmarks/bookmarks_api.h [modify] https://crrev.com/0296cb1d0e16d6095e29dd161cd2e8ed368ffdad/chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc [modify] https://crrev.com/0296cb1d0e16d6095e29dd161cd2e8ed368ffdad/chrome/browser/extensions/api/settings_private/settings_private_api.h [modify] https://crrev.com/0296cb1d0e16d6095e29dd161cd2e8ed368ffdad/extensions/browser/api/feedback_private/feedback_private_api.cc [modify] https://crrev.com/0296cb1d0e16d6095e29dd161cd2e8ed368ffdad/extensions/browser/api/feedback_private/feedback_private_api.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7962dd755f6418e6ae0e84ef96b6919a125e3cc1 commit 7962dd755f6418e6ae0e84ef96b6919a125e3cc1 Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Tue Apr 10 00:50:56 2018 Turn api functions related to ExecuteCode into UIThreadExtensionFunction. AsynExtensionFunction is deprecated. Bug: 829174 Change-Id: I1c257794f73dbf0bc3c042d15cc99851df77be2b Reviewed-on: https://chromium-review.googlesource.com/997025 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549353} [modify] https://crrev.com/7962dd755f6418e6ae0e84ef96b6919a125e3cc1/chrome/browser/extensions/api/tabs/tabs_api.cc [modify] https://crrev.com/7962dd755f6418e6ae0e84ef96b6919a125e3cc1/chrome/browser/extensions/api/tabs/tabs_api.h [modify] https://crrev.com/7962dd755f6418e6ae0e84ef96b6919a125e3cc1/extensions/browser/api/execute_code_function.cc [modify] https://crrev.com/7962dd755f6418e6ae0e84ef96b6919a125e3cc1/extensions/browser/api/execute_code_function.h [modify] https://crrev.com/7962dd755f6418e6ae0e84ef96b6919a125e3cc1/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc [modify] https://crrev.com/7962dd755f6418e6ae0e84ef96b6919a125e3cc1/extensions/browser/api/guest_view/web_view/web_view_internal_api.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb2837fb977d7f2754e2c417d69cda5648b6a67f commit cb2837fb977d7f2754e2c417d69cda5648b6a67f Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Tue Apr 10 01:22:25 2018 Turn wallpaper related api functions into UIThreadExtensionFunction. AsynExtensionFunction is deprecated and soon will be removed. This CL makes remaining wallpaper.* and wallpaperPrivate.* functions extend from UIThreadExtensionFunction. Bug: 829174 , 829653 Change-Id: I132bcea28e3406feb4f09743eea466214cc27a8d Reviewed-on: https://chromium-review.googlesource.com/997096 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549361} [modify] https://crrev.com/cb2837fb977d7f2754e2c417d69cda5648b6a67f/chrome/browser/chromeos/extensions/wallpaper_api.cc [modify] https://crrev.com/cb2837fb977d7f2754e2c417d69cda5648b6a67f/chrome/browser/chromeos/extensions/wallpaper_api.h [modify] https://crrev.com/cb2837fb977d7f2754e2c417d69cda5648b6a67f/chrome/browser/chromeos/extensions/wallpaper_function_base.cc [modify] https://crrev.com/cb2837fb977d7f2754e2c417d69cda5648b6a67f/chrome/browser/chromeos/extensions/wallpaper_function_base.h [modify] https://crrev.com/cb2837fb977d7f2754e2c417d69cda5648b6a67f/chrome/browser/chromeos/extensions/wallpaper_private_api.cc [modify] https://crrev.com/cb2837fb977d7f2754e2c417d69cda5648b6a67f/chrome/browser/chromeos/extensions/wallpaper_private_api.h [modify] https://crrev.com/cb2837fb977d7f2754e2c417d69cda5648b6a67f/chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2f37649eef024791523395255d51f77e50bd4cb commit a2f37649eef024791523395255d51f77e50bd4cb Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Tue Apr 10 03:16:58 2018 Remove some AsyncExtensionFunction usage in guest views. AsyncExtensionFunction is deprecated and will soon be deleted. Turn these guest functions into UIThreadExtensionFunction. This CL does not introduce any behavior changes. Bug: 829174 Change-Id: I275fe31ca3d33a87e137ee9c562aa6002e5ab6f1 Reviewed-on: https://chromium-review.googlesource.com/997109 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#549406} [modify] https://crrev.com/a2f37649eef024791523395255d51f77e50bd4cb/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc [modify] https://crrev.com/a2f37649eef024791523395255d51f77e50bd4cb/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h [modify] https://crrev.com/a2f37649eef024791523395255d51f77e50bd4cb/extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc [modify] https://crrev.com/a2f37649eef024791523395255d51f77e50bd4cb/extensions/browser/api/guest_view/extension_view/extension_view_internal_api.h [modify] https://crrev.com/a2f37649eef024791523395255d51f77e50bd4cb/extensions/browser/api/guest_view/guest_view_internal_api.cc [modify] https://crrev.com/a2f37649eef024791523395255d51f77e50bd4cb/extensions/browser/api/guest_view/guest_view_internal_api.h [modify] https://crrev.com/a2f37649eef024791523395255d51f77e50bd4cb/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc [modify] https://crrev.com/a2f37649eef024791523395255d51f77e50bd4cb/extensions/browser/api/guest_view/web_view/web_view_internal_api.h [modify] https://crrev.com/a2f37649eef024791523395255d51f77e50bd4cb/extensions/browser/guest_view/web_view/web_view_find_helper.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d06a25798ef3bb7a88276030a64c9af18d424467 commit d06a25798ef3bb7a88276030a64c9af18d424467 Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Tue Apr 10 16:49:32 2018 [Extensions] Remove AsyncExtensionFunction usage from bluetooth and related APIs AsyncExtensionFunction is deprecated and soon will be removed. This CL does not produce any behavior changes. Bug: 829174 Change-Id: Ic686837c11c4f8a4047a7748f133798e24d9203a Reviewed-on: https://chromium-review.googlesource.com/997098 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#549562} [modify] https://crrev.com/d06a25798ef3bb7a88276030a64c9af18d424467/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc [modify] https://crrev.com/d06a25798ef3bb7a88276030a64c9af18d424467/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h [modify] https://crrev.com/d06a25798ef3bb7a88276030a64c9af18d424467/extensions/browser/api/bluetooth/bluetooth_api.cc [modify] https://crrev.com/d06a25798ef3bb7a88276030a64c9af18d424467/extensions/browser/api/bluetooth/bluetooth_api.h [modify] https://crrev.com/d06a25798ef3bb7a88276030a64c9af18d424467/extensions/browser/api/bluetooth/bluetooth_extension_function.cc [modify] https://crrev.com/d06a25798ef3bb7a88276030a64c9af18d424467/extensions/browser/api/bluetooth/bluetooth_extension_function.h [modify] https://crrev.com/d06a25798ef3bb7a88276030a64c9af18d424467/extensions/browser/api/bluetooth/bluetooth_private_api.cc [modify] https://crrev.com/d06a25798ef3bb7a88276030a64c9af18d424467/extensions/browser/api/bluetooth/bluetooth_private_api.h [modify] https://crrev.com/d06a25798ef3bb7a88276030a64c9af18d424467/extensions/browser/api/bluetooth_socket/bluetooth_socket_api.cc [modify] https://crrev.com/d06a25798ef3bb7a88276030a64c9af18d424467/extensions/browser/api/bluetooth_socket/bluetooth_socket_api.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a commit f6e8e1ab048f5fa4d85442a159886fa6cd618a6a Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Thu Apr 12 07:30:31 2018 Remove AsyncExtensionFunction. Migrate the last few relatively easier APis from AsyncExtensionFunction to UIThreadExtensionFunction: - info_private - gcm - input_ime - music_manager_private - alarms - dns - socket - system_cpu - system_memory - webcam_private Remove AsyncExtensionFunction class entirely. AsyncApiFunction used to extension from AsyncExtensionFunction, for the time being subsume AsyncExtensionFunction's functionality directly inside AsyncApiFunction. Bug: 829174 , 829157 Change-Id: I2a509a08f0f802431776d76815fe2aa8f83b371b Reviewed-on: https://chromium-review.googlesource.com/1001792 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550074} [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/chrome/browser/chromeos/extensions/info_private_api.cc [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/chrome/browser/chromeos/extensions/info_private_api.h [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/chrome/browser/extensions/api/gcm/gcm_api.cc [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/chrome/browser/extensions/api/gcm/gcm_api.h [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.h [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/chrome/browser/extensions/api/music_manager_private/music_manager_private_api.cc [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/chrome/browser/extensions/api/music_manager_private/music_manager_private_api.h [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/alarms/alarms_api.cc [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/alarms/alarms_api.h [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/async_api_function.cc [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/async_api_function.h [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/dns/dns_api.cc [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/dns/dns_api.h [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/guest_view/web_view/web_view_internal_api.h [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/socket/socket_api.cc [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/socket/socket_api.h [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/system_cpu/system_cpu_api.cc [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/system_cpu/system_cpu_api.h [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/system_memory/system_memory_api.cc [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/system_memory/system_memory_api.h [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/webcam_private/webcam_private_api.h [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/extension_function.cc [modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/extension_function.h
Comment 1 by lazyboy@chromium.org
, Apr 5 2018