New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829170 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Build-Toolchain



Sign in to add a comment

autofdo: support specifying profiles for each board

Project Member Reported by laszio@chromium.org, Apr 5 2018

Issue description

Tasks:

1. Unify behaviors across different source of profiles. E.g., some are compressed in bz2 and some are xz.

2. Refactoring

3. Add more profile sources.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/1beee0bb7d7a0c0a00365a4860e28e62fbf52916

commit 1beee0bb7d7a0c0a00365a4860e28e62fbf52916
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Thu Apr 12 03:28:10 2018

AutoFDO: Use CWP profiles from silvermont for selected boards

BUG=chromium:829170
TEST=cros tryjob kip-release-tryjob

Change-Id: I0db61e4d43b953bbd715a9ba64bfaccb822a4de1
Reviewed-on: https://chromium-review.googlesource.com/1008242
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/1beee0bb7d7a0c0a00365a4860e28e62fbf52916/overlay-kip/make.conf
[modify] https://crrev.com/1beee0bb7d7a0c0a00365a4860e28e62fbf52916/overlay-snappy/make.conf
[modify] https://crrev.com/1beee0bb7d7a0c0a00365a4860e28e62fbf52916/overlay-variant-veyron-minnie/make.conf
[modify] https://crrev.com/1beee0bb7d7a0c0a00365a4860e28e62fbf52916/overlay-falco/make.conf
[modify] https://crrev.com/1beee0bb7d7a0c0a00365a4860e28e62fbf52916/overlay-parrot/make.conf
[modify] https://crrev.com/1beee0bb7d7a0c0a00365a4860e28e62fbf52916/overlay-kevin/make.conf
[modify] https://crrev.com/1beee0bb7d7a0c0a00365a4860e28e62fbf52916/overlay-elm/make.conf
[modify] https://crrev.com/1beee0bb7d7a0c0a00365a4860e28e62fbf52916/overlay-daisy/make.conf
[modify] https://crrev.com/1beee0bb7d7a0c0a00365a4860e28e62fbf52916/overlay-variant-parrot-ivb/make.conf
[modify] https://crrev.com/1beee0bb7d7a0c0a00365a4860e28e62fbf52916/overlay-variant-auron-yuna/make.conf
[modify] https://crrev.com/1beee0bb7d7a0c0a00365a4860e28e62fbf52916/overlay-cyan/make.conf
[modify] https://crrev.com/1beee0bb7d7a0c0a00365a4860e28e62fbf52916/overlay-eve/make.conf
[modify] https://crrev.com/1beee0bb7d7a0c0a00365a4860e28e62fbf52916/overlay-cave/make.conf

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d978ae7ab23f1b0d24985e45b7754c95a1b02d70

commit d978ae7ab23f1b0d24985e45b7754c95a1b02d70
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Fri Apr 13 00:48:07 2018

afdo: Refactoring to support multiple afdo profile sources

Instead of hard-coded variables, now different sources of afdo profiles
are specified in associative arrays.

BUG=chromium:829170
TEST=emerge-kip chromeos-chrome
     cros tryjob kip-release-tryjob
CQ-DEPEND=CL:1008282,CL:1008242,CL:*606947

Change-Id: Id9491b1051f503ee0e7a92bc7bb5f8c7c8f3dcd8
Reviewed-on: https://chromium-review.googlesource.com/1008263
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Commit-Queue: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/d978ae7ab23f1b0d24985e45b7754c95a1b02d70/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/d978ae7ab23f1b0d24985e45b7754c95a1b02d70/chromeos-base/chromeos-chrome/Manifest

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/4de067f4a1f1dca2a0fdf881dcf7be6c8ff4a62a

commit 4de067f4a1f1dca2a0fdf881dcf7be6c8ff4a62a
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Fri Apr 13 00:48:17 2018

afdo: refactoring to support multiple source of profiles

Instead of hard-coded names everywhere, now profiles are specified in
two dictionaries.

BUG=chromium:829170
TEST=afdo_unittest, afdo_stages_unittest
     cros tryjob master-chromium-pfq-tryjob chell-chrome-pfq-tryjob
CQ-DEPEND=CL:1008263

Change-Id: I8f8b6abad84e475fd338f0fc4c2903fde7d7c9f3
Reviewed-on: https://chromium-review.googlesource.com/1008282
Reviewed-by: Luis Lozano <llozano@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Commit-Queue: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/4de067f4a1f1dca2a0fdf881dcf7be6c8ff4a62a/cbuildbot/afdo.py
[add] https://crrev.com/4de067f4a1f1dca2a0fdf881dcf7be6c8ff4a62a/cbuildbot/stages/afdo_stages_unittest.py
[modify] https://crrev.com/4de067f4a1f1dca2a0fdf881dcf7be6c8ff4a62a/cbuildbot/stages/afdo_stages.py
[modify] https://crrev.com/4de067f4a1f1dca2a0fdf881dcf7be6c8ff4a62a/lib/cros_test_lib.py
[add] https://crrev.com/4de067f4a1f1dca2a0fdf881dcf7be6c8ff4a62a/cbuildbot/stages/afdo_stages_unittest
[modify] https://crrev.com/4de067f4a1f1dca2a0fdf881dcf7be6c8ff4a62a/cbuildbot/afdo_unittest.py

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e315bfa0c4fc24b95a86de5be5d4ff4d60842912

commit e315bfa0c4fc24b95a86de5be5d4ff4d60842912
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Fri Apr 13 00:49:20 2018

AutoFDO: more profile sources

This CL supports AutoFDO profiles from Airmont,
Haswell and Broadwell.

BUG=chromium:829170
TEST=emerge-eve chromeos-chrome
CQ-DEPEND=CL:1008263

Change-Id: Ida4ed4d2f231512adeb8e37bdfa1ff3bca541065
Reviewed-on: https://chromium-review.googlesource.com/1011348
Commit-Queue: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Trybot-Ready: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/e315bfa0c4fc24b95a86de5be5d4ff4d60842912/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/e315bfa0c4fc24b95a86de5be5d4ff4d60842912/chromeos-base/chromeos-chrome/Manifest

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a802392e9fb23def0f710c92f7928b36fcc725a6

commit a802392e9fb23def0f710c92f7928b36fcc725a6
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Fri Apr 13 00:49:32 2018

AutoFDO: more profile sources

TEST=afdo_unittest, afdo_stages_unittest
BUG=chromium:829170
CQ-DEPEND=CL:1011348

Change-Id: I03c51b741d6c726b90c785fef54c88ed8c308d9d
Reviewed-on: https://chromium-review.googlesource.com/1011258
Commit-Queue: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Trybot-Ready: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/a802392e9fb23def0f710c92f7928b36fcc725a6/cbuildbot/afdo.py
[modify] https://crrev.com/a802392e9fb23def0f710c92f7928b36fcc725a6/cbuildbot/afdo_unittest.py
[modify] https://crrev.com/a802392e9fb23def0f710c92f7928b36fcc725a6/cbuildbot/stages/afdo_stages_unittest.py

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/6fbffd3c877e78a7d8d0757aded8767ad6709e9e

commit 6fbffd3c877e78a7d8d0757aded8767ad6709e9e
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Fri Apr 13 00:49:42 2018

AutoFDO: adjust sources of profiles for selected boards

Boards using profiles from Airmont:
cyan, snappy

Boards using profiles from Broadwell:
cave, eve, falco, yuna

TEST=emerge-eve chromeos-chrome
BUG=chromium:829170
CQ-DEPEND=CL:1011348

Change-Id: I9bd163e7440dc5e3894f5e365a952d99730a810e
Reviewed-on: https://chromium-review.googlesource.com/1011358
Commit-Queue: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Trybot-Ready: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/6fbffd3c877e78a7d8d0757aded8767ad6709e9e/overlay-eve/make.conf
[modify] https://crrev.com/6fbffd3c877e78a7d8d0757aded8767ad6709e9e/overlay-falco/make.conf
[modify] https://crrev.com/6fbffd3c877e78a7d8d0757aded8767ad6709e9e/overlay-variant-auron-yuna/make.conf
[modify] https://crrev.com/6fbffd3c877e78a7d8d0757aded8767ad6709e9e/overlay-cyan/make.conf
[modify] https://crrev.com/6fbffd3c877e78a7d8d0757aded8767ad6709e9e/overlay-snappy/make.conf
[modify] https://crrev.com/6fbffd3c877e78a7d8d0757aded8767ad6709e9e/overlay-cave/make.conf

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2c5fab07bdbf375e97f621224ab1330c4e4d121

commit f2c5fab07bdbf375e97f621224ab1330c4e4d121
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Apr 13 05:57:35 2018

Roll src/third_party/chromite/ d2c34b35c..70bb7daa4 (3 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/d2c34b35c8b1..70bb7daa4183

$ git log d2c34b35c..70bb7daa4 --date=short --no-merges --format='%ad %ae %s'
2018-04-12 pwang chromeos_config: kevin-arcnext in CQ/Android PFQ/Chrome PFQ
2018-04-12 laszio AutoFDO: more profile sources
2018-04-06 laszio afdo: refactoring to support multiple source of profiles

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:829170,chromium:829170


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I725a6507963a3fa6e26222b62b5fddbcaffb6027
Reviewed-on: https://chromium-review.googlesource.com/1011822
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550525}
[modify] https://crrev.com/f2c5fab07bdbf375e97f621224ab1330c4e4d121/DEPS

Comment 9 by laszio@chromium.org, Apr 16 2018

Status: Verified (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2c5fab07bdbf375e97f621224ab1330c4e4d121

commit f2c5fab07bdbf375e97f621224ab1330c4e4d121
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Apr 13 05:57:35 2018

Roll src/third_party/chromite/ d2c34b35c..70bb7daa4 (3 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/d2c34b35c8b1..70bb7daa4183

$ git log d2c34b35c..70bb7daa4 --date=short --no-merges --format='%ad %ae %s'
2018-04-12 pwang chromeos_config: kevin-arcnext in CQ/Android PFQ/Chrome PFQ
2018-04-12 laszio AutoFDO: more profile sources
2018-04-06 laszio afdo: refactoring to support multiple source of profiles

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:829170,chromium:829170


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I725a6507963a3fa6e26222b62b5fddbcaffb6027
Reviewed-on: https://chromium-review.googlesource.com/1011822
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550525}
[modify] https://crrev.com/f2c5fab07bdbf375e97f621224ab1330c4e4d121/DEPS

Status: Available (was: Verified)
this implementation is currently flawed: you cannot use arbitrary env vars to change the behavior of ebuilds because that data is never reflected in the binpkg metadata.  that means portage is free to reuse binaries with otherwise matching details (but diff profile inputs) which is not what you want (or we should even allow).

you need to declare the new env var as USE expanded (look at chromiumos-overlays/profiles/base/make.defaults), and then your AFDO_PROFILE_SOURCE=foo will be turned into a USE=afdo_profile_source_foo flag automatically.  at that point, binpkgs would be correctly registering their metadata.

you'd still have the possibility of confusing/conflicting settings where by make.defaults might set AFDO_PROFILE_SOURCE=foo, but package.use could set USE="-afdo_profile_source_foo afdo_profile_source_bar", but the ebuild wouldn't do the right thing.
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/2304cacd8792b7f178cb4ea25324b19dff725761

commit 2304cacd8792b7f178cb4ea25324b19dff725761
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Sat Apr 21 06:01:43 2018

AutoFDO: moving profile selection to board overlays

Instead of having a use flag for each profile source, now they can be
specified in make.conf in board overlays.

TEST=emerge-eve chromeos-chrome
BUG=chromium:829170

Change-Id: Ibb2c77434f8c1d6dad01b779ff09253ba73d105c
Reviewed-on: https://chromium-review.googlesource.com/1011450
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/2304cacd8792b7f178cb4ea25324b19dff725761/cbuildbot/config_dump.json
[modify] https://crrev.com/2304cacd8792b7f178cb4ea25324b19dff725761/cbuildbot/chromeos_config.py

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a94d6e0fd8a4594bc5ac943e8530335506170ff

commit 0a94d6e0fd8a4594bc5ac943e8530335506170ff
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Apr 21 07:35:19 2018

Roll src/third_party/chromite/ ef1ada9ad..2304cacd8 (1 commit)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ef1ada9adf6a..2304cacd8792

$ git log ef1ada9ad..2304cacd8 --date=short --no-merges --format='%ad %ae %s'
2018-04-12 laszio AutoFDO: moving profile selection to board overlays

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:829170


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I0e32450f69200645a5937cdda810e2214f704d95
Reviewed-on: https://chromium-review.googlesource.com/1023375
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#552585}
[modify] https://crrev.com/0a94d6e0fd8a4594bc5ac943e8530335506170ff/DEPS

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8029d03ed66596de3e6e7585f033a0db28a56591

commit 8029d03ed66596de3e6e7585f033a0db28a56591
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Sat Apr 21 10:52:45 2018

chromeos-chrome: cleanup old use flags: afdo_chrome_exp*

They were used to select different source of autofdo profiles.
Now it is done by setting AFDO_PROFILE_SOURCE in make.defaults.

BUG=chromium:829170
TEST=cros tryjob kip-release-tryjob
CQ-DEPEND=CL:1011450

Change-Id: Ie38643053b15e0fe15644b1fe2aea9efcd7f2a2a
Reviewed-on: https://chromium-review.googlesource.com/1022980
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/8029d03ed66596de3e6e7585f033a0db28a56591/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

> you need to declare the new env var as USE expanded (look at chromiumos-
> overlays/profiles/base/make.defaults), and then your AFDO_PROFILE_SOURCE=foo 
> will be turned into a USE=afdo_profile_source_foo flag automatically.
> at that point, binpkgs would be correctly registering their metadata.

I just talked to Ting-Yuan about this on Friday. 

Comment 16 by ihf@chromium.org, Apr 26 2018

Cc: ihf@chromium.org tbarzic@chromium.org
We needed to pin back Chrome today and now builds are failing with
https://luci-milo.appspot.com/buildbot/chromeos/eve-arcnext-release/535




chromeos-chrome-68.0.3405.0_rc-r1: error: /build/eve-arcnext/tmp/portage/chromeos-base/chromeos-chrome-68.0.3405.0_rc-r1/work/afdo/broadwell_R68-3383.0-1524480987.afdo: Could not open profile: Unrecognized sample profile encoding format
Could this be related?
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/ca4fce5a2ac453676531f4b4f2c439807565d9b0

commit ca4fce5a2ac453676531f4b4f2c439807565d9b0
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Thu Apr 26 06:00:43 2018

afdo: refining codes

BUG=chromium:829170
TEST=afdo_statges_unittest

Change-Id: I2a1e316255ded9ea701981e191158887c50d7bb3
Reviewed-on: https://chromium-review.googlesource.com/1026648
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/ca4fce5a2ac453676531f4b4f2c439807565d9b0/cbuildbot/afdo.py
[modify] https://crrev.com/ca4fce5a2ac453676531f4b4f2c439807565d9b0/cbuildbot/stages/afdo_stages_unittest.py

Project Member

Comment 18 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/344eacf147bf39d4754fadc5b39408840f28fdcb

commit 344eacf147bf39d4754fadc5b39408840f28fdcb
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Apr 26 08:06:09 2018

Roll src/third_party/chromite/ 48a13aacf..aa6cca469 (9 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/48a13aacf880..aa6cca46950b

$ git log 48a13aacf..aa6cca469 --date=short --no-merges --format='%ad %ae %s'
2018-04-19 lepton cros_vm: Use a smaller virtual network.
2018-04-24 laszio afdo: refining codes
2018-04-10 dgarrett chromeos_config: TRYBOT -> SWARMING.
2018-04-24 rockot Include libmojo_core.so in Chrome deployment
2018-04-19 pberny chromeos_config: Add sign_types to meowth release
2018-04-20 achuith cros_run_vm_test: Support for fetching results.
2018-04-17 bmgordon cbuildbot: Add --previous-build-state option
2018-04-13 bmgordon build_summary: Helper class to represent build summaries
2018-04-24 dgarrett cros tryjob: Always use PRODUCTION_TRYJOB display label.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:808045,chromium:829170,chromium:None,chromium:822034,chromium:835061,chromium:829665,chromium:829665,chromium:832768


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7d1aa5c4c4bd153fd47f6d7cc7532ac35cdff73b
Reviewed-on: https://chromium-review.googlesource.com/1029771
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553948}
[modify] https://crrev.com/344eacf147bf39d4754fadc5b39408840f28fdcb/DEPS

#16: The AutoFDO profile (and therefore Chrome) was broken earlier this week:

https://bugs.chromium.org/p/chromium/issues/detail?id=836286
#16: There are 7 boards impacted: cyan, cave, eve, falco, auron_yuan, snappy. Other boards should be fine. 

Comment 21 by ihf@chromium.org, Apr 26 2018

Ok, thanks!
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4

commit fcf45ac1765f8fd5793bcf2b72e81a3117a775b4
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Thu Jul 12 06:06:42 2018

autofdo: move AFDO_PROFILE_SOURCE to make.defaults

BUG=chromium:829170
TEST=emerge-kip chromeos-chrome

Change-Id: Id506b348ae12576a3927d4da31b85cd336caf084
Reviewed-on: https://chromium-review.googlesource.com/1028977
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-kip/make.conf
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-snappy/make.conf
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-cyan/profiles/base/make.defaults
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-variant-auron-yuna/profiles/base/make.defaults
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-snappy/profiles/base/make.defaults
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-variant-veyron-minnie/make.conf
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-falco/make.conf
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-parrot/make.conf
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-kevin/make.conf
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-elm/make.conf
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-daisy/make.conf
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-variant-parrot-ivb/make.conf
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-falco/profiles/base/make.defaults
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-cave/profiles/base/make.defaults
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-variant-auron-yuna/make.conf
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-cyan/make.conf
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-eve/make.conf
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-eve/profiles/base/make.defaults
[modify] https://crrev.com/fcf45ac1765f8fd5793bcf2b72e81a3117a775b4/overlay-cave/make.conf

Status: Assigned (was: Available)

Sign in to add a comment