On Mon, Apr 23, 2018 at 8:48 PM, David Reveman <reveman@google.com> wrote:
hm, looks like we need to adds some explicit crostini code here: https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc

On Mon, Apr 23, 2018 at 5:31 PM David Reveman <reveman@google.com> wrote:
I think we need to set the profile on the shelf item or window. The profile switching goes through all windows and looks at the email of the profile to determine if a window should be hidden or visible, if I remember correctly.. I'll try to find the exact code when I have a chance.

On Mon, Apr 23, 2018 at 12:51 PM Jeffrey Kardatzke <jkardatzke@google.com> wrote:
David,

What specifically in the launcher integration needs to be done for this to be fixed?

https://groups.google.com/a/google.com/forum/#!topic/cros-containers-discuss/xZ_wqPsjGjE

Thanks,

-- 
Jeffrey Kardatzke
jkardatzke@google.com
Google, Inc.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa571e82bf30624b35fc7d6f30c2791b14d62207

commit fa571e82bf30624b35fc7d6f30c2791b14d62207
Author: Tim Zheng <timzheng@google.com>
Date: Fri Apr 27 18:22:37 2018

Multi-user support for Crostini apps.

This CL adds multiple user support for Crostini apps.
Crostini app window is registered to the user who launches it so when
user switch happens, Crostini app window will not leak to other users
in the session.
When user switch occurs, Crostini app windows launched by previous user
will be removed from the Shelf and Crostini app windows launched by the
current user will be added to the Shelf.

BUG= chromium:829159 
TEST=Manually tested on an eve device.

Change-Id: I2983d7087ffb87764954c2e8799b29a1ba46feec
Reviewed-on: https://chromium-review.googlesource.com/1031746
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554426}
[modify] https://crrev.com/fa571e82bf30624b35fc7d6f30c2791b14d62207/chrome/browser/ui/ash/launcher/crostini_app_window_shelf_controller.cc
[modify] https://crrev.com/fa571e82bf30624b35fc7d6f30c2791b14d62207/chrome/browser/ui/ash/launcher/crostini_app_window_shelf_controller.h

I got the daily build today ( Version 68.0.3416.0 (Official Build) dev (64-bit)
 ) and it has multiple odd issues with multi-user and Linux.

First - on my corp account, everything seemed fine and my existing container was used and things seemed good.  

Then a few hours later I opened my laptop and noticed the terminal wasn't in the tray any more or even in the full list of applications when I clicked the dot.  

Searching from the list showed me a terminal icon, which when I clicked on it, ran me through the terminal install flow again.

When the terminal launched, it was logged in with my personal user name (jason.titus vs my ldap of jtitus) and it was a different container without my previous directories and such.

When I switched accounts, the terminal window still showed and I could still interact with the same window. 

Seems like somehow me going into or doing something at some point in my other account got things into a strange state.

Attaching screenshots of accessing the terminal for jason.titus in both accounts.

Deleted: Screenshot 2018-05-02 at 8.40.13 PM.png 332 KB

	Screenshot 2018-05-02 at 8.40.13 PM.png 332 KB View Download

Deleted: Screenshot 2018-05-02 at 8.41.22 PM.png 347 KB

	Screenshot 2018-05-02 at 8.41.22 PM.png 347 KB View Download

Hi Tim Loh,

Can you take a look at Jason's latest bug description?
I don't fully understand your CL https://chromium-review.googlesource.com/c/chromium/src/+/1034555. You added the terminal window to crostini_app_window_shelf_controller.cc to manage. I think extension apps are managed to the shelf by extension_app_window_launcher_controller.cc. So if you don't filter it out then it can be managed by both, which is a problem.

Thanks
Tim Zheng

Crosh is a V1 packaged app, not an extension -- I don't really know the distinction, but crosh doesn't show up in extension_app_window_launcher_controller.cc.

It seems like it's being picked up somewhere else, see crbug.com/839676.

In chrome there are Browser windows, which handle web content, and also other types of AppWindows, for v2 packaged apps (ExtensionAppWindowController), Arc apps (ArcAppWindowController), etc.

v1 app windows are in Browser windows.

Not sure if that helps or not...

Remaining related issues are tracked by their own bugs.