New issue
Advanced search Search tips

Issue 829157 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

webcamPrivate.set never responds

Project Member Reported by lazyboy@chromium.org, Apr 5 2018

Issue description

From looking at WebcamPrivateSetFunction [1], it seems the function would only return errors if that happens, but never responds if the function succeeds.

Found this while working on AsyncExtensionFunction removal. Filing for record.

[1] https://cs.chromium.org/chromium/src/extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc?rcl=b338b429ae3653b945ee6ce96bef6c11932fda8f&l=234
 
Same ^^^ is true for webcamPrivate.reset()
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a

commit f6e8e1ab048f5fa4d85442a159886fa6cd618a6a
Author: Istiaque Ahmed <lazyboy@chromium.org>
Date: Thu Apr 12 07:30:31 2018

Remove AsyncExtensionFunction.

Migrate the last few relatively easier APis from AsyncExtensionFunction
to UIThreadExtensionFunction:
  - info_private
  - gcm
  - input_ime
  - music_manager_private
  - alarms
  - dns
  - socket
  - system_cpu
  - system_memory
  - webcam_private

Remove AsyncExtensionFunction class entirely. AsyncApiFunction used
to extension from AsyncExtensionFunction, for the time being subsume
AsyncExtensionFunction's functionality directly inside AsyncApiFunction.

Bug:  829174 ,  829157 
Change-Id: I2a509a08f0f802431776d76815fe2aa8f83b371b
Reviewed-on: https://chromium-review.googlesource.com/1001792
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550074}
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/chrome/browser/chromeos/extensions/info_private_api.cc
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/chrome/browser/chromeos/extensions/info_private_api.h
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/chrome/browser/extensions/api/gcm/gcm_api.cc
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/chrome/browser/extensions/api/gcm/gcm_api.h
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.h
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/chrome/browser/extensions/api/music_manager_private/music_manager_private_api.cc
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/chrome/browser/extensions/api/music_manager_private/music_manager_private_api.h
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/alarms/alarms_api.cc
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/alarms/alarms_api.h
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/async_api_function.cc
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/async_api_function.h
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/dns/dns_api.cc
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/dns/dns_api.h
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/guest_view/web_view/web_view_internal_api.h
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/socket/socket_api.cc
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/socket/socket_api.h
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/system_cpu/system_cpu_api.cc
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/system_cpu/system_cpu_api.h
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/system_memory/system_memory_api.cc
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/system_memory/system_memory_api.h
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/webcam_private/webcam_private_api.h
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/extension_function.cc
[modify] https://crrev.com/f6e8e1ab048f5fa4d85442a159886fa6cd618a6a/extensions/browser/extension_function.h

Status: Fixed (was: Started)

Sign in to add a comment