New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829154 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Improve team drives in Files.app to not fetch entire list of team drives on every fetch

Project Member Reported by sashab@chromium.org, Apr 5 2018

Issue description

Currently, Files.app fetches the entire list of team drives on every fetch when the --team-drives flag is enabled.

We should optimize this to only fetch when the team drives flag is triggered (changes between enabled/disabled on a delta fetch), or when the local database is cleared (full fetch).

The team drives flag state can be stored in the DB; see working patch at https://chromium-review.googlesource.com/c/chromium/src/+/979375/2.
 
Cc: -slangley@chromium.org
Owner: slangley@chromium.org
Status: Started (was: Available)
Labels: M-69
Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/279da6b0d92b52eca17e188c8b577e43c4f25eaf

commit 279da6b0d92b52eca17e188c8b577e43c4f25eaf
Author: Stuart Langley <slangley@chromium.org>
Date: Fri May 25 11:22:05 2018

Use TeamDriveListLoader to obtain the users team drive list on startup.

Currently the lists of users team drives is loaded on each update using
ChangeListLoader. We remove the logic from ChangeListLoader and use
TeamDriveListLoader instead. The full list is loaded only on startup, after
that team drive changes (new/removed/changed) will arrive via default change
list processing.

Bug:  845058 ,  829154 , 723955
Change-Id: I06c8d6d8e26ca1f02003768b879af8aa96a78b5b
Reviewed-on: https://chromium-review.googlesource.com/1073036
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561828}
[modify] https://crrev.com/279da6b0d92b52eca17e188c8b577e43c4f25eaf/components/drive/change_list_loader_unittest.cc
[modify] https://crrev.com/279da6b0d92b52eca17e188c8b577e43c4f25eaf/components/drive/chromeos/change_list_loader.cc
[modify] https://crrev.com/279da6b0d92b52eca17e188c8b577e43c4f25eaf/components/drive/chromeos/change_list_loader.h
[modify] https://crrev.com/279da6b0d92b52eca17e188c8b577e43c4f25eaf/components/drive/chromeos/default_corpus_change_list_loader.cc
[modify] https://crrev.com/279da6b0d92b52eca17e188c8b577e43c4f25eaf/components/drive/chromeos/default_corpus_change_list_loader.h

Status: Fixed (was: Started)

Sign in to add a comment