[VR Browsing] 2D UI 'Show Info' pop-up appears on chrome://history page |
|||
Issue descriptionChrome: 67.0.3387.0 VRCore: 1.13.185188193 Android N Device: S8+ What steps will reproduce the problem? (1) Go to chrome://history and enter VR browsing. (2) Click on the blue circle with the "!" in it next to the "History" heading label. (I only saw this when I was logged into Chrome) What is the expected result? The 2D pop-up should be suppressed or rendered in VR. What happens instead? A 2D pop-up "Show Info" appears, breaking the VR experience. See screenshot.
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8de0daeff8ce5548f04b364a7b166e057e12002e commit 8de0daeff8ce5548f04b364a7b166e057e12002e Author: Michael Thiessen <mthiesse@chromium.org> Date: Fri Apr 06 15:34:07 2018 Hide history page info icon toast when in VR. It should be impossible for this toast to show up while in VR as we intentionally never send long presses for exactly this reason. However, the toast is still showing up whenever the icon is clicked or scrolled over, but only on Android N. I've gone through the support library code, and overridden the long-press handler that shows the toast and the toast still shows up. I have no idea what's creating the toast or how to even find that out. The simplest solution seems to be just clearing the title when we're in VR, as the toast will never show up then. Bug: 829151 Change-Id: I9353ffa41ee44e488cc79d44ad6869961e11561f Reviewed-on: https://chromium-review.googlesource.com/998658 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#548782} [modify] https://crrev.com/8de0daeff8ce5548f04b364a7b166e057e12002e/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java
,
Apr 6 2018
,
May 8 2018
Verified on build 67.03396.29 beta. Looks good. |
|||
►
Sign in to add a comment |
|||
Comment 1 by mthiesse@chromium.org
, Apr 6 2018Owner: mthiesse@chromium.org
Status: Started (was: Untriaged)