Improve the tests for depot_tools |
|
Issue descriptionThis is a tracker bug for improving the tests on depot_tools. Some ideas I have: - Don't use mox so much. We should care more about the results we get, than the function calls we made to get there. - Improve the coverage. There are some script/tools that have no tests I could find. - Can we make them faster? - Are there things we can remove.
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0b1361ff38e4bd72f9be464f232ce5fb591c10e commit e0b1361ff38e4bd72f9be464f232ce5fb591c10e Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Apr 06 04:51:46 2018 Roll src/third_party/depot_tools/ 2a5f70cc0..1118a2193 (6 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2a5f70cc060a..1118a2193b8f $ git log 2a5f70cc0..1118a2193 --date=short --no-merges --format='%ad %ae %s' 2018-04-05 ehmaldonado gclient_eval: Support unpinned dependencies in SetRevision. 2018-04-05 ehmaldonado gclient_eval: Add more support when adding new variables. 2018-04-05 ehmaldonado gclient setdep: Command line interface nits. 2018-04-05 ehmaldonado presubmit_unittest: Remove redundant tests. 2018-04-05 sergeyberezin Roll mac_toolchain to 496a91484 2018-04-05 borenet roll-dep: Fix behavior for relative DEPS Created with: roll-dep src/third_party/depot_tools BUG= chromium:760633 , chromium:760633 , chromium:760633 ,chromium:829134,chromium:797051 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ibc387b556140307f5ed87c799cb5318c8c59e631 Reviewed-on: https://chromium-review.googlesource.com/999308 Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548671} [modify] https://crrev.com/e0b1361ff38e4bd72f9be464f232ce5fb591c10e/DEPS
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/428e7c14de188f6b5cab6908e24e41165628dd1b commit 428e7c14de188f6b5cab6908e24e41165628dd1b Author: Edward Lemur <ehmaldonado@chromium.org> Date: Tue May 22 16:14:17 2018 roll-dep: Add tests. Bug: 829134 Change-Id: Ifa4dc5572a17c9f2a3ab4bb04765106b1563ecae Reviewed-on: https://chromium-review.googlesource.com/1065081 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [add] https://crrev.com/428e7c14de188f6b5cab6908e24e41165628dd1b/tests/roll_dep_test.py [modify] https://crrev.com/428e7c14de188f6b5cab6908e24e41165628dd1b/tests/gclient_smoketest.py
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92d59e4ba226f2d9b94467a9bcf6628b754d5dcb commit 92d59e4ba226f2d9b94467a9bcf6628b754d5dcb Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue May 22 20:55:31 2018 Roll src/third_party/depot_tools/ 083eb25f9..398fb44e2 (2 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/083eb25f9acb..398fb44e2866 $ git log 083eb25f9..398fb44e2 --date=short --no-merges --format='%ad %ae %s' 2018-05-22 rharrison Print access errors using logging.error 2018-05-21 ehmaldonado roll-dep: Add tests. Created with: roll-dep src/third_party/depot_tools BUG=chromium:829134 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Idef2edda9678e0be50560b28a5501364ab479a9f Reviewed-on: https://chromium-review.googlesource.com/1069308 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560767} [modify] https://crrev.com/92d59e4ba226f2d9b94467a9bcf6628b754d5dcb/DEPS |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Apr 5 2018