[Findit] Swarming's ListSwarmingTasksDataByTags returns a list of SwarmingTaskData, not dict |
||
Issue descriptionCalling code that consumes this will fail as it is expecting a list of dicts, not SwarmingTaskData objects.
,
Apr 4 2018
To be clear it seems so far only swarming.py's GetReferredSwarmingTaskRequestInfo function is affected, and should be a 1 line fix minus unit tests
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/359f42c517cb8cbe07dd4ce228b108494a6868b3 commit 359f42c517cb8cbe07dd4ce228b108494a6868b3 Author: Jeffrey Li <lijeffrey@chromium.org> Date: Wed Apr 04 23:09:46 2018 [Findit] Fixing GetReferredSwarmingTaskRequestInfo swarming.ListSwarmingTasksDataByTags returns a list of SwarmingTaskData objects, not dicts. Bug: 829118 Change-Id: Ia790dc60101be8b1fb9ca13ddf66732aeb3e955c Reviewed-on: https://chromium-review.googlesource.com/996584 Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/359f42c517cb8cbe07dd4ce228b108494a6868b3/appengine/findit/services/swarming.py [modify] https://crrev.com/359f42c517cb8cbe07dd4ce228b108494a6868b3/appengine/findit/services/test/swarming_test.py
,
Apr 9 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by lijeffrey@chromium.org
, Apr 4 2018