FacingMode in VideoCaptureDeviceDescriptor is dropped when crossing Mojo boundary |
|||
Issue descriptionThe struct media::VideoCaptureDeviceDescriptor contains a field for facing_mode [1]. The corresponding mojo struct [2] does not contain this field. Because of it, the information will be dropped when crossing a Mojo boundary, i.e. when the video capture service is used. [1] https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device_descriptor.h?q=VideoCaptureDeviceDescriptor&dr=CSs&l=91 [2] https://cs.chromium.org/chromium/src/media/capture/mojom/video_capture_types.mojom?q=video_capture_types.mojom+file:%5Esrc/+package:%5Echromium$&dr&l=78
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abd2d5e33c1463be8ecf902841d463b187871ca3 commit abd2d5e33c1463be8ecf902841d463b187871ca3 Author: Christian Fremerey <chfremer@chromium.org> Date: Tue Jul 17 23:29:46 2018 [Video Capture Service] Fix for VideoFacing constraint not working The struct media::VideoCaptureDeviceDescriptor contains a field for facing_mode. The corresponding mojo struct does not contain this field. Because of it, the information will be dropped when crossing a Mojo boundary, i.e. when the video capture service is used. Bug: 829114 Change-Id: I8193c3db125450e80dd9f30b7babee3063013ef9 Reviewed-on: https://chromium-review.googlesource.com/1140956 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#575840} [modify] https://crrev.com/abd2d5e33c1463be8ecf902841d463b187871ca3/media/capture/mojom/video_capture_types.mojom [modify] https://crrev.com/abd2d5e33c1463be8ecf902841d463b187871ca3/media/capture/mojom/video_capture_types_mojom_traits.cc [modify] https://crrev.com/abd2d5e33c1463be8ecf902841d463b187871ca3/media/capture/mojom/video_capture_types_mojom_traits.h
,
Jul 24
Tested in 70.0.3498.0 and lgtm - thank you chfremer 8)
,
Aug 2
,
Aug 27
Is it fixed now?
,
Aug 27
|
|||
►
Sign in to add a comment |
|||
Comment 1 by chfremer@chromium.org
, Jul 17